Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support prune without turbo.json #3785

Conversation

chris-olszewski
Copy link
Member

Fixes #3645
Before #3216 we would ignore if turbo.json wasn't present. This PR restores that behavior by ignoring "not exists" errors.

Note: this is a slight UI change as we're now wrapping the not found error so we can match against it:
Previous:
ERROR failed to read turbo.json: Could not find turbo.json. Follow directions at https://turbo.build/repo/docs to create one: file does not exist
New:
ERROR failed to read turbo.json: Could not find turbo.json. Follow directions at https://turbo.build/repo/docs to create one: Could not find turbo.json: file does not exist

@chris-olszewski chris-olszewski marked this pull request as ready for review February 13, 2023 21:19
@chris-olszewski chris-olszewski requested a review from a team as a code owner February 13, 2023 21:19
@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-kitchensink-blog 🔄 Building (Inspect) Feb 27, 2023 at 2:50PM (UTC)
examples-native-web 🔄 Building (Inspect) Feb 27, 2023 at 2:50PM (UTC)
examples-vite-web 🔄 Building (Inspect) Feb 27, 2023 at 2:50PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 2:50PM (UTC)
6 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 27, 2023 at 2:50PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 27, 2023 at 2:50PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 27, 2023 at 2:50PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 27, 2023 at 2:50PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 27, 2023 at 2:50PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 27, 2023 at 2:50PM (UTC)

@vercel
Copy link

vercel bot commented Feb 13, 2023

@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@tknickman tknickman merged commit 6535d63 into vercel:main Feb 27, 2023
kodiakhq bot pushed a commit to timelessco/js-bottomsheet that referenced this pull request Feb 27, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [turbo](https://turbo.build/repo) ([source](https://github.com/vercel/turbo)) | [`^1.8.2` -> `^1.8.3`](https://renovatebot.com/diffs/npm/turbo/1.8.2/1.8.3) | [![age](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/compatibility-slim/1.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/confidence-slim/1.8.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/turbo</summary>

### [`v1.8.3`](https://github.com/vercel/turbo/releases/tag/v1.8.3): Turborepo v1.8.3

[Compare Source](https://github.com/vercel/turbo/compare/v1.8.2...v1.8.3)



#### What's Changed

##### Changelog

-   release(turborepo): 1.8.2 by [@&#8203;github-actions](https://github.com/github-actions) in [vercel/turborepo#3915
-   turbo-ignore doc. by [@&#8203;anthonyshew](https://github.com/anthonyshew) in [vercel/turborepo#3814
-   Align carets to key in JSON file by [@&#8203;n2o](https://github.com/n2o) in [vercel/turborepo#3909
-   fix(examples): svelte ([#&#8203;3919](https://github.com/vercel/turbo/issues/3919) by [@&#8203;tknickman](https://github.com/tknickman) in [vercel/turborepo#3919
-   fix(examples): kitchen-sink ([#&#8203;3920](https://github.com/vercel/turbo/issues/3920) by [@&#8203;tknickman](https://github.com/tknickman) in [vercel/turborepo#3920
-   fix(prettier): remove whitespace from example ([#&#8203;3924](https://github.com/vercel/turbo/issues/3924) by [@&#8203;tknickman](https://github.com/tknickman) in [vercel/turborepo#3924
-   Add empty `public` folder to stop Docker builds breaking by [@&#8203;a3957273](https://github.com/a3957273) in [vercel/turborepo#3899
-   feature: Use error_for_status by [@&#8203;NicholasLYang](https://github.com/NicholasLYang) in [vercel/turborepo#3898
-   fix: Inference with workspace config by [@&#8203;NicholasLYang](https://github.com/NicholasLYang) in [vercel/turborepo#3938
-   Add global hash inputs to dry run by [@&#8203;mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3934
-   Fix relative links on installing page by [@&#8203;mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3937
-   Update configuring-workspaces.mdx by [@&#8203;mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3940
-   Always look up task definition, but limit when it's added to traversa… by [@&#8203;mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3951
-   Update getting started to depend on turbo.json for order by [@&#8203;kevinsimper](https://github.com/kevinsimper) in [vercel/turborepo#3859
-   Root inference: skip turbo.json by [@&#8203;nathanhammond](https://github.com/nathanhammond) in [vercel/turborepo#3946
-   Add per-package-manager instructions to create-new by [@&#8203;nathanhammond](https://github.com/nathanhammond) in [vercel/turborepo#3971
-   fix: support prune without turbo.json by [@&#8203;chris-olszewski](https://github.com/chris-olszewski) in [vercel/turborepo#3785
-   chore(eslint): bump version by [@&#8203;tknickman](https://github.com/tknickman) in [vercel/turborepo#3976
-   release(turborepo): 1.8.3-canary.0 by [@&#8203;github-actions](https://github.com/github-actions) in [vercel/turborepo#3981

#### New Contributors

-   [@&#8203;n2o](https://github.com/n2o) made their first contribution in [vercel/turborepo#3909
-   [@&#8203;a3957273](https://github.com/a3957273) made their first contribution in [vercel/turborepo#3899
-   [@&#8203;kevinsimper](https://github.com/kevinsimper) made their first contribution in [vercel/turborepo#3859
-   [@&#8203;The-0xAlex](https://github.com/The-0xAlex) made their first contribution in [vercel/turborepo#3968

**Full Changelog**: vercel/turborepo@v1.8.2...v1.8.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 12am and before 5am every weekday,every weekend" in timezone Asia/Kolkata, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/timelessco/js-bottomsheet).
thedoublejay pushed a commit to levaintech/sticky that referenced this pull request Feb 28, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [turbo](https://turbo.build/repo)
([source](https://github.com/vercel/turbo)) | [`1.8.2` ->
`1.8.3`](https://renovatebot.com/diffs/npm/turbo/1.8.2/1.8.3) |
[![age](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/compatibility-slim/1.8.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/confidence-slim/1.8.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vercel/turbo</summary>

### [`v1.8.3`](https://github.com/vercel/turbo/releases/tag/v1.8.3):
Turborepo v1.8.3

[Compare
Source](https://github.com/vercel/turbo/compare/v1.8.2...v1.8.3)

<!-- Release notes generated using configuration in
.github/turborepo-release.yml at v1.8.3 -->

#### What's Changed

##### Changelog

- release(turborepo): 1.8.2 by
[@&#8203;github-actions](https://github.com/github-actions) in
[vercel/turborepo#3915
- turbo-ignore doc. by
[@&#8203;anthonyshew](https://github.com/anthonyshew) in
[vercel/turborepo#3814
- Align carets to key in JSON file by
[@&#8203;n2o](https://github.com/n2o) in
[vercel/turborepo#3909
- fix(examples): svelte
([#&#8203;3919](https://github.com/vercel/turbo/issues/3919) by
[@&#8203;tknickman](https://github.com/tknickman) in
[vercel/turborepo#3919
- fix(examples): kitchen-sink
([#&#8203;3920](https://github.com/vercel/turbo/issues/3920) by
[@&#8203;tknickman](https://github.com/tknickman) in
[vercel/turborepo#3920
- fix(prettier): remove whitespace from example
([#&#8203;3924](https://github.com/vercel/turbo/issues/3924) by
[@&#8203;tknickman](https://github.com/tknickman) in
[vercel/turborepo#3924
- Add empty `public` folder to stop Docker builds breaking by
[@&#8203;a3957273](https://github.com/a3957273) in
[vercel/turborepo#3899
- feature: Use error_for_status by
[@&#8203;NicholasLYang](https://github.com/NicholasLYang) in
[vercel/turborepo#3898
- fix: Inference with workspace config by
[@&#8203;NicholasLYang](https://github.com/NicholasLYang) in
[vercel/turborepo#3938
- Add global hash inputs to dry run by
[@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3934
- Fix relative links on installing page by
[@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3937
- Update configuring-workspaces.mdx by
[@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3940
- Always look up task definition, but limit when it's added to traversa…
by [@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3951
- Update getting started to depend on turbo.json for order by
[@&#8203;kevinsimper](https://github.com/kevinsimper) in
[vercel/turborepo#3859
- Root inference: skip turbo.json by
[@&#8203;nathanhammond](https://github.com/nathanhammond) in
[vercel/turborepo#3946
- Add per-package-manager instructions to create-new by
[@&#8203;nathanhammond](https://github.com/nathanhammond) in
[vercel/turborepo#3971
- fix: support prune without turbo.json by
[@&#8203;chris-olszewski](https://github.com/chris-olszewski) in
[vercel/turborepo#3785
- chore(eslint): bump version by
[@&#8203;tknickman](https://github.com/tknickman) in
[vercel/turborepo#3976
- release(turborepo): 1.8.3-canary.0 by
[@&#8203;github-actions](https://github.com/github-actions) in
[vercel/turborepo#3981

#### New Contributors

- [@&#8203;n2o](https://github.com/n2o) made their first contribution
in
[vercel/turborepo#3909
- [@&#8203;a3957273](https://github.com/a3957273) made their first
contribution in
[vercel/turborepo#3899
- [@&#8203;kevinsimper](https://github.com/kevinsimper) made their
first contribution in
[vercel/turborepo#3859
- [@&#8203;The-0xAlex](https://github.com/The-0xAlex) made their first
contribution in
[vercel/turborepo#3968

**Full Changelog**:
vercel/turborepo@v1.8.2...v1.8.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/sticky).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTIuNSIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi41In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh pushed a commit to fuxingloh/contented that referenced this pull request Feb 28, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [turbo](https://turbo.build/repo)
([source](https://github.com/vercel/turbo)) | [`^1.8.1` ->
`^1.8.3`](https://renovatebot.com/diffs/npm/turbo/1.8.1/1.8.3) |
[![age](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/compatibility-slim/1.8.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/turbo/1.8.3/confidence-slim/1.8.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vercel/turbo</summary>

### [`v1.8.3`](https://github.com/vercel/turbo/releases/tag/v1.8.3):
Turborepo v1.8.3

[Compare
Source](https://github.com/vercel/turbo/compare/v1.8.2...v1.8.3)

<!-- Release notes generated using configuration in
.github/turborepo-release.yml at v1.8.3 -->

#### What's Changed

##### Changelog

- release(turborepo): 1.8.2 by
[@&#8203;github-actions](https://github.com/github-actions) in
[vercel/turborepo#3915
- turbo-ignore doc. by
[@&#8203;anthonyshew](https://github.com/anthonyshew) in
[vercel/turborepo#3814
- Align carets to key in JSON file by
[@&#8203;n2o](https://github.com/n2o) in
[vercel/turborepo#3909
- fix(examples): svelte
([#&#8203;3919](https://github.com/vercel/turbo/issues/3919) by
[@&#8203;tknickman](https://github.com/tknickman) in
[vercel/turborepo#3919
- fix(examples): kitchen-sink
([#&#8203;3920](https://github.com/vercel/turbo/issues/3920) by
[@&#8203;tknickman](https://github.com/tknickman) in
[vercel/turborepo#3920
- fix(prettier): remove whitespace from example
([#&#8203;3924](https://github.com/vercel/turbo/issues/3924) by
[@&#8203;tknickman](https://github.com/tknickman) in
[vercel/turborepo#3924
- Add empty `public` folder to stop Docker builds breaking by
[@&#8203;a3957273](https://github.com/a3957273) in
[vercel/turborepo#3899
- feature: Use error_for_status by
[@&#8203;NicholasLYang](https://github.com/NicholasLYang) in
[vercel/turborepo#3898
- fix: Inference with workspace config by
[@&#8203;NicholasLYang](https://github.com/NicholasLYang) in
[vercel/turborepo#3938
- Add global hash inputs to dry run by
[@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3934
- Fix relative links on installing page by
[@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3937
- Update configuring-workspaces.mdx by
[@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3940
- Always look up task definition, but limit when it's added to traversa…
by [@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3951
- Update getting started to depend on turbo.json for order by
[@&#8203;kevinsimper](https://github.com/kevinsimper) in
[vercel/turborepo#3859
- Root inference: skip turbo.json by
[@&#8203;nathanhammond](https://github.com/nathanhammond) in
[vercel/turborepo#3946
- Add per-package-manager instructions to create-new by
[@&#8203;nathanhammond](https://github.com/nathanhammond) in
[vercel/turborepo#3971
- fix: support prune without turbo.json by
[@&#8203;chris-olszewski](https://github.com/chris-olszewski) in
[vercel/turborepo#3785
- chore(eslint): bump version by
[@&#8203;tknickman](https://github.com/tknickman) in
[vercel/turborepo#3976
- release(turborepo): 1.8.3-canary.0 by
[@&#8203;github-actions](https://github.com/github-actions) in
[vercel/turborepo#3981

#### New Contributors

- [@&#8203;n2o](https://github.com/n2o) made their first contribution
in
[vercel/turborepo#3909
- [@&#8203;a3957273](https://github.com/a3957273) made their first
contribution in
[vercel/turborepo#3899
- [@&#8203;kevinsimper](https://github.com/kevinsimper) made their
first contribution in
[vercel/turborepo#3859
- [@&#8203;The-0xAlex](https://github.com/The-0xAlex) made their first
contribution in
[vercel/turborepo#3968

**Full Changelog**:
vercel/turborepo@v1.8.2...v1.8.3

### [`v1.8.2`](https://github.com/vercel/turbo/releases/tag/v1.8.2):
Turborepo v1.8.2

[Compare
Source](https://github.com/vercel/turbo/compare/v1.8.1...v1.8.2)

<!-- Release notes generated using configuration in
.github/turborepo-release.yml at v1.8.2 -->

#### What's Changed

##### Changelog

- release(turborepo): 1.8.1 by
[@&#8203;github-actions](https://github.com/github-actions) in
[vercel/turborepo#3869
- refactor: remove `react/jsx-key` ESLint rule by
[@&#8203;albertothedev](https://github.com/albertothedev) in
[vercel/turborepo#3880
- Add missing comma to dependsOn code example by
[@&#8203;jan-paulus](https://github.com/jan-paulus) in
[vercel/turborepo#3884
- Add --log-prefix=none option by
[@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3851
- Fix turbo run when --filter is provided and no packages are affected
by [@&#8203;mehulkar](https://github.com/mehulkar) in
[vercel/turborepo#3901
- release(turborepo): 1.8.2-canary.0 by
[@&#8203;github-actions](https://github.com/github-actions) in
[vercel/turborepo#3906

#### New Contributors

- [@&#8203;albertothedev](https://github.com/albertothedev) made their
first contribution in
[vercel/turborepo#3880
- [@&#8203;jan-paulus](https://github.com/jan-paulus) made their first
contribution in
[vercel/turborepo#3884

**Full Changelog**:
vercel/turborepo@v1.8.1...v1.8.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi41In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[turborepo] Regression - Using turbo prune was working without turbo.json, fails since 1.7.1
3 participants