fix: Inference with workspace config #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
@NicholasLYang is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
tknickman
approved these changes
Feb 23, 2023
|
If |
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
Integration tests for inferring the root. This demonstrates that detection based upon `turbo.json` (and the change made in #3938) is not (particularly) relevant to root identification. How to review: - Each commit is pretty self-contained. You can see me adding a debug line to assert against in the first commit. - The third commit is both a revert of #3938 and a full deletion of the `turbo.json`-included detection logic. <details> <summary>OUTDATED</summary> There is _one_ behavior change. If you previously: 1. Had nested workspaces (which is not supported by us or any package manager). 2. Had a `turbo.json` at the "outer" one. 3. Did _not_ have a `turbo.json` at the "inner" one Then we would have selected the outer one. We now select the inner one, and throw an error because the inner one does not have a `turbo.json`. I believe this to be an _improvement_. </details> *** #3938 treats any `turbo.json` that has comments in it as nonexistent since `serde_json` doesn't support JSONC. That everything still worked with parsing that is throwing an error made it clear that the `turbo.json` check was not being used except for the described edge case.
kodiakhq bot
pushed a commit
to timelessco/js-bottomsheet
that referenced
this pull request
Feb 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turbo.build/repo) ([source](https://github.com/vercel/turbo)) | [`^1.8.2` -> `^1.8.3`](https://renovatebot.com/diffs/npm/turbo/1.8.2/1.8.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo</summary> ### [`v1.8.3`](https://github.com/vercel/turbo/releases/tag/v1.8.3): Turborepo v1.8.3 [Compare Source](https://github.com/vercel/turbo/compare/v1.8.2...v1.8.3) #### What's Changed ##### Changelog - release(turborepo): 1.8.2 by [@​github-actions](https://github.com/github-actions) in [vercel/turborepo#3915 - turbo-ignore doc. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turborepo#3814 - Align carets to key in JSON file by [@​n2o](https://github.com/n2o) in [vercel/turborepo#3909 - fix(examples): svelte ([#​3919](https://github.com/vercel/turbo/issues/3919) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3919 - fix(examples): kitchen-sink ([#​3920](https://github.com/vercel/turbo/issues/3920) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3920 - fix(prettier): remove whitespace from example ([#​3924](https://github.com/vercel/turbo/issues/3924) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3924 - Add empty `public` folder to stop Docker builds breaking by [@​a3957273](https://github.com/a3957273) in [vercel/turborepo#3899 - feature: Use error_for_status by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turborepo#3898 - fix: Inference with workspace config by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turborepo#3938 - Add global hash inputs to dry run by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3934 - Fix relative links on installing page by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3937 - Update configuring-workspaces.mdx by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3940 - Always look up task definition, but limit when it's added to traversa… by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3951 - Update getting started to depend on turbo.json for order by [@​kevinsimper](https://github.com/kevinsimper) in [vercel/turborepo#3859 - Root inference: skip turbo.json by [@​nathanhammond](https://github.com/nathanhammond) in [vercel/turborepo#3946 - Add per-package-manager instructions to create-new by [@​nathanhammond](https://github.com/nathanhammond) in [vercel/turborepo#3971 - fix: support prune without turbo.json by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turborepo#3785 - chore(eslint): bump version by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3976 - release(turborepo): 1.8.3-canary.0 by [@​github-actions](https://github.com/github-actions) in [vercel/turborepo#3981 #### New Contributors - [@​n2o](https://github.com/n2o) made their first contribution in [vercel/turborepo#3909 - [@​a3957273](https://github.com/a3957273) made their first contribution in [vercel/turborepo#3899 - [@​kevinsimper](https://github.com/kevinsimper) made their first contribution in [vercel/turborepo#3859 - [@​The-0xAlex](https://github.com/The-0xAlex) made their first contribution in [vercel/turborepo#3968 **Full Changelog**: vercel/turborepo@v1.8.2...v1.8.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 12am and before 5am every weekday,every weekend" in timezone Asia/Kolkata, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/timelessco/js-bottomsheet).
](https://renovatebot.com){kind=link}
thedoublejay
pushed a commit
to levaintech/sticky
that referenced
this pull request
Feb 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turbo.build/repo) ([source](https://github.com/vercel/turbo)) | [`1.8.2` -> `1.8.3`](https://renovatebot.com/diffs/npm/turbo/1.8.2/1.8.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo</summary> ### [`v1.8.3`](https://github.com/vercel/turbo/releases/tag/v1.8.3): Turborepo v1.8.3 [Compare Source](https://github.com/vercel/turbo/compare/v1.8.2...v1.8.3) <!-- Release notes generated using configuration in .github/turborepo-release.yml at v1.8.3 --> #### What's Changed ##### Changelog - release(turborepo): 1.8.2 by [@​github-actions](https://github.com/github-actions) in [vercel/turborepo#3915 - turbo-ignore doc. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turborepo#3814 - Align carets to key in JSON file by [@​n2o](https://github.com/n2o) in [vercel/turborepo#3909 - fix(examples): svelte ([#​3919](https://github.com/vercel/turbo/issues/3919) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3919 - fix(examples): kitchen-sink ([#​3920](https://github.com/vercel/turbo/issues/3920) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3920 - fix(prettier): remove whitespace from example ([#​3924](https://github.com/vercel/turbo/issues/3924) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3924 - Add empty `public` folder to stop Docker builds breaking by [@​a3957273](https://github.com/a3957273) in [vercel/turborepo#3899 - feature: Use error_for_status by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turborepo#3898 - fix: Inference with workspace config by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turborepo#3938 - Add global hash inputs to dry run by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3934 - Fix relative links on installing page by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3937 - Update configuring-workspaces.mdx by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3940 - Always look up task definition, but limit when it's added to traversa… by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3951 - Update getting started to depend on turbo.json for order by [@​kevinsimper](https://github.com/kevinsimper) in [vercel/turborepo#3859 - Root inference: skip turbo.json by [@​nathanhammond](https://github.com/nathanhammond) in [vercel/turborepo#3946 - Add per-package-manager instructions to create-new by [@​nathanhammond](https://github.com/nathanhammond) in [vercel/turborepo#3971 - fix: support prune without turbo.json by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turborepo#3785 - chore(eslint): bump version by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3976 - release(turborepo): 1.8.3-canary.0 by [@​github-actions](https://github.com/github-actions) in [vercel/turborepo#3981 #### New Contributors - [@​n2o](https://github.com/n2o) made their first contribution in [vercel/turborepo#3909 - [@​a3957273](https://github.com/a3957273) made their first contribution in [vercel/turborepo#3899 - [@​kevinsimper](https://github.com/kevinsimper) made their first contribution in [vercel/turborepo#3859 - [@​The-0xAlex](https://github.com/The-0xAlex) made their first contribution in [vercel/turborepo#3968 **Full Changelog**: vercel/turborepo@v1.8.2...v1.8.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/sticky). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTIuNSIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi41In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh
pushed a commit
to fuxingloh/contented
that referenced
this pull request
Feb 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turbo.build/repo) ([source](https://github.com/vercel/turbo)) | [`^1.8.1` -> `^1.8.3`](https://renovatebot.com/diffs/npm/turbo/1.8.1/1.8.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo</summary> ### [`v1.8.3`](https://github.com/vercel/turbo/releases/tag/v1.8.3): Turborepo v1.8.3 [Compare Source](https://github.com/vercel/turbo/compare/v1.8.2...v1.8.3) <!-- Release notes generated using configuration in .github/turborepo-release.yml at v1.8.3 --> #### What's Changed ##### Changelog - release(turborepo): 1.8.2 by [@​github-actions](https://github.com/github-actions) in [vercel/turborepo#3915 - turbo-ignore doc. by [@​anthonyshew](https://github.com/anthonyshew) in [vercel/turborepo#3814 - Align carets to key in JSON file by [@​n2o](https://github.com/n2o) in [vercel/turborepo#3909 - fix(examples): svelte ([#​3919](https://github.com/vercel/turbo/issues/3919) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3919 - fix(examples): kitchen-sink ([#​3920](https://github.com/vercel/turbo/issues/3920) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3920 - fix(prettier): remove whitespace from example ([#​3924](https://github.com/vercel/turbo/issues/3924) by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3924 - Add empty `public` folder to stop Docker builds breaking by [@​a3957273](https://github.com/a3957273) in [vercel/turborepo#3899 - feature: Use error_for_status by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turborepo#3898 - fix: Inference with workspace config by [@​NicholasLYang](https://github.com/NicholasLYang) in [vercel/turborepo#3938 - Add global hash inputs to dry run by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3934 - Fix relative links on installing page by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3937 - Update configuring-workspaces.mdx by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3940 - Always look up task definition, but limit when it's added to traversa… by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3951 - Update getting started to depend on turbo.json for order by [@​kevinsimper](https://github.com/kevinsimper) in [vercel/turborepo#3859 - Root inference: skip turbo.json by [@​nathanhammond](https://github.com/nathanhammond) in [vercel/turborepo#3946 - Add per-package-manager instructions to create-new by [@​nathanhammond](https://github.com/nathanhammond) in [vercel/turborepo#3971 - fix: support prune without turbo.json by [@​chris-olszewski](https://github.com/chris-olszewski) in [vercel/turborepo#3785 - chore(eslint): bump version by [@​tknickman](https://github.com/tknickman) in [vercel/turborepo#3976 - release(turborepo): 1.8.3-canary.0 by [@​github-actions](https://github.com/github-actions) in [vercel/turborepo#3981 #### New Contributors - [@​n2o](https://github.com/n2o) made their first contribution in [vercel/turborepo#3909 - [@​a3957273](https://github.com/a3957273) made their first contribution in [vercel/turborepo#3899 - [@​kevinsimper](https://github.com/kevinsimper) made their first contribution in [vercel/turborepo#3859 - [@​The-0xAlex](https://github.com/The-0xAlex) made their first contribution in [vercel/turborepo#3968 **Full Changelog**: vercel/turborepo@v1.8.2...v1.8.3 ### [`v1.8.2`](https://github.com/vercel/turbo/releases/tag/v1.8.2): Turborepo v1.8.2 [Compare Source](https://github.com/vercel/turbo/compare/v1.8.1...v1.8.2) <!-- Release notes generated using configuration in .github/turborepo-release.yml at v1.8.2 --> #### What's Changed ##### Changelog - release(turborepo): 1.8.1 by [@​github-actions](https://github.com/github-actions) in [vercel/turborepo#3869 - refactor: remove `react/jsx-key` ESLint rule by [@​albertothedev](https://github.com/albertothedev) in [vercel/turborepo#3880 - Add missing comma to dependsOn code example by [@​jan-paulus](https://github.com/jan-paulus) in [vercel/turborepo#3884 - Add --log-prefix=none option by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3851 - Fix turbo run when --filter is provided and no packages are affected by [@​mehulkar](https://github.com/mehulkar) in [vercel/turborepo#3901 - release(turborepo): 1.8.2-canary.0 by [@​github-actions](https://github.com/github-actions) in [vercel/turborepo#3906 #### New Contributors - [@​albertothedev](https://github.com/albertothedev) made their first contribution in [vercel/turborepo#3880 - [@​jan-paulus](https://github.com/jan-paulus) made their first contribution in [vercel/turborepo#3884 **Full Changelog**: vercel/turborepo@v1.8.1...v1.8.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi41In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.