feature(turborepo): Port login without sso team #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
@NicholasLYang is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
area: ci
area: turbopack
pkg: create-turbo
NicholasLYang
force-pushed
the
nicholasyang/login-without-sso-team
branch
from
4533602
to
54c8539
Compare
github-actions
bot
added
area: docs
arlyon
reviewed
Jan 26, 2023
chris-olszewski
requested changes
Jan 26, 2023
crates/turborepo-lib/src/ui/mod.rs
Outdated
Comment on lines
51
to
64
| pub fn rainbow<'a>(&self, text: &'a str) -> Cow<'a, str> { | ||
| if self.should_strip_ansi { | ||
| return Cow::Borrowed(text); | ||
| } | ||
|
|
||
| let mut out = Vec::new(); | ||
| for (i, c) in text.char_indices() { | ||
| let (r, g, b) = Self::rainbow_rgb(i); | ||
| out.push(format!( | ||
| "\x1b[1m\x1b[38;2;{};{};{}m{}\x1b[0m\x1b[0;1m", | ||
| r, g, b, c | ||
| )); | ||
| } | ||
| out.push(RESET.to_string()); |
There was a problem hiding this comment.
Not blocking, but we use tiny_gradient in the shim for coloring. It would be nice to consolidate our gradient logic
There was a problem hiding this comment.
Yeah...I'm personally of the opinion that we should keep this because it has a fallback for Apple Terminal and has color stripping.
Comment on lines
+11
to
+15
| #[async_trait] | ||
| pub trait UserClient { | ||
| fn set_token(&mut self, token: String); | ||
| async fn get_user(&self) -> Result<UserResponse>; | ||
| } |
There was a problem hiding this comment.
I'm assuming this trait is here for testing, but I'm not seeing any use this. Will we need to refactor the login to use this trait before we can add tests?
There was a problem hiding this comment.
A little bit. I can add tests as a follow up PR
chris-olszewski
approved these changes
Jan 26, 2023
|
Looks like failures are from a bad |
NicholasLYang
added
the
pr: automerge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.