Fix integration tests #3520
Merged
Fix integration tests #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
mehulkar
force-pushed
the
mk/fix-tests
branch
from
6184c3a
to
b35236a
Compare
tknickman
approved these changes
Jan 27, 2023
|
It's the flaky failure 😢 |
mehulkar
force-pushed
the
mk/fix-tests
branch
from
b35236a
to
af601c8
Compare
|
Rebased in case #3503 wasn't picked up yet |
chris-olszewski
approved these changes
Jan 27, 2023
mehulkar
commented
Jan 27, 2023
| @@ -41,6 +41,7 @@ Verbosity level 2 | |||
| [-0-9:.TWZ+]+ \[DEBUG] turborepo_lib::shim: No local turbo binary found at: .+node_modules/\.bin/turbo (re) | |||
| [-0-9:.TWZ+]+ \[DEBUG] turborepo_lib::shim: Running command as global turbo (re) | |||
| [-0-9:.TWZ+]+ \[DEBUG] turborepo_lib::cli: pkg_inference_root set to "" (re) | |||
| [-0-9:.TWZ+]+ \[DEBUG] turbo: Found go binary at "[\-\w\/]+" (re) | |||
There was a problem hiding this comment.
This wasn't caught because this line comes from Rust and we weren't running integration tests on changes to Rust portion. This is fixed in #3442.
| [] | ||
| [ | ||
| "util" | ||
| ] |
There was a problem hiding this comment.
This was accidentally merged in #3372, there was a legitimate failure, but it was missed because there were a lot of other unrelated failures that were safe to ignore in that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.