Move E2E tests to main test.yml workflow #3442

mehulkar · 2023-01-24T00:26:55Z

No description provided.

vercel · 2023-01-24T00:27:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments

Name	Status	Preview	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Jan 27, 2023 at 10:37PM (UTC)

github-actions · 2023-01-24T00:41:12Z

Failing next.js integration test suites

Commit: f7222aa

test/development/acceptance-app/component-stack.test.ts

Component Stack in error overlay > should show a component stack on hydration error

Expand output

● Component Stack in error overlay › should show a component stack on hydration error

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('[data-nextjs-toast]')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/e2e/edge-api-endpoints-can-receive-body/index.test.ts

Edge API endpoints can receive body > reads the body as text
Edge API endpoints can receive body > reads the body from index

Expand output

● Edge API endpoints can receive body › reads the body as text

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 500

  33 |     )
  34 |
> 35 |     expect(res.status).toBe(200)
     |                        ^
  36 |     expect(await res.text()).toBe('got: hello, world.')
  37 |   })
  38 |

  at Object.<anonymous> (e2e/edge-api-endpoints-can-receive-body/index.test.ts:35:24)

● Edge API endpoints can receive body › reads the body from index

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 500

  48 |     )
  49 |
> 50 |     expect(res.status).toBe(200)
     |                        ^
  51 |     expect(await res.text()).toBe('got: hello, world.')
  52 |   })
  53 | })

  at Object.<anonymous> (e2e/edge-api-endpoints-can-receive-body/index.test.ts:50:24)

test/integration/bigint/test/index.test.js

bigint API route support > dev mode > should return 200
bigint API route support > dev mode > should return the BigInt result text

Expand output

● bigint API route support › dev mode › should return 200

expect(received).toEqual(expected) // deep equality

Expected: 200
Received: 500

  22 |       method: 'GET',
  23 |     })
> 24 |     expect(res.status).toEqual(200)
     |                        ^
  25 |   })
  26 |
  27 |   it('should return the BigInt result text', async () => {

  at Object.<anonymous> (integration/bigint/test/index.test.js:24:24)

● bigint API route support › dev mode › should return the BigInt result text

expect(received).toEqual(expected) // deep equality

Expected: "3"
Received: false

  29 |       method: 'GET',
  30 |     }).then((res) => res.ok && res.text())
> 31 |     expect(resText).toEqual('3')
     |                     ^
  32 |   })
  33 | }
  34 |

  at Object.<anonymous> (integration/bigint/test/index.test.js:31:21)

test/development/acceptance/ReactRefresh.test.ts

ReactRefresh > can edit a component without losing state
ReactRefresh > cyclic dependencies

Expand output

● ReactRefresh › can edit a component without losing state

Application is in inconsistent state: timeout.

  82 |           }
  83 |           if (status !== 'pending') {
> 84 |             throw new Error(`Application is in inconsistent state: ${status}.`)
     |                   ^
  85 |           }
  86 |
  87 |           await new Promise((resolve) => setTimeout(resolve, 30))

  at Object.patch (development/acceptance/helpers.ts:84:19)
  at Object.<anonymous> (development/acceptance/ReactRefresh.test.ts:20:5)

● ReactRefresh › cyclic dependencies

Application is in inconsistent state: timeout.

  82 |           }
  83 |           if (status !== 'pending') {
> 84 |             throw new Error(`Application is in inconsistent state: ${status}.`)
     |                   ^
  85 |           }
  86 |
  87 |           await new Promise((resolve) => setTimeout(resolve, 30))

  at Object.patch (development/acceptance/helpers.ts:84:19)
  at Object.<anonymous> (development/acceptance/ReactRefresh.test.ts:157:5)

test/e2e/app-dir/app-alias/app-alias.test.ts

app-dir alias handling > should handle typescript paths alias correctly
app-dir alias handling > should resolve css imports from outside with src folder presented

Expand output

● app-dir alias handling › should handle typescript paths alias correctly

expect(received).toContain(expected) // indexOf

Expected substring: "click</button>"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  14 |     it('should handle typescript paths alias correctly', async () => {
  15 |       const html = await next.render('/button')
> 16 |       expect(html).toContain('click</button>')
     |                    ^
  17 |     })
  18 |
  19 |     it('should resolve css imports from outside with src folder presented', async () => {

  at Object.<anonymous> (e2e/app-dir/app-alias/app-alias.test.ts:16:20)

● app-dir alias handling › should resolve css imports from outside with src folder presented

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('button')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/integration/404-page-custom-error/test/index.test.js

Default 404 Page with custom _error > dev mode > should respond to 404 correctly
Default 404 Page with custom _error > dev mode > should render error correctly
Default 404 Page with custom _error > dev mode > should render index page normal

Expand output

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

expect(received).toBe(expected) // Object.is equality

Expected: 404
Received: 500

  24 |   it('should respond to 404 correctly', async () => {
  25 |     const res = await fetchViaHTTP(appPort, '/404')
> 26 |     expect(res.status).toBe(404)
     |                        ^
  27 |     expect(await res.text()).toContain('This page could not be found')
  28 |   })
  29 |

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:26:24)

● Default 404 Page with custom _error › dev mode › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "oops"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  30 |   it('should render error correctly', async () => {
  31 |     const text = await renderViaHTTP(appPort, '/err')
> 32 |     expect(text).toContain(isDev ? 'oops' : 'Internal Server Error')
     |                  ^
  33 |   })
  34 |
  35 |   it('should render index page normal', async () => {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:32:18)

● Default 404 Page with custom _error › dev mode › should render index page normal

expect(received).toContain(expected) // indexOf

Expected substring: "hello from index"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  35 |   it('should render index page normal', async () => {
  36 |     const html = await renderViaHTTP(appPort, '/')
> 37 |     expect(html).toContain('hello from index')
     |                  ^
  38 |   })
  39 |
  40 |   if (!isDev) {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:37:18)

test/development/acceptance-app/component-stack.test.ts

Component Stack in error overlay > should show a component stack on hydration error

Expand output

● Component Stack in error overlay › should show a component stack on hydration error

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('[data-nextjs-toast]')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/e2e/edge-api-endpoints-can-receive-body/index.test.ts

Edge API endpoints can receive body > reads the body as text
Edge API endpoints can receive body > reads the body from index

Expand output

● Edge API endpoints can receive body › reads the body as text

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 500

  33 |     )
  34 |
> 35 |     expect(res.status).toBe(200)
     |                        ^
  36 |     expect(await res.text()).toBe('got: hello, world.')
  37 |   })
  38 |

  at Object.<anonymous> (e2e/edge-api-endpoints-can-receive-body/index.test.ts:35:24)

● Edge API endpoints can receive body › reads the body from index

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 500

  48 |     )
  49 |
> 50 |     expect(res.status).toBe(200)
     |                        ^
  51 |     expect(await res.text()).toBe('got: hello, world.')
  52 |   })
  53 | })

  at Object.<anonymous> (e2e/edge-api-endpoints-can-receive-body/index.test.ts:50:24)

test/integration/bigint/test/index.test.js

bigint API route support > dev mode > should return 200
bigint API route support > dev mode > should return the BigInt result text

Expand output

● bigint API route support › dev mode › should return 200

expect(received).toEqual(expected) // deep equality

Expected: 200
Received: 500

  22 |       method: 'GET',
  23 |     })
> 24 |     expect(res.status).toEqual(200)
     |                        ^
  25 |   })
  26 |
  27 |   it('should return the BigInt result text', async () => {

  at Object.<anonymous> (integration/bigint/test/index.test.js:24:24)

● bigint API route support › dev mode › should return the BigInt result text

expect(received).toEqual(expected) // deep equality

Expected: "3"
Received: false

  29 |       method: 'GET',
  30 |     }).then((res) => res.ok && res.text())
> 31 |     expect(resText).toEqual('3')
     |                     ^
  32 |   })
  33 | }
  34 |

  at Object.<anonymous> (integration/bigint/test/index.test.js:31:21)

test/development/acceptance/ReactRefresh.test.ts

ReactRefresh > can edit a component without losing state
ReactRefresh > cyclic dependencies

Expand output

● ReactRefresh › can edit a component without losing state

Application is in inconsistent state: timeout.

  82 |           }
  83 |           if (status !== 'pending') {
> 84 |             throw new Error(`Application is in inconsistent state: ${status}.`)
     |                   ^
  85 |           }
  86 |
  87 |           await new Promise((resolve) => setTimeout(resolve, 30))

  at Object.patch (development/acceptance/helpers.ts:84:19)
  at Object.<anonymous> (development/acceptance/ReactRefresh.test.ts:20:5)

● ReactRefresh › cyclic dependencies

Application is in inconsistent state: timeout.

  82 |           }
  83 |           if (status !== 'pending') {
> 84 |             throw new Error(`Application is in inconsistent state: ${status}.`)
     |                   ^
  85 |           }
  86 |
  87 |           await new Promise((resolve) => setTimeout(resolve, 30))

  at Object.patch (development/acceptance/helpers.ts:84:19)
  at Object.<anonymous> (development/acceptance/ReactRefresh.test.ts:157:5)

test/e2e/app-dir/app-alias/app-alias.test.ts

app-dir alias handling > should handle typescript paths alias correctly
app-dir alias handling > should resolve css imports from outside with src folder presented

Expand output

● app-dir alias handling › should handle typescript paths alias correctly

expect(received).toContain(expected) // indexOf

Expected substring: "click</button>"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  14 |     it('should handle typescript paths alias correctly', async () => {
  15 |       const html = await next.render('/button')
> 16 |       expect(html).toContain('click</button>')
     |                    ^
  17 |     })
  18 |
  19 |     it('should resolve css imports from outside with src folder presented', async () => {

  at Object.<anonymous> (e2e/app-dir/app-alias/app-alias.test.ts:16:20)

● app-dir alias handling › should resolve css imports from outside with src folder presented

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('button')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/integration/404-page-custom-error/test/index.test.js

Default 404 Page with custom _error > dev mode > should respond to 404 correctly
Default 404 Page with custom _error > dev mode > should render error correctly
Default 404 Page with custom _error > dev mode > should render index page normal

Expand output

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

expect(received).toBe(expected) // Object.is equality

Expected: 404
Received: 500

  24 |   it('should respond to 404 correctly', async () => {
  25 |     const res = await fetchViaHTTP(appPort, '/404')
> 26 |     expect(res.status).toBe(404)
     |                        ^
  27 |     expect(await res.text()).toContain('This page could not be found')
  28 |   })
  29 |

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:26:24)

● Default 404 Page with custom _error › dev mode › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "oops"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  30 |   it('should render error correctly', async () => {
  31 |     const text = await renderViaHTTP(appPort, '/err')
> 32 |     expect(text).toContain(isDev ? 'oops' : 'Internal Server Error')
     |                  ^
  33 |   })
  34 |
  35 |   it('should render index page normal', async () => {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:32:18)

● Default 404 Page with custom _error › dev mode › should render index page normal

expect(received).toContain(expected) // indexOf

Expected substring: "hello from index"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  35 |   it('should render index page normal', async () => {
  36 |     const html = await renderViaHTTP(appPort, '/')
> 37 |     expect(html).toContain('hello from index')
     |                  ^
  38 |   })
  39 |
  40 |   if (!isDev) {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:37:18)

github-actions · 2023-01-24T01:27:19Z

Benchmark for `ff4b13a`

Test	Base	PR	%	Significant %
bench_startup/Turbopack RCC/1000 modules	2566.93ms ± 7.81ms	2533.09ms ± 7.69ms	-1.32%	-0.11%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8928.33µs ± 53.15µs	8978.98µs ± 40.29µs	+0.57%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9143.04µs ± 58.32µs	9103.89µs ± 76.70µs	-0.43%
bench_hmr_to_commit/Turbopack RSC/1000 modules	459.80ms ± 1.74ms	462.09ms ± 2.35ms	+0.50%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9009.55µs ± 65.23µs	8945.55µs ± 76.21µs	-0.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7802.15µs ± 53.05µs	7945.59µs ± 65.47µs	+1.84%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8054.15µs ± 95.32µs	8005.20µs ± 77.13µs	-0.61%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8019.41µs ± 62.30µs	7946.09µs ± 62.55µs	-0.91%
bench_hydration/Turbopack RCC/1000 modules	3479.96ms ± 16.29ms	3475.10ms ± 16.15ms	-0.14%
bench_hydration/Turbopack RSC/1000 modules	2979.88ms ± 15.13ms	2985.33ms ± 22.60ms	+0.18%
bench_hydration/Turbopack SSR/1000 modules	2662.96ms ± 9.78ms	2685.51ms ± 9.80ms	+0.85%
bench_startup/Turbopack CSR/1000 modules	1660.36ms ± 14.25ms	1631.20ms ± 7.76ms	-1.76%
bench_startup/Turbopack RCC/1000 modules	2566.93ms ± 7.81ms	2533.09ms ± 7.69ms	-1.32%	-0.11%
bench_startup/Turbopack RSC/1000 modules	2456.22ms ± 9.04ms	2475.55ms ± 8.49ms	+0.79%
bench_startup/Turbopack SSR/1000 modules	2150.33ms ± 3.49ms	2154.92ms ± 10.52ms	+0.21%

github-actions · 2023-01-24T02:41:52Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Rust tests

See workflow summary for details

github-actions · 2023-01-24T03:53:07Z

Benchmark for `78b8c3a`

Test	Base	PR	%	Significant %
bench_startup/Turbopack RCC/1000 modules	2527.48ms ± 22.93ms	2647.15ms ± 24.67ms	+4.73%	+0.95%
bench_startup/Turbopack RSC/1000 modules	2558.70ms ± 12.89ms	2402.70ms ± 10.65ms	-6.10%	-4.30%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8617.21µs ± 70.04µs	8570.02µs ± 71.76µs	-0.55%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9097.80µs ± 70.21µs	9134.57µs ± 48.66µs	+0.40%
bench_hmr_to_commit/Turbopack RSC/1000 modules	454.63ms ± 2.83ms	455.66ms ± 2.96ms	+0.23%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9029.37µs ± 85.52µs	8953.12µs ± 52.63µs	-0.84%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7557.58µs ± 59.55µs	7572.83µs ± 66.86µs	+0.20%
bench_hmr_to_eval/Turbopack RCC/1000 modules	7726.06µs ± 72.14µs	7685.02µs ± 67.59µs	-0.53%
bench_hmr_to_eval/Turbopack SSR/1000 modules	7597.14µs ± 66.64µs	7636.11µs ± 61.21µs	+0.51%
bench_hydration/Turbopack RCC/1000 modules	3352.16ms ± 10.74ms	3364.36ms ± 10.37ms	+0.36%
bench_hydration/Turbopack RSC/1000 modules	2805.48ms ± 7.77ms	2794.13ms ± 4.69ms	-0.40%
bench_hydration/Turbopack SSR/1000 modules	2612.78ms ± 11.64ms	2630.49ms ± 8.09ms	+0.68%
bench_startup/Turbopack CSR/1000 modules	1622.39ms ± 5.54ms	1635.50ms ± 9.26ms	+0.81%
bench_startup/Turbopack RCC/1000 modules	2527.48ms ± 22.93ms	2647.15ms ± 24.67ms	+4.73%	+0.95%
bench_startup/Turbopack RSC/1000 modules	2558.70ms ± 12.89ms	2402.70ms ± 10.65ms	-6.10%	-4.30%
bench_startup/Turbopack SSR/1000 modules	2045.68ms ± 2.65ms	2050.44ms ± 3.47ms	+0.23%

chris-olszewski · 2023-01-24T17:07:53Z

.github/workflows/test.yml

+    name: Go E2E Tests
+    needs: determine_jobs
+    if: needs.determine_jobs.outputs.go == 'true'
+    timeout-minutes: 30


It looks like this might not be enough time to build and run the tests on Windows 😢

it's the same as it is now? https://github.com/vercel/turbo/blob/01e143d80720b532369383e12c60f87368811185/.github/workflows/pr-go-e2e-filtered.yml#L20

.github/workflows/test.yml

github-actions · 2023-01-25T09:58:53Z

Benchmark for `9394c56`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules	474.83ms ± 2.22ms	445.56ms ± 3.14ms	-6.16%	-3.94%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	7988.80µs ± 30.95µs	8060.81µs ± 51.84µs	+0.90%
bench_hmr_to_commit/Turbopack RCC/1000 modules	8560.79µs ± 61.20µs	8528.39µs ± 110.45µs	-0.38%
bench_hmr_to_commit/Turbopack RSC/1000 modules	474.83ms ± 2.22ms	445.56ms ± 3.14ms	-6.16%	-3.94%
bench_hmr_to_commit/Turbopack SSR/1000 modules	8123.97µs ± 69.07µs	8175.53µs ± 51.67µs	+0.63%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7094.69µs ± 50.59µs	7122.23µs ± 59.45µs	+0.39%
bench_hmr_to_eval/Turbopack RCC/1000 modules	7339.45µs ± 56.80µs	7263.46µs ± 73.22µs	-1.04%
bench_hmr_to_eval/Turbopack SSR/1000 modules	7182.45µs ± 56.91µs	7142.03µs ± 30.65µs	-0.56%
bench_hydration/Turbopack RCC/1000 modules	3268.40ms ± 14.35ms	3254.01ms ± 6.54ms	-0.44%
bench_hydration/Turbopack RSC/1000 modules	2710.90ms ± 9.17ms	2722.16ms ± 8.84ms	+0.42%
bench_hydration/Turbopack SSR/1000 modules	2549.50ms ± 9.13ms	2535.50ms ± 11.17ms	-0.55%
bench_startup/Turbopack CSR/1000 modules	1597.91ms ± 3.15ms	1594.12ms ± 7.34ms	-0.24%
bench_startup/Turbopack RCC/1000 modules	2117.39ms ± 3.52ms	2115.58ms ± 6.02ms	-0.09%
bench_startup/Turbopack RSC/1000 modules	2023.96ms ± 4.92ms	2016.24ms ± 7.56ms	-0.38%
bench_startup/Turbopack SSR/1000 modules	1721.54ms ± 5.20ms	1707.40ms ± 4.60ms	-0.82%

github-actions · 2023-01-27T10:36:15Z

Benchmark for `0f96e1d`

Test	Base	PR	%	Significant %
bench_startup/Turbopack RCC/1000 modules	2344.98ms ± 8.53ms	2396.60ms ± 8.20ms	+2.20%	+0.77%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9005.87µs ± 108.64µs	8900.87µs ± 70.94µs	-1.17%
bench_hmr_to_commit/Turbopack RCC/1000 modules	8838.79µs ± 67.22µs	9047.92µs ± 58.59µs	+2.37%
bench_hmr_to_commit/Turbopack RSC/1000 modules	460.10ms ± 2.35ms	465.04ms ± 2.66ms	+1.07%
bench_hmr_to_commit/Turbopack SSR/1000 modules	8905.13µs ± 100.02µs	8803.91µs ± 108.62µs	-1.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7674.63µs ± 229.93µs	7863.45µs ± 78.55µs	+2.46%
bench_hmr_to_eval/Turbopack RCC/1000 modules	7908.70µs ± 42.43µs	7787.58µs ± 63.78µs	-1.53%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8084.53µs ± 115.86µs	7932.26µs ± 138.22µs	-1.88%
bench_hydration/Turbopack RCC/1000 modules	3588.55ms ± 12.47ms	3585.52ms ± 17.33ms	-0.08%
bench_hydration/Turbopack RSC/1000 modules	3150.59ms ± 12.52ms	3191.93ms ± 11.42ms	+1.31%
bench_hydration/Turbopack SSR/1000 modules	3013.98ms ± 18.52ms	2973.33ms ± 13.49ms	-1.35%
bench_startup/Turbopack CSR/1000 modules	2041.53ms ± 12.69ms	2003.69ms ± 8.28ms	-1.85%
bench_startup/Turbopack RCC/1000 modules	2344.98ms ± 8.53ms	2396.60ms ± 8.20ms	+2.20%	+0.77%
bench_startup/Turbopack RSC/1000 modules	2276.70ms ± 7.18ms	2269.75ms ± 7.92ms	-0.31%
bench_startup/Turbopack SSR/1000 modules	1942.35ms ± 5.78ms	1953.55ms ± 5.30ms	+0.58%

tknickman · 2023-01-27T19:31:40Z

You'll need to mark these as required as well (like here): #3519

mehulkar · 2023-01-27T19:37:27Z

@tknickman done

The base branch was changed.

NicholasLYang · 2023-01-27T22:13:49Z

.github/workflows/test.yml

+        uses: technote-space/get-diff-action@v6
+        with:
+          PATTERNS: |
+            shim/**


shim is no longer needed. We should probably add turbo-updater too

removing shim, but can we rename turbo-updater to turborepo-updater instead? Why the naming inconsistency?

github-actions · 2023-01-27T23:52:32Z

Benchmark for `f7222aa`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack RCC/1000 modules	10.00ms ± 0.05ms	9415.52µs ± 123.44µs	-5.89%	-2.39%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9078.14µs ± 85.61µs	8860.01µs ± 71.68µs	-2.40%
bench_hmr_to_commit/Turbopack RCC/1000 modules	10.00ms ± 0.05ms	9415.52µs ± 123.44µs	-5.89%	-2.39%
bench_hmr_to_commit/Turbopack RSC/1000 modules	475.26ms ± 2.62ms	476.61ms ± 2.79ms	+0.28%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9154.56µs ± 70.42µs	9158.76µs ± 55.63µs	+0.05%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7922.09µs ± 44.91µs	7959.28µs ± 78.98µs	+0.47%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8235.95µs ± 77.10µs	8067.47µs ± 94.16µs	-2.05%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8155.56µs ± 64.04µs	8180.81µs ± 52.22µs	+0.31%
bench_hydration/Turbopack RCC/1000 modules	3713.11ms ± 9.92ms	3737.52ms ± 9.37ms	+0.66%
bench_hydration/Turbopack RSC/1000 modules	3256.81ms ± 8.58ms	3255.24ms ± 11.03ms	-0.05%
bench_hydration/Turbopack SSR/1000 modules	3070.48ms ± 10.86ms	3113.06ms ± 10.91ms	+1.39%
bench_startup/Turbopack CSR/1000 modules	2056.70ms ± 10.07ms	2056.71ms ± 8.95ms	+0.00%
bench_startup/Turbopack RCC/1000 modules	2515.45ms ± 17.86ms	2479.10ms ± 5.44ms	-1.44%
bench_startup/Turbopack RSC/1000 modules	2369.40ms ± 5.96ms	2372.21ms ± 4.80ms	+0.12%
bench_startup/Turbopack SSR/1000 modules	2017.68ms ± 3.74ms	2007.29ms ± 3.11ms	-0.52%

mehulkar · 2023-01-28T02:33:52Z

Merging this. Rust tests failed, but @jridgewell confirmed that they're failing at the moment. All other checks are green

github-actions bot added the area: ci label Jan 24, 2023

vercel bot deployed to Preview – turbo-site January 24, 2023 00:27 View deployment

mehulkar marked this pull request as ready for review January 24, 2023 01:39

mehulkar requested review from a team as code owners January 24, 2023 01:39

mehulkar requested review from chris-olszewski and NicholasLYang January 24, 2023 01:39

vercel bot deployed to Preview – examples-vite-web January 24, 2023 02:50 View deployment

vercel bot deployed to Preview – examples-tailwind-web January 24, 2023 02:50 View deployment

vercel bot deployed to Preview – examples-basic-web January 24, 2023 02:50 View deployment

vercel bot deployed to Preview – examples-native-web January 24, 2023 02:50 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog January 24, 2023 02:50 View deployment

vercel bot deployed to Preview – examples-svelte-web January 24, 2023 02:50 View deployment

vercel bot deployed to Preview – examples-designsystem-docs January 24, 2023 02:50 View deployment

vercel bot deployed to Preview – examples-nonmonorepo January 24, 2023 02:50 View deployment

vercel bot deployed to Preview – examples-cra-web January 24, 2023 02:50 View deployment

chris-olszewski previously approved these changes Jan 24, 2023

View reviewed changes

chris-olszewski reviewed Jan 24, 2023

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

mehulkar force-pushed the mehulkar/turbo-562-move-turborepo-e2e-tests-to-testyml branch from 2b6dc14 to 6771812 Compare January 25, 2023 08:53

vercel bot deployed to Preview – turbo-site January 25, 2023 08:54 View deployment

mehulkar requested a review from chris-olszewski January 25, 2023 08:57

mehulkar mentioned this pull request Jan 27, 2023

fix(shim): better error message for missing go bin #3498

Merged

mehulkar force-pushed the mehulkar/turbo-562-move-turborepo-e2e-tests-to-testyml branch from 4dfef5b to 602c98e Compare January 27, 2023 09:35

mehulkar requested a review from tknickman January 27, 2023 09:35

vercel bot deployed to Preview – turbo-site January 27, 2023 09:36 View deployment

tknickman mentioned this pull request Jan 27, 2023

fix(ci): require go integration #3519

Merged

mehulkar force-pushed the mehulkar/turbo-562-move-turborepo-e2e-tests-to-testyml branch from 3831040 to 2066e5f Compare January 27, 2023 20:48

github-actions bot added the area: turborepo label Jan 27, 2023

mehulkar changed the base branch from main to mk/fix-tests January 27, 2023 20:49

mehulkar mentioned this pull request Jan 27, 2023

Fix integration tests #3520

Merged

Base automatically changed from mk/fix-tests to main January 27, 2023 21:17

mehulkar added 2 commits January 27, 2023 13:39

Move E2E tests to main test.yml workflow

2622b93

Fail build if E2e tests fail

4979f8d

mehulkar force-pushed the mehulkar/turbo-562-move-turborepo-e2e-tests-to-testyml branch from 2066e5f to 4979f8d Compare January 27, 2023 21:39

chris-olszewski approved these changes Jan 27, 2023

View reviewed changes

mehulkar enabled auto-merge (squash) January 27, 2023 22:03

NicholasLYang reviewed Jan 27, 2023

View reviewed changes

include updater and rm shim

1f738cc

mehulkar disabled auto-merge January 28, 2023 02:33

mehulkar merged commit 5a82b03 into main Jan 28, 2023

mehulkar deleted the mehulkar/turbo-562-move-turborepo-e2e-tests-to-testyml branch January 28, 2023 02:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move E2E tests to main test.yml workflow #3442

Move E2E tests to main test.yml workflow #3442

mehulkar commented Jan 24, 2023

vercel bot commented Jan 24, 2023 •

edited

Loading

github-actions bot commented Jan 24, 2023 •

edited

Loading

github-actions bot commented Jan 24, 2023

github-actions bot commented Jan 24, 2023 •

edited

Loading

github-actions bot commented Jan 24, 2023

chris-olszewski Jan 24, 2023

mehulkar Jan 24, 2023

github-actions bot commented Jan 25, 2023

github-actions bot commented Jan 27, 2023

tknickman commented Jan 27, 2023

mehulkar commented Jan 27, 2023

NicholasLYang Jan 27, 2023

mehulkar Jan 27, 2023

github-actions bot commented Jan 27, 2023

mehulkar commented Jan 28, 2023

Move E2E tests to main test.yml workflow #3442

Move E2E tests to main test.yml workflow #3442

Conversation

mehulkar commented Jan 24, 2023

vercel bot commented Jan 24, 2023 • edited Loading

github-actions bot commented Jan 24, 2023 • edited Loading

Failing next.js integration test suites

github-actions bot commented Jan 24, 2023

Benchmark for ff4b13a

github-actions bot commented Jan 24, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Jan 24, 2023

Benchmark for 78b8c3a

chris-olszewski Jan 24, 2023

Choose a reason for hiding this comment

mehulkar Jan 24, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 25, 2023

Benchmark for 9394c56

github-actions bot commented Jan 27, 2023

Benchmark for 0f96e1d

tknickman commented Jan 27, 2023

mehulkar commented Jan 27, 2023

NicholasLYang Jan 27, 2023

Choose a reason for hiding this comment

mehulkar Jan 27, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 27, 2023

Benchmark for f7222aa

mehulkar commented Jan 28, 2023

vercel bot commented Jan 24, 2023 •

edited

Loading

github-actions bot commented Jan 24, 2023 •

edited

Loading

Benchmark for `ff4b13a`

github-actions bot commented Jan 24, 2023 •

edited

Loading

Benchmark for `78b8c3a`

Benchmark for `9394c56`

Benchmark for `0f96e1d`

Benchmark for `f7222aa`