Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make library code less verbose in stack traces #4706

Merged
merged 2 commits into from
Apr 26, 2023
Merged

make library code less verbose in stack traces #4706

merged 2 commits into from
Apr 26, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 26, 2023

Description

avoid highlighting library code in stack traces and show no source frame for them

@vercel
Copy link

vercel bot commented Apr 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Apr 26, 2023 1:21pm
examples-gatsby-web 🔄 Building (Inspect) Apr 26, 2023 1:21pm
examples-svelte-web 🔄 Building (Inspect) Apr 26, 2023 1:21pm
examples-tailwind-web 🔄 Building (Inspect) Apr 26, 2023 1:21pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 26, 2023 1:21pm
examples-cra-web ⬜️ Ignored (Inspect) Apr 26, 2023 1:21pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 26, 2023 1:21pm
examples-native-web ⬜️ Ignored (Inspect) Apr 26, 2023 1:21pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 26, 2023 1:21pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 26, 2023 1:21pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2023 1:21pm

@github-actions
Copy link
Contributor

This change may fail to build next-swc.

info: syncing channel updates for 'nightly-2023-03-09-x86_64-unknown-linux-gnu'
info: latest update on 2023-03-09, rust version 1.70.0-nightly (900c35403 2023-03-08)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
packages/next-swc/crates/next-core/src/next_config.rs:33:30: error[E0432]: unresolved import `turbo_binding::turbopack::turbopack::module_options::EmotionTransformConfig`
packages/next-swc/crates/next-core/src/next_shared/transforms.rs:22:13: error[E0432]: unresolved import `turbo_binding::turbopack::ecmascript::CustomTransformVc`
packages/next-swc/crates/next-core/src/transform_options.rs:10:65: error[E0432]: unresolved imports `turbo_binding::turbopack::turbopack::module_options::EmotionTransformConfig`, `turbo_binding::turbopack::turbopack::module_options::EmotionTransformConfigVc`, `turbo_binding::turbopack::turbopack::module_options::OptionEmotionTransformConfigVc`
packages/next-swc/crates/next-core/src/next_shared/transforms.rs:41:35: error[E0599]: no variant or associated item named `Custom` found for enum `EcmascriptInputTransform` in the current scope
packages/next-swc/crates/next-core/src/next_shared/transforms.rs:113:35: error[E0599]: no variant or associated item named `Custom` found for enum `EcmascriptInputTransform` in the current scope
packages/next-swc/crates/next-core/src/next_shared/transforms.rs:162:35: error[E0599]: no variant or associated item named `Custom` found for enum `EcmascriptInputTransform` in the current scope
packages/next-swc/crates/next-core/src/next_shared/transforms.rs:232:49: error[E0599]: no variant or associated item named `Custom` found for enum `EcmascriptInputTransform` in the current scope
error: could not compile `next-core` (lib) due to 7 previous errors

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@sokra sokra marked this pull request as ready for review April 26, 2023 09:20
@sokra sokra requested a review from a team as a code owner April 26, 2023 09:20
@sokra sokra merged commit 61ce058 into main Apr 26, 2023
@sokra sokra deleted the sokra/stack-trace-verbosity branch April 26, 2023 14:08
@sokra sokra mentioned this pull request Apr 26, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Apr 26, 2023
@sokra
update turbopack (#48893)
219d1d4 
### What?

* vercel/turborepo#4700 <!-- Tobias Koppers - update
deps -->
* vercel/turborepo#4706 <!-- Tobias Koppers - make
library code less verbose in stack traces -->
* vercel/turborepo#4705 <!-- Tobias Koppers -
improve error handling in update stream -->
* vercel/turborepo#4667 <!-- Caleb Webber - remove
box_syntax -->
* vercel/turborepo#4714 <!-- Tobias Koppers - chunk
hash need to include availability root -->
* vercel/turborepo#4709 <!-- Alex Kirszenberg -
Allow the dev server socket to be reused immediately -->
* vercel/turborepo#4716 <!-- Tobias Koppers - errors
lead to consistent exit code in issue detail -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
make library code less verbose in stack traces (vercel/turborepo#4706)
1d8ec72 
### Description

avoid highlighting library code in stack traces and show no source frame
for them
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
make library code less verbose in stack traces (vercel/turborepo#4706)
44c090b 
### Description

avoid highlighting library code in stack traces and show no source frame
for them
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
make library code less verbose in stack traces (vercel/turborepo#4706)
e56edd9 
### Description

avoid highlighting library code in stack traces and show no source frame
for them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @alexkirsz