errors lead to consistent exit code in issue detail #4716
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
jridgewell
approved these changes
Apr 26, 2023
huozhi
approved these changes
Apr 26, 2023
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Apr 26, 2023
### What? * vercel/turborepo#4700 <!-- Tobias Koppers - update deps --> * vercel/turborepo#4706 <!-- Tobias Koppers - make library code less verbose in stack traces --> * vercel/turborepo#4705 <!-- Tobias Koppers - improve error handling in update stream --> * vercel/turborepo#4667 <!-- Caleb Webber - remove box_syntax --> * vercel/turborepo#4714 <!-- Tobias Koppers - chunk hash need to include availability root --> * vercel/turborepo#4709 <!-- Alex Kirszenberg - Allow the dev server socket to be reused immediately --> * vercel/turborepo#4716 <!-- Tobias Koppers - errors lead to consistent exit code in issue detail -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…#4716) ### Description issue snapshots are flaky due to alternating issue detail with exist code or not. It's a race condition between process exit after sending error and process killing after receiving error.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…#4716) ### Description issue snapshots are flaky due to alternating issue detail with exist code or not. It's a race condition between process exit after sending error and process killing after receiving error.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…#4716) ### Description issue snapshots are flaky due to alternating issue detail with exist code or not. It's a race condition between process exit after sending error and process killing after receiving error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue snapshots are flaky due to alternating issue detail with exist code or not.
It's a race condition between process exit after sending error and process killing after receiving error.