WEB-1253: turbopack-cli: implement turbopack build
#5488
Merged
+336
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work prepares for `turbopack build` by extracting code common between dev and build, such as asset context. This also makes the cli accept a variadic list of entries rather than an unnamed directory parameter. The project directory is now available under `--dir` or `-d`. Test Plan: `cargo run -p turbopack-cli dev` with a `src/index.js` present and `cargo run -p turbopack-cli dev src/entry.js` with `src/entry.js` present.
Depends on #5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
Logs
See job summary for details |
|
… wbinnssmith/turbopack-cli-build
…i' into wbinnssmith/turbopack-cli-build
…rize-cli' into wbinnssmith/turbopack-cli-build
Linux Benchmark for 042dee2Click to view benchmark
|
jridgewell
approved these changes
Jul 12, 2023
| })) | ||
| .into(); | ||
|
|
||
| handle_issues(build_result, issue_reporter, &None, &None).await?; |
There was a problem hiding this comment.
Should we fail the build process if there are issues?
sokra
approved these changes
Jul 12, 2023
Comment on lines
283
to
289
| for chunk_group in entry_chunk_groups { | ||
| for entry in &*chunk_group.await? { | ||
| for asset in &*all_assets_from_entry(entry.to_owned()).await? { | ||
| asset.content().write(asset.ident().path()).await?; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
That's pretty inefficient since it's generating and writing all assets sequentially. You could generate and write them all in parallel.
Linux Benchmark for ac46a9cClick to view benchmark
|
…rbopack-cli-build
Linux Benchmark for 7da4e02Click to view benchmark
|
MacOS Benchmark for 7da4e02
Click to view full benchmark
|
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 21, 2023
* vercel/turborepo#5567 <!-- Alex Kirszenberg - Remove unnecessary ValueDebugFormat item, hide Vc field --> * vercel/turborepo#5576 <!-- Alex Kirszenberg - Extract shared HMR utils to their own modules/crates --> * vercel/turborepo#5503 <!-- OJ Kwon - feat(turbopack_core): define trait for diagnostics --> * vercel/turborepo#5487 <!-- Will Binns-Smith - turbopack-cli: modularize code to support turbopack build --> * vercel/turborepo#5488 <!-- Will Binns-Smith - turbopack-cli: implement `turbopack build` --> * vercel/turborepo#5450 <!-- Leah - feat: async modules / top level await --> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
wbinnssmith
changed the title
turbopack buildturbopack build
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
Depends on vercel/turborepo#5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Depends on vercel/turborepo#5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Depends on vercel/turborepo#5487 This implements a basic version of `turbopack build`, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node. Test Plan: `cargo run -p turbopack-cli build` with a `src/index.js` present and `cargo run -p turbopack-cli build src/entry.js` with `src/entry.js` present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5487
This implements a basic version of
turbopack build, only targeting browser targets. In the future, we could accept a cli or configuration option to target Node.Test Plan:
cargo run -p turbopack-cli buildwith asrc/index.jspresent andcargo run -p turbopack-cli build src/entry.jswithsrc/entry.jspresent.