feat(turbopack_core): define trait for diagnostics #5503

kwonoj · 2023-07-12T16:53:04Z

Description

Extracting trait definition from vercel/next.js#52356, renamed it for more generic usage that turbopack can emit any kind of arbitary metadata, but next-swc can use it as telemetry for its subset.

vercel · 2023-07-12T16:53:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 20, 2023 5:46pm

10 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 20, 2023 5:46pm

github-actions · 2023-07-12T16:57:20Z

✅ This change can build next-swc

github-actions · 2023-07-12T17:03:46Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-07-12T17:10:35Z

Linux Benchmark for `41d5034`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5401.17µs ± 24.10µs	5369.72µs ± 15.76µs	-0.58%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5010.49µs ± 26.02µs	5152.49µs ± 106.47µs	+2.83%
bench_startup/Turbopack CSR/1000 modules	805.97ms ± 1.12ms	810.98ms ± 4.70ms	+0.62%

github-actions · 2023-07-12T17:45:24Z

MacOS Benchmark for `41d5034`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	24.05ms ± 0.69ms	26.77ms ± 0.22ms	+11.30%	+3.53%
bench_startup/Turbopack CSR/1000 modules	8684.90ms ± 776.61ms	3656.05ms ± 81.14ms	-57.90%	-46.46%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.32ms ± 0.07ms	27.33ms ± 0.14ms	+0.02%
bench_hmr_to_eval/Turbopack CSR/1000 modules	24.05ms ± 0.69ms	26.77ms ± 0.22ms	+11.30%	+3.53%
bench_startup/Turbopack CSR/1000 modules	8684.90ms ± 776.61ms	3656.05ms ± 81.14ms	-57.90%	-46.46%

github-actions · 2023-07-17T17:06:36Z

Linux Benchmark for `3bd8e5d`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5362.64µs ± 35.16µs	5336.97µs ± 34.26µs	-0.48%
bench_hmr_to_eval/Turbopack CSR/1000 modules	4993.46µs ± 21.27µs	5374.44µs ± 419.15µs	+7.63%
bench_startup/Turbopack CSR/1000 modules	793.80ms ± 2.34ms	799.81ms ± 5.10ms	+0.76%

github-actions · 2023-07-17T17:34:39Z

MacOS Benchmark for `3bd8e5d`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	5583.76ms ± 795.46ms	3205.98ms ± 60.45ms	-42.58%	-16.68%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.70ms ± 0.10ms	26.50ms ± 0.81ms	-4.32%
bench_hmr_to_eval/Turbopack CSR/1000 modules	24.83ms ± 1.16ms	31.56ms ± 4.27ms	+27.09%
bench_startup/Turbopack CSR/1000 modules	5583.76ms ± 795.46ms	3205.98ms ± 60.45ms	-42.58%	-16.68%

crates/turbopack-core/src/diagnostics/mod.rs

github-actions · 2023-07-17T20:41:56Z

Linux Benchmark for `5b0bf11`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5363.07µs ± 21.09µs	5381.32µs ± 27.92µs	+0.34%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5037.77µs ± 27.34µs	5014.65µs ± 27.76µs	-0.46%
bench_startup/Turbopack CSR/1000 modules	805.72ms ± 1.13ms	804.69ms ± 1.92ms	-0.13%

github-actions · 2023-07-17T21:08:43Z

MacOS Benchmark for `5b0bf11`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	3666.98ms ± 303.48ms	7241.53ms ± 1123.14ms	+97.48%	+16.88%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.12ms ± 0.08ms	27.44ms ± 0.24ms	+1.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules	25.90ms ± 1.02ms	26.10ms ± 1.03ms	+0.79%
bench_startup/Turbopack CSR/1000 modules	3666.98ms ± 303.48ms	7241.53ms ± 1123.14ms	+97.48%	+16.88%

github-actions · 2023-07-17T21:20:59Z

Windows Benchmark for `5b0bf11`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	15.82ms ± 0.05ms	15.56ms ± 0.01ms	-1.64%	-0.81%
bench_startup/Turbopack CSR/1000 modules	3706.68ms ± 8.34ms	3813.86ms ± 43.59ms	+2.89%	+0.09%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	15.82ms ± 0.05ms	15.56ms ± 0.01ms	-1.64%	-0.81%
bench_hmr_to_eval/Turbopack CSR/1000 modules	15.69ms ± 0.03ms	15.71ms ± 0.05ms	+0.14%
bench_startup/Turbopack CSR/1000 modules	3706.68ms ± 8.34ms	3813.86ms ± 43.59ms	+2.89%	+0.09%

github-actions · 2023-07-18T16:10:12Z

Linux Benchmark for `ecf2e2d`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5416.61µs ± 27.23µs	5388.09µs ± 23.08µs	-0.53%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5026.16µs ± 37.24µs	5156.68µs ± 126.36µs	+2.60%
bench_startup/Turbopack CSR/1000 modules	809.79ms ± 0.75ms	809.39ms ± 1.70ms	-0.05%

github-actions · 2023-07-18T18:20:36Z

Linux Benchmark for 59140b8

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5373.35µs ± 32.86µs	5414.72µs ± 25.09µs	+0.77%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5084.90µs ± 31.00µs	5421.95µs ± 341.35µs	+6.63%
bench_startup/Turbopack CSR/1000 modules	805.72ms ± 1.36ms	808.47ms ± 3.63ms	+0.34%

github-actions · 2023-07-18T18:52:03Z

MacOS Benchmark for 59140b8

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	4553.44ms ± 630.39ms	3147.30ms ± 64.12ms	-30.88%	-0.52%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.77ms ± 0.10ms	28.10ms ± 0.07ms	+1.20%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.95ms ± 0.33ms	34.88ms ± 5.55ms	+29.42%
bench_startup/Turbopack CSR/1000 modules	4553.44ms ± 630.39ms	3147.30ms ± 64.12ms	-30.88%	-0.52%

github-actions · 2023-07-18T21:43:53Z

Linux Benchmark for `1f66ed7`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5712.30µs ± 23.95µs	5720.04µs ± 62.52µs	+0.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5373.10µs ± 99.88µs	5421.93µs ± 158.08µs	+0.91%
bench_startup/Turbopack CSR/1000 modules	817.15ms ± 1.12ms	819.19ms ± 2.98ms	+0.25%

github-actions · 2023-07-18T22:11:11Z

MacOS Benchmark for `1f66ed7`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.05ms ± 0.17ms	26.62ms ± 0.10ms	+2.22%	+0.18%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.75ms ± 0.08ms	27.30ms ± 0.19ms	-1.62%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.05ms ± 0.17ms	26.62ms ± 0.10ms	+2.22%	+0.18%
bench_startup/Turbopack CSR/1000 modules	6610.81ms ± 877.03ms	5291.03ms ± 933.10ms	-19.96%

github-actions · 2023-07-19T16:24:03Z

Linux Benchmark for `f98426c`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5470.15µs ± 23.04µs	5436.12µs ± 19.50µs	-0.62%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5111.42µs ± 21.17µs	5282.20µs ± 207.02µs	+3.34%
bench_startup/Turbopack CSR/1000 modules	811.50ms ± 1.25ms	818.27ms ± 3.75ms	+0.83%

github-actions · 2023-07-19T16:54:26Z

MacOS Benchmark for `f98426c`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.57ms ± 0.06ms	26.96ms ± 0.17ms	-2.21%	-0.52%
bench_hmr_to_eval/Turbopack CSR/1000 modules	25.58ms ± 0.47ms	56.95ms ± 3.07ms	+122.62%	+91.55%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.57ms ± 0.06ms	26.96ms ± 0.17ms	-2.21%	-0.52%
bench_hmr_to_eval/Turbopack CSR/1000 modules	25.58ms ± 0.47ms	56.95ms ± 3.07ms	+122.62%	+91.55%
bench_startup/Turbopack CSR/1000 modules	3103.45ms ± 47.91ms	2994.48ms ± 103.67ms	-3.51%

github-actions · 2023-07-20T18:03:05Z

Linux Benchmark for `b928e8f`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	6735.96µs ± 78.73µs	7232.74µs ± 145.05µs	+7.38%	+0.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules	6265.78µs ± 81.68µs	6944.82µs ± 217.88µs	+10.84%	+1.24%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	6735.96µs ± 78.73µs	7232.74µs ± 145.05µs	+7.38%	+0.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules	6265.78µs ± 81.68µs	6944.82µs ± 217.88µs	+10.84%	+1.24%
bench_startup/Turbopack CSR/1000 modules	833.05ms ± 2.25ms	835.07ms ± 5.05ms	+0.24%

github-actions · 2023-07-20T18:33:03Z

MacOS Benchmark for `b928e8f`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	9399.44ms ± 1903.59ms	3328.14ms ± 53.54ms	-64.59%	-38.57%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.56ms ± 0.18ms	27.82ms ± 0.13ms	+0.95%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.85ms ± 0.09ms	26.15ms ± 0.42ms	-2.59%
bench_startup/Turbopack CSR/1000 modules	9399.44ms ± 1903.59ms	3328.14ms ± 53.54ms	-64.59%	-38.57%

* vercel/turborepo#5567  * vercel/turborepo#5576  * vercel/turborepo#5503  * vercel/turborepo#5487  * vercel/turborepo#5488  * vercel/turborepo#5450  --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

…5503) ### Description Extracting trait definition from #52356, renamed it for more generic usage that turbopack can emit any kind of arbitary metadata, but next-swc can use it as telemetry for its subset.

kwonoj requested a review from a team as a code owner July 12, 2023 16:53

turbo-orchestrator bot added the team: turbopack label Jul 12, 2023

vercel bot deployed to Preview – turbo-site July 12, 2023 16:53 View deployment

kwonoj force-pushed the feat-diag-type branch from c6d357a to 2dc2224 Compare July 17, 2023 16:49

vercel bot deployed to Preview – turbo-site July 17, 2023 16:50 View deployment

jridgewell reviewed Jul 17, 2023

View reviewed changes

crates/turbopack-core/src/diagnostics/mod.rs Outdated Show resolved Hide resolved

crates/turbopack-core/src/diagnostics/mod.rs Outdated Show resolved Hide resolved

kwonoj force-pushed the feat-diag-type branch from 2dc2224 to d116f26 Compare July 17, 2023 19:55

vercel bot deployed to Preview – turbo-site July 17, 2023 19:56 View deployment

kwonoj force-pushed the feat-diag-type branch from d116f26 to 0f37b20 Compare July 17, 2023 20:05

vercel bot deployed to Preview – turbo-site July 17, 2023 20:06 View deployment

kwonoj force-pushed the feat-diag-type branch 2 times, most recently from 4ab2ad7 to 4f0984f Compare July 17, 2023 20:11

vercel bot deployed to Preview – turbo-site July 17, 2023 20:13 View deployment

kwonoj force-pushed the feat-diag-type branch from 4f0984f to f9a3812 Compare July 17, 2023 20:24

vercel bot deployed to Preview – turbo-site July 17, 2023 20:25 View deployment

kwonoj force-pushed the feat-diag-type branch from f9a3812 to d5c41fd Compare July 18, 2023 15:53

vercel bot deployed to Preview – turbo-site July 18, 2023 15:53 View deployment

kwonoj force-pushed the feat-diag-type branch from d5c41fd to 33bd910 Compare July 18, 2023 16:34

vercel bot deployed to Preview – turbo-site July 18, 2023 16:35 View deployment

kwonoj force-pushed the feat-diag-type branch from 33bd910 to 00a139b Compare July 18, 2023 18:04

vercel bot deployed to Preview – turbo-site July 18, 2023 18:05 View deployment

kwonoj force-pushed the feat-diag-type branch from 00a139b to 354ae39 Compare July 18, 2023 21:27

vercel bot deployed to Preview – turbo-site July 18, 2023 21:28 View deployment

kwonoj force-pushed the feat-diag-type branch from 354ae39 to db9aa82 Compare July 19, 2023 16:07

vercel bot deployed to Preview – turbo-site July 19, 2023 16:08 View deployment

jridgewell approved these changes Jul 20, 2023

View reviewed changes

feat(turbopack_core): define trait for diagnostics

b247465

kwonoj force-pushed the feat-diag-type branch from db9aa82 to b247465 Compare July 20, 2023 17:45

vercel bot deployed to Preview – turbo-site July 20, 2023 17:46 View deployment

kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Jul 20, 2023

kodiakhq bot merged commit 930fc4a into main Jul 20, 2023

kodiakhq bot deleted the feat-diag-type branch July 20, 2023 19:03

sokra mentioned this pull request Jul 21, 2023

update Turbopack vercel/next.js#52986

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(turbopack_core): define trait for diagnostics #5503

feat(turbopack_core): define trait for diagnostics #5503

kwonoj commented Jul 12, 2023

vercel bot commented Jul 12, 2023 •

edited

Loading

github-actions bot commented Jul 12, 2023 •

edited

Loading

github-actions bot commented Jul 12, 2023 •

edited

Loading

github-actions bot commented Jul 12, 2023

github-actions bot commented Jul 12, 2023

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 20, 2023

github-actions bot commented Jul 20, 2023

feat(turbopack_core): define trait for diagnostics #5503

feat(turbopack_core): define trait for diagnostics #5503

Conversation

kwonoj commented Jul 12, 2023

Description

vercel bot commented Jul 12, 2023 • edited Loading

github-actions bot commented Jul 12, 2023 • edited Loading

github-actions bot commented Jul 12, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Jul 12, 2023

Linux Benchmark for 41d5034

github-actions bot commented Jul 12, 2023

MacOS Benchmark for 41d5034

github-actions bot commented Jul 17, 2023

Linux Benchmark for 3bd8e5d

github-actions bot commented Jul 17, 2023

MacOS Benchmark for 3bd8e5d

github-actions bot commented Jul 17, 2023

Linux Benchmark for 5b0bf11

github-actions bot commented Jul 17, 2023

MacOS Benchmark for 5b0bf11

github-actions bot commented Jul 17, 2023

Windows Benchmark for 5b0bf11

github-actions bot commented Jul 18, 2023

Linux Benchmark for ecf2e2d

github-actions bot commented Jul 18, 2023

Linux Benchmark for 59140b8

github-actions bot commented Jul 18, 2023

MacOS Benchmark for 59140b8

github-actions bot commented Jul 18, 2023

Linux Benchmark for 1f66ed7

github-actions bot commented Jul 18, 2023

MacOS Benchmark for 1f66ed7

github-actions bot commented Jul 19, 2023

Linux Benchmark for f98426c

github-actions bot commented Jul 19, 2023

MacOS Benchmark for f98426c

github-actions bot commented Jul 20, 2023

Linux Benchmark for b928e8f

github-actions bot commented Jul 20, 2023

MacOS Benchmark for b928e8f

vercel bot commented Jul 12, 2023 •

edited

Loading

github-actions bot commented Jul 12, 2023 •

edited

Loading

github-actions bot commented Jul 12, 2023 •

edited

Loading

Linux Benchmark for `41d5034`

MacOS Benchmark for `41d5034`

Linux Benchmark for `3bd8e5d`

MacOS Benchmark for `3bd8e5d`

Linux Benchmark for `5b0bf11`

MacOS Benchmark for `5b0bf11`

Windows Benchmark for `5b0bf11`

Linux Benchmark for `ecf2e2d`

Linux Benchmark for `1f66ed7`

MacOS Benchmark for `1f66ed7`

Linux Benchmark for `f98426c`

MacOS Benchmark for `f98426c`

Linux Benchmark for `b928e8f`

MacOS Benchmark for `b928e8f`