trace memory allocations and show in tracing #6866
Merged
+458
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
kwonoj
reviewed
Jan 10, 2024
| @@ -13,16 +13,37 @@ const TARGET_BUFFER: usize = 100 * KB; | |||
| /// global counter. | |||
| const MAX_BUFFER: usize = 200 * KB; | |||
|
|
|||
| #[derive(Default)] | |||
| pub struct AllocationInfo { | |||
| pub allocations: usize, | |||
There was a problem hiding this comment.
is usize enough to not overflow?
There was a problem hiding this comment.
Yep, 16 exabytes should be enough
kwonoj
approved these changes
Jan 10, 2024
chris-olszewski
added a commit
that referenced
this pull request
Jan 11, 2024
### Description Update `Cargo.lock` to match changes made to `Cargo.toml` in #6866 ### Testing Instructions 👀 Closes TURBO-2032
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jan 17, 2024
### What? api changes for vercel/turborepo#6988 ### Turbopack Changes * vercel/turborepo#6886 <!-- Tobias Koppers - improve nesting of tracing for invalidations --> * vercel/turborepo#6866 <!-- Tobias Koppers - trace memory allocations and show in tracing --> * vercel/turborepo#6988 <!-- Tobias Koppers - allow to pass available chunk items when creating a chunk group --> * vercel/turborepo#7013 <!-- Leah - fix: make CSS reloading work on firefox --> * vercel/turborepo#7004 <!-- Tobias Koppers - improve error message when no config is exported from postcss.config.js --> Closes PACK-2231
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description * collect memory allocation data and report it when tracing is enable * Add value mode to trace server to show memory info Closes PACK-2184
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * collect memory allocation data and report it when tracing is enable * Add value mode to trace server to show memory info Closes PACK-2184
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * collect memory allocation data and report it when tracing is enable * Add value mode to trace server to show memory info Closes PACK-2184
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description * collect memory allocation data and report it when tracing is enable * Add value mode to trace server to show memory info Closes PACK-2184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes PACK-2184