Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve nesting of tracing for invalidations #6886

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 4, 2024

Description

Before stuff that run after the task execution has finished wasn't accounted towards the task span. This includes cells changes which trigger a task reexecution.

Now we account these things to the task span too, which improves the trace reporting

Closes PACK-2193

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 3:35pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 3:35pm
rust-docs ❌ Failed (Inspect) Jan 10, 2024 3:35pm
turbo-site ✅ Ready (Inspect) Visit Preview Jan 10, 2024 3:35pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 3:35pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 3:35pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 3:35pm
examples-native-web ⬜️ Ignored (Inspect) Jan 10, 2024 3:35pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 10, 2024 3:35pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 3:35pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 3:35pm

Copy link
Contributor

github-actions bot commented Jan 4, 2024

⚠️ Turbopack Benchmark CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust checks

See workflow summary for details

Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jan 4, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit b611f41 into main Jan 10, 2024
43 of 47 checks passed
@sokra sokra deleted the sokra/tracing-nesting branch January 10, 2024 20:26
sokra added a commit to vercel/next.js that referenced this pull request Jan 17, 2024
### What?

api changes for vercel/turborepo#6988

### Turbopack Changes

* vercel/turborepo#6886 <!-- Tobias Koppers -
improve nesting of tracing for invalidations -->
* vercel/turborepo#6866 <!-- Tobias Koppers - trace
memory allocations and show in tracing -->
* vercel/turborepo#6988 <!-- Tobias Koppers - allow
to pass available chunk items when creating a chunk group -->
* vercel/turborepo#7013 <!-- Leah - fix: make CSS
reloading work on firefox -->
* vercel/turborepo#7004 <!-- Tobias Koppers -
improve error message when no config is exported from postcss.config.js
-->




Closes PACK-2231
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Before stuff that run after the task execution has finished wasn't
accounted towards the task span. This includes cells changes which
trigger a task reexecution.

Now we account these things to the task span too, which improves the
trace reporting

Closes PACK-2193
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Before stuff that run after the task execution has finished wasn't
accounted towards the task span. This includes cells changes which
trigger a task reexecution.

Now we account these things to the task span too, which improves the
trace reporting

Closes PACK-2193
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Before stuff that run after the task execution has finished wasn't
accounted towards the task span. This includes cells changes which
trigger a task reexecution.

Now we account these things to the task span too, which improves the
trace reporting

Closes PACK-2193
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Before stuff that run after the task execution has finished wasn't
accounted towards the task span. This includes cells changes which
trigger a task reexecution.

Now we account these things to the task span too, which improves the
trace reporting

Closes PACK-2193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants