-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom_extensions to resolve options context #7367
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
module.exports = { | ||
experimental: { | ||
turbo: { | ||
resolveExtensions: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be a good idea to move functionality like this to a shared field that both webpack and turbopack read from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, this needs to be added to the typescript types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right, this isn't the next.js repo yet, we should really move the docs over
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original comment still stands though, maybe this should be something like experimental.compiler.resolveExtensions
?
Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
…#62092) ### What? see vercel/turborepo#7398 ### Turbopack Changes * vercel/turborepo#7367 <!-- Tobias Koppers - add custom_extensions to resolve options context --> * vercel/turborepo#7398 <!-- Tobias Koppers - add support for dynamic requests in require() and import() --> Closes PACK-2513
### Description enables to customize extensions in next.js ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2482 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
### Description enables to customize extensions in next.js ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2482 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
### Description enables to customize extensions in next.js ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2482 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
### Description enables to customize extensions in next.js ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2482 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
Description
enables to customize extensions in next.js
Testing Instructions
Closes PACK-2482