add support for dynamic requests in require() and import() #7398
+840
−473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
|
✅ This change can build |
ForsakenHarmony
approved these changes
Feb 15, 2024
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Feb 15, 2024
…#62092) ### What? see vercel/turborepo#7398 ### Turbopack Changes * vercel/turborepo#7367 <!-- Tobias Koppers - add custom_extensions to resolve options context --> * vercel/turborepo#7398 <!-- Tobias Koppers - add support for dynamic requests in require() and import() --> Closes PACK-2513
| if let Expr::Call(call_expr) = expr { | ||
| let args = std::mem::take(&mut call_expr.args); | ||
| *expr = match args.into_iter().next() { | ||
| Some(ExprOrSpread { expr, spread: None }) => pm.create_require(*expr), |
There was a problem hiding this comment.
Unfortunately I just noticed this now, but this looks very wrong, this should insert a string, not a require call
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…rborepo#7398) ### Description Refactors `PatternMatching` to support a map of multiple matches by key. Based on the new `RequestKey` support for resolving. Code Generation for `require("./dir/"+ expr)` will emit a map of `__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr)`. The output format isn't really optimized yet, that's work for future PRs. ### Testing Instructions added a test case, enabled one previously skipped test case Closes PACK-2512
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…rborepo#7398) ### Description Refactors `PatternMatching` to support a map of multiple matches by key. Based on the new `RequestKey` support for resolving. Code Generation for `require("./dir/"+ expr)` will emit a map of `__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr)`. The output format isn't really optimized yet, that's work for future PRs. ### Testing Instructions added a test case, enabled one previously skipped test case Closes PACK-2512
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…rborepo#7398) ### Description Refactors `PatternMatching` to support a map of multiple matches by key. Based on the new `RequestKey` support for resolving. Code Generation for `require("./dir/"+ expr)` will emit a map of `__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr)`. The output format isn't really optimized yet, that's work for future PRs. ### Testing Instructions added a test case, enabled one previously skipped test case Closes PACK-2512
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…rborepo#7398) ### Description Refactors `PatternMatching` to support a map of multiple matches by key. Based on the new `RequestKey` support for resolving. Code Generation for `require("./dir/"+ expr)` will emit a map of `__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr)`. The output format isn't really optimized yet, that's work for future PRs. ### Testing Instructions added a test case, enabled one previously skipped test case Closes PACK-2512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors
PatternMatchingto support a map of multiple matches by key. Based on the newRequestKeysupport for resolving.Code Generation for
require("./dir/"+ expr)will emit a map of__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr).The output format isn't really optimized yet, that's work for future PRs.
Testing Instructions
added a test case, enabled one previously skipped test case
Closes PACK-2512