Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JS package updates for pipeline -> tasks #8253

Conversation

chris-olszewski
Copy link
Member

Description

Updates various JS packages with the new turbo.json schema without breaking existing functionality.

We introduce SchemaV1 which has the old pipeline key. This is the type that the existing codemods target while future codemods will target Schema. LegacySchema is a compatibility type for codemods that support both.

Testing Instructions

Existing test suite passes.

Added tests for pipeline -> tasks codemod

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:51pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 30, 2024 3:51pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 30, 2024 3:51pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 30, 2024 3:51pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 30, 2024 3:51pm
examples-native-web ⬜️ Ignored (Inspect) May 30, 2024 3:51pm
examples-svelte-web ⬜️ Ignored (Inspect) May 30, 2024 3:51pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 30, 2024 3:51pm
examples-vite-web ⬜️ Ignored (Inspect) May 30, 2024 3:51pm
rust-docs ⬜️ Ignored (Inspect) May 30, 2024 3:51pm

Copy link
Contributor

github-actions bot commented May 30, 2024

🟢 CI successful 🟢

Thanks

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@chris-olszewski chris-olszewski marked this pull request as ready for review May 30, 2024 16:13
@chris-olszewski chris-olszewski requested a review from a team as a code owner May 30, 2024 16:13
@chris-olszewski chris-olszewski merged commit c41e573 into turborepo_2 May 30, 2024
56 checks passed
@chris-olszewski chris-olszewski deleted the chrisolszewski/turbo-3150-codemod-to-rename-pipeline-object-to-tasks branch May 30, 2024 18:28
chris-olszewski added a commit that referenced this pull request May 30, 2024
### Description

#8253 and #8248 ended up landing close enough that they broke the
branch. This PR updates the latter to use `tasks` instead of `pipeline`.

### Testing Instructions

CI
chris-olszewski added a commit that referenced this pull request May 31, 2024
### Description

Updates various JS packages with the new `turbo.json` schema without
breaking existing functionality.

We introduce `SchemaV1` which has the old `pipeline` key. This is the
type that the existing codemods target while future codemods will target
`Schema`. `LegacySchema` is a compatibility type for codemods that
support both.

### Testing Instructions

Existing test suite passes.

Added tests for `pipeline` -> `tasks` codemod
chris-olszewski added a commit that referenced this pull request May 31, 2024
### Description

#8253 and #8248 ended up landing close enough that they broke the
branch. This PR updates the latter to use `tasks` instead of `pipeline`.

### Testing Instructions

CI
chris-olszewski added a commit that referenced this pull request Jun 4, 2024
### Description

Updates various JS packages with the new `turbo.json` schema without
breaking existing functionality.

We introduce `SchemaV1` which has the old `pipeline` key. This is the
type that the existing codemods target while future codemods will target
`Schema`. `LegacySchema` is a compatibility type for codemods that
support both.

### Testing Instructions

Existing test suite passes.

Added tests for `pipeline` -> `tasks` codemod
chris-olszewski added a commit that referenced this pull request Jun 4, 2024
### Description

#8253 and #8248 ended up landing close enough that they broke the
branch. This PR updates the latter to use `tasks` instead of `pipeline`.

### Testing Instructions

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants