feat: JS package updates for pipeline -> tasks

packages/eslint-plugin-turbo/lib/utils/calculate-inputs.ts

@@ -4,7 +4,8 @@ import path from "node:path";
 import type { WorkspaceConfig } from "@turbo/utils";
 import { getWorkspaceConfigs } from "@turbo/utils";
 import type { Pipeline } from "@turbo/types";
-import type { RootSchema } from "@turbo/types/src/types/config";
+import type { RootSchema, RootSchemaV1 } from "@turbo/types/src/types/config";
+import { forEachTaskDef } from "@turbo/utils/src/getTurboConfigs";
 import { dotEnv } from "./dotenv-processing";
 import { wildcardTests } from "./wildcard-processing";
 
@@ -131,7 +132,7 @@ function processDotEnv(
 
 function processGlobal(
   workspacePath: string,
-  rootTurboJson: RootSchema
+  rootTurboJson: RootSchema | RootSchemaV1
 ): EnvironmentConfig {
   return {
     legacyConfig: processLegacyConfig(rootTurboJson.globalDependencies),
@@ -314,7 +315,8 @@ export class Project {
         this.projectRoot.turboConfig
       );
 
-      Object.entries(this.projectRoot.turboConfig.pipeline).forEach(
+      forEachTaskDef(
+        this.projectRoot.turboConfig,
         ([taskName, taskDefinition]) => {
           const { workspaceName, scriptName } = getTaskAddress(taskName);
           if (workspaceName) {
@@ -341,7 +343,8 @@ export class Project {
         return;
       }
 
-      Object.entries(projectWorkspace.turboConfig.pipeline).forEach(
+      forEachTaskDef(
+        projectWorkspace.turboConfig,
         ([taskName, taskDefinition]) => {
           const { workspaceName: erroneousWorkspaceName, scriptName } =
             getTaskAddress(taskName);

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/no-turbo-json/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "set-default-outputs-no-turbo-json",
+  "version": "1.0.0",
+  "dependencies": {},
+  "devDependencies": {},
+  "packageManager": "npm@1.2.3"
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/root-only/important.txt

@@ -0,0 +1 @@
+hello

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/root-only/package.json

@@ -0,0 +1 @@
+{}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/root-only/turbo.json

@@ -0,0 +1,9 @@
+{
+  "$schema": "https://turbo.build/schema.json",
+  "globalDependencies": ["important.txt"],
+  "pipeline": {
+    "build": {
+      "outputs": ["dist"]
+    }
+  }
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/apps/docs/index.js

@@ -0,0 +1,6 @@
+export default function docs() {
+  if (process.env.ENV_1 === undefined) {
+    return "does not exist";
+  }
+  return "exists";
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/apps/docs/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "docs",
+  "version": "1.0.0"
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/apps/docs/turbo.json

@@ -0,0 +1,9 @@
+{
+  "$schema": "https://turbo.build/schema.json",
+  "extends": ["//"],
+  "pipeline": {
+    "build": {
+      "env": ["ENV_3"]
+    }
+  }
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/apps/web/index.js

@@ -0,0 +1,6 @@
+export default function web() {
+  if (!process.env.ENV_2) {
+    return "bar";
+  }
+  return "foo";
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/apps/web/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "web",
+  "version": "1.0.0"
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/apps/web/turbo.json

@@ -0,0 +1,9 @@
+{
+  "$schema": "https://turbo.build/schema.json",
+  "extends": ["//"],
+  "pipeline": {
+    "build": {
+      "dependsOn": []
+    }
+  }
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/package.json

@@ -0,0 +1,14 @@
+{
+  "private": true,
+  "workspaces": [
+    "apps/*",
+    "packages/*"
+  ],
+  "scripts": {
+    "build": "turbo run build"
+  },
+  "devDependencies": {
+    "turbo": "latest"
+  },
+  "packageManager": "yarn@1.22.19"
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/packages/ui/index.js

@@ -0,0 +1,6 @@
+export default function foo() {
+  if (!process.env.IS_SERVER) {
+    return "bar";
+  }
+  return "foo";
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/packages/ui/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "ui",
+  "version": "1.0.0"
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/packages/ui/turbo.json

@@ -0,0 +1,9 @@
+{
+  "$schema": "https://turbo.build/schema.json",
+  "extends": ["//"],
+  "pipeline": {
+    "test": {
+      "dependsOn": ["build"]
+    }
+  }
+}

packages/turbo-codemod/__tests__/__fixtures__/rename-pipeline/workspace-configs/turbo.json

@@ -0,0 +1,18 @@
+{
+  "$schema": "https://turbo.build/schema.json",
+  "pipeline": {
+    "build": {
+      "outputs": [".next/**", "!.next/cache/**"],
+      "dependsOn": ["^build"]
+    },
+    "lint": {
+      "outputs": []
+    },
+    "test": {
+      "outputs": []
+    },
+    "dev": {
+      "cache": false
+    }
+  }
+}

packages/turbo-codemod/__tests__/migrate-env-var-dependencies.test.ts

@@ -1,5 +1,6 @@
 import merge from "deepmerge";
 import type { Schema } from "@turbo/types";
+import type { SchemaV1 } from "@turbo/types/src/types/config";
 import { setupTestFixtures } from "@turbo/test-utils";
 import {
   hasLegacyEnvVarDependencies,
@@ -8,7 +9,9 @@ import {
   transformer,
 } from "../src/transforms/migrate-env-var-dependencies";
 
-const getTestTurboConfig = (override: Schema = { pipeline: {} }): Schema => {
+const getTestTurboConfig = (
+  override: SchemaV1 = { pipeline: {} }
+): SchemaV1 => {
   const config = {
     $schema: "./docs/public/schema.json",
     globalDependencies: ["$GLOBAL_ENV_KEY"],

packages/turbo-codemod/__tests__/rename-pipeline.ts

@@ -0,0 +1,142 @@
+import { setupTestFixtures } from "@turbo/test-utils";
+import { transformer } from "../src/transforms/rename-pipeline";
+
+describe("rename-pipeline", () => {
+  const { useFixture } = setupTestFixtures({
+    directory: __dirname,
+    test: "rename-pipeline",
+  });
+
+  it("migrates turbo.json pipeline - root config only", () => {
+    // load the fixture for the test
+    const { root, read } = useFixture({
+      fixture: "root-only",
+    });
+
+    // run the transformer
+    const result = transformer({
+      root,
+      options: { force: false, dry: false, print: false },
+    });
+
+    expect(JSON.parse(read("turbo.json") || "{}")).toStrictEqual({
+      $schema: "https://turbo.build/schema.json",
+      globalDependencies: ["important.txt"],
+      tasks: {
+        build: {
+          outputs: ["dist"],
+        },
+      },
+    });
+
+    expect(result.fatalError).toBeUndefined();
+    expect(result.changes).toMatchInlineSnapshot(`
+      Object {
+        "turbo.json": Object {
+          "action": "modified",
+          "additions": 1,
+          "deletions": 1,
+        },
+      }
+    `);
+  });
+
+  it("migrates turbo.json pipeline - workspace configs", () => {
+    // load the fixture for the test
+    const { root, read } = useFixture({
+      fixture: "workspace-configs",
+    });
+
+    // run the transformer
+    const result = transformer({
+      root,
+      options: { force: false, dry: false, print: false },
+    });
+
+    expect(JSON.parse(read("turbo.json") || "{}")).toStrictEqual({
+      $schema: "https://turbo.build/schema.json",
+      tasks: {
+        build: {
+          dependsOn: ["^build"],
+          outputs: [".next/**", "!.next/cache/**"],
+        },
+        dev: {
+          cache: false,
+        },
+        lint: {
+          outputs: [],
+        },
+        test: {
+          outputs: [],
+        },
+      },
+    });
+
+    expect(JSON.parse(read("apps/web/turbo.json") || "{}")).toStrictEqual({
+      $schema: "https://turbo.build/schema.json",
+      extends: ["//"],
+      tasks: {
+        build: {
+          dependsOn: [],
+        },
+      },
+    });
+
+    expect(JSON.parse(read("packages/ui/turbo.json") || "{}")).toStrictEqual({
+      $schema: "https://turbo.build/schema.json",
+      extends: ["//"],
+      tasks: {
+        test: {
+          dependsOn: ["build"],
+        },
+      },
+    });
+
+    expect(result.fatalError).toBeUndefined();
+    expect(result.changes).toMatchInlineSnapshot(`
+      Object {
+        "apps/docs/turbo.json": Object {
+          "action": "modified",
+          "additions": 1,
+          "deletions": 1,
+        },
+        "apps/web/turbo.json": Object {
+          "action": "modified",
+          "additions": 1,
+          "deletions": 1,
+        },
+        "packages/ui/turbo.json": Object {
+          "action": "modified",
+          "additions": 1,
+          "deletions": 1,
+        },
+        "turbo.json": Object {
+          "action": "modified",
+          "additions": 1,
+          "deletions": 1,
+        },
+      }
+    `);
+  });
+
+  it("errors if no turbo.json can be found", () => {
+    // load the fixture for the test
+    const { root, read } = useFixture({
+      fixture: "no-turbo-json",
+    });
+
+    expect(read("turbo.json")).toBeUndefined();
+
+    // run the transformer
+    const result = transformer({
+      root,
+      options: { force: false, dry: false, print: false },
+    });
+
+    expect(read("turbo.json")).toBeUndefined();
+    expect(result.fatalError).toBeDefined();
+    expect(result.fatalError?.message).toMatch(
+      /No turbo\.json found at .*?\. Is the path correct\?/
+    );
+  });
+});

packages/turbo-codemod/src/transforms/clean-globs.ts

@@ -1,5 +1,5 @@
 import path from "node:path";
-import type { Schema as TurboJsonSchema } from "@turbo/types";
+import type { SchemaV1 } from "@turbo/types/src/types/config";
 import { readJsonSync } from "fs-extra";
 import { getTurboConfigs } from "@turbo/utils";
 import type { TransformerArgs, Transformer } from "../types";
@@ -24,7 +24,7 @@ export function transformer({
 
   const turboConfigPath = path.join(root, "turbo.json");
 
-  const turboJson = readJsonSync(turboConfigPath) as TurboJsonSchema;
+  const turboJson = readJsonSync(turboConfigPath) as SchemaV1;
   runner.modifyFile({
     filePath: turboConfigPath,
     after: migrateConfig(turboJson),
@@ -34,16 +34,18 @@ export function transformer({
   const workspaceConfigs = getTurboConfigs(root);
   workspaceConfigs.forEach((workspaceConfig) => {
     const { config, turboConfigPath: filePath } = workspaceConfig;
-    runner.modifyFile({
-      filePath,
-      after: migrateConfig(config),
-    });
+    if ("pipeline" in config) {
+      runner.modifyFile({
+        filePath,
+        after: migrateConfig(config),
+      });
+    }
   });
 
   return runner.finish();
 }
 
-function migrateConfig(config: TurboJsonSchema) {
+function migrateConfig(config: SchemaV1) {
   const mapGlob = (glob: string) => fixGlobPattern(glob);
   for (const [_, taskDef] of Object.entries(config.pipeline)) {
     taskDef.inputs = taskDef.inputs?.map(mapGlob);