Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a mistake in official file gen_kpp.c, their gen_kpp.c 's function definition order is reserved! So when you make there is a report of error:implicit function: write_list_to_screen,screen_out,check_all 官方很多WRF版本的chem下面的/chem/KPP/util/wkc/gen_kpp.c都是错的(直到2023.4.27最新版的WRF里面的这个都还是错的),因为他把函数顺序给放反了,把write_list_to_screen跟screen_out还有check_all都放在最下面了,而gen_kpp函数却放在最上面,所以就会导致报错函数没有定义,因此需要将原文件里面的函数顺序换一下,把write_list_to_screen等3个函数放到gen_kpp的上面,在我的这里是已经修改好的gen_kpp.c文件,下载后替换即可
TYPE: bug fix
KEYWORDS: kpp,gen_kpp,/chem/KPP/util/wkc/gen_kpp.c
SOURCE:https://github.com/vergillovedante this is my homepage on github email is vergillovedante@outlook.com
DESCRIPTION OF CHANGES:
Problem:one of the the file's of kpp's functions' sequence is wrong
Solution:replace gen_kpp.c with my uploaded file
ISSUE: Fixes:001 -provided by lxy(vergillovedante)
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.
The first line should be a single-line "purpose" for this change
TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]
KEYWORDS: 5 to 10 words related to commit, separated by commas
SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member
DESCRIPTION OF CHANGES:
Problem:
Generally or specifically, what was wrong and needed to be addressed?
Solution:
What was down algorithmically and in the source code to address the problem?
ISSUE: For use when this PR closes an issue.
Fixes wrf-model#123
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status master
to get formatted list)TESTS CONDUCTED:
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.