Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gen_kpp.c #1

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Update gen_kpp.c #1

merged 1 commit into from
Jul 12, 2023

Conversation

vergillovedante
Copy link
Owner

there is a mistake in official file gen_kpp.c, their gen_kpp.c 's function definition order is reserved! So when you make there is a report of error:implicit function: write_list_to_screen,screen_out,check_all 官方很多WRF版本的chem下面的/chem/KPP/util/wkc/gen_kpp.c都是错的(直到2023.4.27最新版的WRF里面的这个都还是错的),因为他把函数顺序给放反了,把write_list_to_screen跟screen_out还有check_all都放在最下面了,而gen_kpp函数却放在最上面,所以就会导致报错函数没有定义,因此需要将原文件里面的函数顺序换一下,把write_list_to_screen等3个函数放到gen_kpp的上面,在我的这里是已经修改好的gen_kpp.c文件,下载后替换即可

TYPE: bug fix

KEYWORDS: kpp,gen_kpp,/chem/KPP/util/wkc/gen_kpp.c

SOURCE:https://github.com/vergillovedante this is my homepage on github email is vergillovedante@outlook.com

DESCRIPTION OF CHANGES:
Problem:one of the the file's of kpp's functions' sequence is wrong

Solution:replace gen_kpp.c with my uploaded file

ISSUE: Fixes:001 -provided by lxy(vergillovedante)

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

The first line should be a single-line "purpose" for this change

TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]

KEYWORDS: 5 to 10 words related to commit, separated by commas

SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member

DESCRIPTION OF CHANGES:
Problem:
Generally or specifically, what was wrong and needed to be addressed?

Solution:
What was down algorithmically and in the source code to address the problem?

ISSUE: For use when this PR closes an issue.
Fixes wrf-model#123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

there is a mistake in official file gen_kpp.c, their gen_kpp.c 's function definition order is reserved! So when you make there is a report of error:implicit function: write_list_to_screen,screen_out,check_all 官方很多WRF版本的chem下面的/chem/KPP/util/wkc/gen_kpp.c都是错的(直到2023.4.27最新版的WRF里面的这个都还是错的),因为他把函数顺序给放反了,把write_list_to_screen跟screen_out还有check_all都放在最下面了,而gen_kpp函数却放在最上面,所以就会导致报错函数没有定义,因此需要将原文件里面的函数顺序换一下,把write_list_to_screen等3个函数放到gen_kpp的上面,在我的这里是已经修改好的gen_kpp.c文件,下载后替换即可

TYPE: bug fix

KEYWORDS: kpp,gen_kpp,/chem/KPP/util/wkc/gen_kpp.c

SOURCE:https://github.com/vergillovedante  this is my homepage on github email is vergillovedante@outlook.com

DESCRIPTION OF CHANGES:
Problem:one of the the file's  of kpp's functions' sequence is wrong


Solution:replace gen_kpp.c with my uploaded file


ISSUE: Fixes:001 -provided by lxy(vergillovedante)



RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.
@vergillovedante vergillovedante merged commit 276c4f1 into patch-1 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant