Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency for hailcast diagnostics #123

Closed
wants to merge 1 commit into from
Closed

Add missing dependency for hailcast diagnostics #123

wants to merge 1 commit into from

Conversation

davegill
Copy link
Contributor

TYPE: bug fix

KEYWORDS: hailcast, dependency

SOURCE: internal

DESCRIPTION OF CHANGES:

The PR for hailcast diagnostics (#86), did not include a set of dependencies for the new module, nor did it list the new module as a necessary file for the diagnostics driver.

LIST OF MODIFIED FILES:

M main/depend.common

TESTS CONDUCTED:

  1. Code builds with
    setenv J "-j 1"
    ... and it did not previously.

TYPE: bug fix

KEYWORDS: hailcast, dependency

SOURCE: internal

DESCRIPTION OF CHANGES:
The PR for hailcast diagnostics (#86), did not include a set of dependencies for the new module, nor did it list the new module as a necessary file for the diagnostics driver.

LIST OF MODIFIED FILES:
M       main/depend.common

TESTS CONDUCTED:
1. Code builds with
setenv J "-j 1"
... and it did not previously.
@mkavulich
Copy link
Contributor

Already included with PR #126

@mkavulich mkavulich closed this Jan 21, 2017
@davegill davegill deleted the HAILCAST_DEPEND branch March 27, 2017 16:24
@coastwx coastwx mentioned this pull request Dec 14, 2018
@powersjg powersjg mentioned this pull request Aug 5, 2020
@mer-a-o mer-a-o mentioned this pull request Aug 5, 2020
@theoc theoc mentioned this pull request Nov 4, 2020
@vlakshmanan-scala vlakshmanan-scala mentioned this pull request Dec 17, 2020
This was referenced Jan 21, 2021
@rcu1 rcu1 mentioned this pull request Mar 15, 2023
@mos3r3n mos3r3n mentioned this pull request Dec 22, 2023
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
WRFv4.4 crashes upon LSM initialization when NLCD40 landuse dataset is used because of the VEGPARM tables settings.

TYPE: bug fix

KEYWORDS: VEGPARM.TBL, NLCD40, LCZ_1, NUDAP

SOURCE: Robert Gilliam, US EPA

DESCRIPTION OF CHANGES:
Problem:
WRFv4.4 crashes when reading the VEGPARM.TBL file because of the the LCZ_* specs at the end of the main NLCD40 table entries.

Solution:
We just copied the values used for MODIS since the NLCD40 is a blend of US NLCD and MODIS.

ISSUE: For use when this PR closes an issue.
Fixes wrf-model#123

LIST OF MODIFIED FILES: VEGPARM.TBL

TESTS CONDUCTED:

Does the mode fix the problem: Yes. We ran a full 2018 simulation at 12 km CONUS and 108 km N. Hemisphere scales and verified this works.
The Jenkins tests have passed.

RELEASE NOTE: VEGPARM.TBL updated for NLCD40 landuse case to work with recent updates of the LSM initialization that reads the file.
@tliartsi tliartsi mentioned this pull request May 22, 2024
@namo626 namo626 mentioned this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants