Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment #1341

Closed

Conversation

vlakshmanan-scala
Copy link

The first line should be a single-line "purpose" for this change

TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]

KEYWORDS: 5 to 10 words related to commit, separated by commas

SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member

DESCRIPTION OF CHANGES:
Problem:
Generally or specifically, what was wrong and needed to be addressed?

Solution:
What was down algorithmically and in the source code to address the problem?

ISSUE: For use when this PR closes an issue.
Fixes #123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

@vlakshmanan-scala vlakshmanan-scala requested review from a team as code owners December 17, 2020 12:38
@vlakshmanan-scala vlakshmanan-scala changed the base branch from master to release-v4.2.2 December 17, 2020 12:39
@vlakshmanan-scala vlakshmanan-scala deleted the assignment branch December 17, 2020 12:41
@vlakshmanan-scala vlakshmanan-scala restored the assignment branch December 17, 2020 12:41
@davegill
Copy link
Contributor

@vlakshmanan-scala
Please use #1292 as the branch for testing the WRF model #1292. Using these other PRs confuses developers and the core group of reviewers. If you need a new branch constructed for testing, let me know.

@vlakshmanan-scala
Copy link
Author

Hi David, sorry for the confusion, it was by mistake. I have deleted the PR, I'll keep in mind in the future. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants