set DisableNonReplicatableQueries before sandboxing subcluster during online upgrade #853

fenic-fawkes · 2024-07-09T16:25:25Z

mostly based on the work in #831 plus fixing merge conflicts, etc

pkg/controllers/vdb/onlineupgrade_reconciler.go

pkg/controllers/vdb/getconfigparameter_reconciler.go

scripts/guess-server-upgrade-base-image.sh

pkg/catalog/config_parameter_vcluster.go

scripts/guess-server-upgrade-base-image.sh

pkg/controllers/vdb/onlineupgrade_reconciler.go

CLAassistant · 2024-07-25T03:07:21Z

All committers have signed the CLA.

cchen-vertica

Looks good. For testing your code, you could add step 36 in
e2e-leg-9/new-online-upgrade-sanity to verify non-replicable queries cannot be made in old main cluster, and add step 47 to verify we can make non-replicable queries in new main cluster.

cchen-vertica · 2024-07-31T14:30:21Z

You don't need to modify the added test step(36). It looks good.

Once you fixed the conflicts and passed the test, I will approve it.

cchen-vertica · 2024-08-02T21:02:47Z

pkg/controllers/vdb/upgrade.go

+		return ctrl.Result{Requeue: true}, nil
+	}
+
+	cmd := []string{"-tAc", "SELECT count(*) FROM node_subscriptions WHERE subscription_state not in ('ACTIVE', 'INACTIVE');"}


Can the subscriptions be "INACTIVE"? Why not using "subscription_state != 'ACTIVE'"?

running a test, yes. subscriptions can be inactive and stay that way. for our use case we don't really care, this check is enough to make sure that sandbox can be run successfully

My understanding is: if subscriptions on the nodes of a subcluster are inactive, the subcluster doesn't have coverage to do the sandbox. What do I miss?

i'm not sure. all i know is that running rebalance_shards didn't change the subscription_state and sandboxing went fine

subscription_state probably is "PENDING" after add_node(before rebalance_shards) so this check fixed the issue. But the safer way is to verify all subscriptions are "ACTIVE".

roypaulin

Merge the main into your branch to get the latest changes.

pkg/controllers/vdb/onlineupgrade_reconciler.go

roypaulin · 2024-08-03T02:16:25Z

pkg/controllers/vdb/onlineupgrade_reconciler.go

+	Manager                                               UpgradeManager
+	Dispatcher                                            vadmin.Dispatcher
+	sandboxName                                           string // name of the sandbox created for replica group B
+	originalConfigParamDisableNonReplicatableQueriesValue string


Aren't we going to set back the original value when upgrade is done?

why? this is an undocumented parameter that, eg, prevents reip for now and is purely needed for upgrade. once we've addressed the issues on the server side i'd be open to setting it, especially if we document it, but for now i think we should leave it cleared in the new cluster

pkg/controllers/vdb/onlineupgrade_reconciler.go

…n during upgrade

pkg/controllers/vdb/onlineupgrade_reconciler.go

pkg/events/event.go

pkg/controllers/vdb/onlineupgrade_reconciler.go

tests/e2e-leg-9/new-online-upgrade-bad-image/32-assert.yaml

…ries session scoped

fenic-fawkes requested review from roypaulin and cchen-vertica as code owners July 9, 2024 16:25

roypaulin reviewed Jul 10, 2024

View reviewed changes

roypaulin reviewed Jul 15, 2024

View reviewed changes

pkg/catalog/config_parameter_vcluster.go Outdated Show resolved Hide resolved

roypaulin reviewed Jul 15, 2024

View reviewed changes

scripts/guess-server-upgrade-base-image.sh Outdated Show resolved Hide resolved

roypaulin reviewed Jul 15, 2024

View reviewed changes

pkg/controllers/vdb/onlineupgrade_reconciler.go Show resolved Hide resolved

cchen-vertica force-pushed the vnext branch from 5bdb36b to 29db384 Compare July 24, 2024 19:38

Base automatically changed from vnext to main July 26, 2024 18:57

fenic-fawkes force-pushed the fenic/VER-92800-set-DisableNonReplicatableQueries branch 2 times, most recently from 3a0d601 to c89ff2e Compare July 29, 2024 15:53

fenic-fawkes requested a review from roypaulin July 29, 2024 15:53

cchen-vertica reviewed Jul 29, 2024

View reviewed changes

fenic-fawkes force-pushed the fenic/VER-92800-set-DisableNonReplicatableQueries branch from 544e1b8 to 7411a28 Compare August 1, 2024 15:39

cchen-vertica reviewed Aug 2, 2024

View reviewed changes

roypaulin reviewed Aug 3, 2024

View reviewed changes

fenic-fawkes added 4 commits August 5, 2024 09:04

upgrade vertica images used in upgrade

10b7518

add collection of vertica.log for upgade tests

d55720a

add get/set config param api to vcluster

73c0ba2

add for-upgrade option to sandbox reconciler to allow sandbox creatio…

026bcfb

…n during upgrade

fenic-fawkes force-pushed the fenic/VER-92800-set-DisableNonReplicatableQueries branch from cef7c7a to 05ef7fd Compare August 5, 2024 13:13

fenic-fawkes added 2 commits August 5, 2024 09:35

set DisableNonReplicatableQueries during upgrade

44a366e

address pr feedback

ef15842

fenic-fawkes force-pushed the fenic/VER-92800-set-DisableNonReplicatableQueries branch from 05ef7fd to ef15842 Compare August 5, 2024 13:36

fenic-fawkes requested review from cchen-vertica and roypaulin August 5, 2024 13:37

roypaulin reviewed Aug 5, 2024

View reviewed changes

pkg/controllers/vdb/onlineupgrade_reconciler.go Outdated Show resolved Hide resolved

fenic-fawkes force-pushed the fenic/VER-92800-set-DisableNonReplicatableQueries branch from 288b664 to dba7c3f Compare August 5, 2024 17:23

cchen-vertica reviewed Aug 5, 2024

View reviewed changes

pkg/events/event.go Outdated Show resolved Hide resolved

roypaulin reviewed Aug 5, 2024

View reviewed changes

tests/e2e-leg-9/new-online-upgrade-bad-image/32-assert.yaml Outdated Show resolved Hide resolved

fenic-fawkes added 4 commits August 5, 2024 16:47

address pr feedback

89c6f26

fixup! add get/set config param api to vcluster

89b4443

fixup! set DisableNonReplicatableQueries during upgrade

c3a365e

make tests more reliable

2f15656

fenic-fawkes force-pushed the fenic/VER-92800-set-DisableNonReplicatableQueries branch from ef5a218 to 2f15656 Compare August 5, 2024 21:05

fenic-fawkes requested review from cchen-vertica and roypaulin August 5, 2024 21:06

fenic-fawkes and others added 9 commits August 6, 2024 10:49

fix multi-online-upgrade

40a29cd

fix step checking

a7c3ccf

fixed e2e tests

ec0c40d

try fixing added test?

c26c038

give up and remove test for now

629ff9d

fix new-online-upgrade-sanity

2551a4e

make restore point creation modification of DisableNonReplicatableQue…

da19847

…ries session scoped

increase stern logging limit to avoid warning in tests

e790950

add verification of config params in main/sb clusters to tests

352bd9d

cchen-vertica approved these changes Aug 8, 2024

View reviewed changes

fenic-fawkes merged commit 94916d7 into main Aug 8, 2024
31 checks passed

fenic-fawkes deleted the fenic/VER-92800-set-DisableNonReplicatableQueries branch August 8, 2024 17:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set DisableNonReplicatableQueries before sandboxing subcluster during online upgrade #853

set DisableNonReplicatableQueries before sandboxing subcluster during online upgrade #853

fenic-fawkes commented Jul 9, 2024

CLAassistant commented Jul 25, 2024 •

edited

Loading

cchen-vertica left a comment

cchen-vertica commented Jul 31, 2024

cchen-vertica Aug 2, 2024

fenic-fawkes Aug 5, 2024

cchen-vertica Aug 5, 2024

fenic-fawkes Aug 5, 2024

cchen-vertica Aug 5, 2024 •

edited

Loading

roypaulin left a comment

roypaulin Aug 3, 2024

fenic-fawkes Aug 5, 2024

set DisableNonReplicatableQueries before sandboxing subcluster during online upgrade #853

set DisableNonReplicatableQueries before sandboxing subcluster during online upgrade #853

Conversation

fenic-fawkes commented Jul 9, 2024

CLAassistant commented Jul 25, 2024 • edited Loading

cchen-vertica left a comment

Choose a reason for hiding this comment

cchen-vertica commented Jul 31, 2024

cchen-vertica Aug 2, 2024

Choose a reason for hiding this comment

fenic-fawkes Aug 5, 2024

Choose a reason for hiding this comment

cchen-vertica Aug 5, 2024

Choose a reason for hiding this comment

fenic-fawkes Aug 5, 2024

Choose a reason for hiding this comment

cchen-vertica Aug 5, 2024 • edited Loading

Choose a reason for hiding this comment

roypaulin left a comment

Choose a reason for hiding this comment

roypaulin Aug 3, 2024

Choose a reason for hiding this comment

fenic-fawkes Aug 5, 2024

Choose a reason for hiding this comment

CLAassistant commented Jul 25, 2024 •

edited

Loading

cchen-vertica Aug 5, 2024 •

edited

Loading