Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set DisableNonReplicatableQueries before sandboxing subcluster during online upgrade #853
set DisableNonReplicatableQueries before sandboxing subcluster during online upgrade #853
Changes from 6 commits
10b7518
d55720a
73c0ba2
026bcfb
44a366e
ef15842
89c6f26
89b4443
c3a365e
2f15656
40a29cd
a7c3ccf
ec0c40d
c26c038
629ff9d
2551a4e
da19847
e790950
352bd9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we going to set back the original value when upgrade is done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? this is an undocumented parameter that, eg, prevents reip for now and is purely needed for upgrade. once we've addressed the issues on the server side i'd be open to setting it, especially if we document it, but for now i think we should leave it cleared in the new cluster