Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend metrics and measure fetch WS separately from LoadSnap #47

Merged
merged 24 commits into from
Sep 15, 2020
Merged

Extend metrics and measure fetch WS separately from LoadSnap #47

merged 24 commits into from
Sep 15, 2020

Conversation

plamenmpetrov
Copy link
Collaborator

No description provided.

@plamenmpetrov
moved fetch to activate
f918845 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
exchanged order of activate and load
6874739 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
top level extended metrics
e08a3b6 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
only wait activate with upf
c6d7fe9 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
top lvl deps
3eb28ce 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
create the channel
098244a 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
top deps
e4004cc 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
error check in tests
f916134 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
refactor
c9e2a40 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
Refactor memory manager
2541ff5 
* Activate no longer has a channel which has to be waited on
* Export FetchState so it can be called explicitly from other modules

Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
Updated LoadSnapshot/Activate functionality
716975e 
* updated ctriface deps to latest memory manager
  FetchState is exposed and called explicitly in ctriface
* minor refactoring in benchmarks

Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
fix unnecessary check
49661b0 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
ctriface deps
2f1a363 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
Refactor top level benchmarks
1b45763 
* Update deps

Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
Remove regions form lazy metrics
949008c 
	- because regions are not counted when serving lazily

* Fixed bug in benchmarks

Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
update mem man dep
ff550ae 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
top lvl deps
e95a926 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
ustiugov
ustiugov reviewed Sep 14, 2020
View reviewed changes
memory/manager/manager.go Show resolved Hide resolved
memory/manager/snapshot_state.go Show resolved Hide resolved
memory/manager/manager.go Show resolved Hide resolved
@ustiugov
Copy link
Member

one more thing: need to have dropCache() triggered as a benchmark argument. right now it seems to be invoked all the time both in top module's and ctriface's benchmarks

plamenmpetrov and others added 7 commits September 14, 2020 06:04
@plamenmpetrov
refactor benchmark, add to travis
4f739f3 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
refactor DumpUPFPageStats
9e197c4 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
add cache as an argument
ba9f1c5 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
top lvl deps
a067941 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
combine test-man and bench
9358eca 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
removed obsolete ctriface bench
fb1ac43 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
Update README.md
3dc4e3c
@plamenmpetrov plamenmpetrov merged commit 070dd36 into master Sep 15, 2020
@ustiugov ustiugov deleted the fetch_ws_separate branch November 30, 2020 20:38
HermioneKT pushed a commit that referenced this pull request Jan 31, 2024
@KTCyber @HermioneKT
# This is a combination of 154 commits.
6674807 
# This is the 1st commit message:

refactor

# This is the commit message #2:

modify powerNodeSelector

# This is the commit message #3:

modify powerNodeSelector

# This is the commit message #4:

modify powerNodeSelector

# This is the commit message #5:

modify namespace

# This is the commit message #6:

modify namespace

# This is the commit message #7:

add namespace

# This is the commit message #8:

init power manager script

# This is the commit message #9:

add go code

# This is the commit message #10:

test

# This is the commit message #11:

test

# This is the commit message #12:

test

# This is the commit message #13:

test

# This is the commit message #14:

go.sum

# This is the commit message #15:

go sum

# This is the commit message #16:

go mod tidy

# This is the commit message #17:

test

# This is the commit message #18:

test

# This is the commit message #19:

test

# This is the commit message #20:

test

# This is the commit message #21:

test

# This is the commit message #22:

test

# This is the commit message #23:

test

# This is the commit message #24:

test

# This is the commit message #25:

test

# This is the commit message #26:

test

# This is the commit message #27:

test

# This is the commit message #28:

test

# This is the commit message #29:

print output

# This is the commit message #30:

test

# This is the commit message #31:

test

# This is the commit message #32:

test

# This is the commit message #33:

test

# This is the commit message #34:

test

# This is the commit message #35:

test

# This is the commit message #36:

test

# This is the commit message #37:

test

# This is the commit message #38:

test

# This is the commit message #39:

test

# This is the commit message #40:

refactor

# This is the commit message #41:

change val

# This is the commit message #42:

test

# This is the commit message #43:

test

# This is the commit message #44:

test

# This is the commit message #45:

exp1

# This is the commit message #46:

add url

# This is the commit message #47:

test

# This is the commit message #48:

test

# This is the commit message #49:

test auth

# This is the commit message #50:

test

# This is the commit message #51:

test

# This is the commit message #52:

test

# This is the commit message #53:

test

# This is the commit message #54:

test

# This is the commit message #55:

fix bug

# This is the commit message #56:

remove log

# This is the commit message #57:

test

# This is the commit message #58:

test

# This is the commit message #59:

test

# This is the commit message #60:

fix loop

# This is the commit message #61:

increase invocation

# This is the commit message #62:

test

# This is the commit message #63:

test

# This is the commit message #64:

test

# This is the commit message #65:

test

# This is the commit message #66:

test

# This is the commit message #67:

test

# This is the commit message #68:

test

# This is the commit message #69:

Test

# This is the commit message #70:

test

# This is the commit message #71:

test

# This is the commit message #72:

test

# This is the commit message #73:

test

# This is the commit message #74:

test

# This is the commit message #75:

test

# This is the commit message #76:

test

# This is the commit message #77:

test

# This is the commit message #78:

test

# This is the commit message #79:

test

# This is the commit message #80:

test

# This is the commit message #81:

test

# This is the commit message #82:

test

# This is the commit message #83:

test

# This is the commit message #84:

test

# This is the commit message #85:

test

# This is the commit message #86:

test

# This is the commit message #87:

test

# This is the commit message #88:

test

# This is the commit message #89:

test

# This is the commit message #90:

test1

# This is the commit message #91:

test

# This is the commit message #92:

test

# This is the commit message #93:

test

# This is the commit message #94:

test

# This is the commit message #95:

test

# This is the commit message #96:

test

# This is the commit message #97:

test

# This is the commit message #98:

test

# This is the commit message #99:

test

# This is the commit message #100:

test

# This is the commit message #101:

test

# This is the commit message #102:

test

# This is the commit message #103:

test

# This is the commit message #104:

test

# This is the commit message #105:

test

# This is the commit message #106:

test

# This is the commit message #107:

test

# This is the commit message #108:

test

# This is the commit message #109:

test1

# This is the commit message #110:

test

# This is the commit message #111:

test

# This is the commit message #112:

Test

# This is the commit message #113:

test

# This is the commit message #114:

test

# This is the commit message #115:

test

# This is the commit message #116:

test

# This is the commit message #117:

test

# This is the commit message #118:

test

# This is the commit message #119:

Test

# This is the commit message #120:

Test

# This is the commit message #121:

test

# This is the commit message #122:

test

# This is the commit message #123:

Test

# This is the commit message #124:

test

# This is the commit message #125:

test

# This is the commit message #126:

test

# This is the commit message #127:

test

# This is the commit message #128:

test

# This is the commit message #129:

test

# This is the commit message #130:

test

# This is the commit message #131:

test

# This is the commit message #132:

test

# This is the commit message #133:

test

# This is the commit message #134:

test

# This is the commit message #135:

test

# This is the commit message #136:

test

# This is the commit message #137:

test

# This is the commit message #138:

test

# This is the commit message #139:

test

# This is the commit message #140:

test

# This is the commit message #141:

test

# This is the commit message #142:

test

# This is the commit message #143:

Test

# This is the commit message #144:

Test

# This is the commit message #145:

Test

# This is the commit message #146:

Test

# This is the commit message #147:

test

# This is the commit message #148:

test

# This is the commit message #149:

test

# This is the commit message #150:

test

# This is the commit message #151:

test

# This is the commit message #152:

test

# This is the commit message #153:

test

# This is the commit message #154:

Test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plamenmpetrov @ustiugov