Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split build and test CI config files #90

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Split build and test CI config files #90

merged 4 commits into from
Jan 12, 2021

Conversation

shyamjesal
Copy link
Collaborator

Split go.yml into build and tests. taps and misc now execute on github runners.
Removed "TestCreateRemoveExtra" taps test.

Signed-off-by: Shyam Jesalpura s.jesalpura@gmail.com

@shyamjesal
separated build and test CI config files.
e56d729 
Split go.yml into build and tests. taps and misc now execute on github runners.
Removed "TestCreateRemoveExtra" test.

Signed-off-by: Shyam Jesalpura <s.jesalpura@gmail.com>
ustiugov
ustiugov requested changes Jan 12, 2021
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
taps/taps_test.go Show resolved Hide resolved
@ustiugov ustiugov added this to the vHive CI milestone Jan 12, 2021
@ustiugov
Copy link
Member

I think that it would make sense to separate integration tests and unit tests into two files.

@ustiugov
Copy link
Member

Please replace the travis build badge with a single badge (or 3 badges: Build, Integration Tests, Unit Tests), as shown here.

@ustiugov
Copy link
Member

Let us skip this test (AllFunctions) on self-hosted-runners as well:
https://github.com/ease-lab/vhive/blob/8be91e903d100f4c8df7a7cb0592b6ee74ae84d6/fccd-orchestrator_test.go#L289

However, we need to run it in Travis (Travis runs only a nightly regression right now). Need to figure out how to do that though

@shyamjesal
Split tests into build, unit and integration.
e0eaeba 
Github actions split into 3 yml files.
Skipped "TestCreateRemoveExtra" test due to failure on Github actions and it doesn't seem essential for the test coverage.
Skipped "TestAllFunctions" since travis runs only a nightly regression.

Signed-off-by: Shyam Jesalpura <s.jesalpura@gmail.com>
ustiugov
ustiugov requested changes Jan 12, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetic comments inlined.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@shyamjesal
nightly test Action added
b0161e4 
added nightly Github Action to "TestAllFunctions" integration test.

Signed-off-by: Shyam Jesalpura <s.jesalpura@gmail.com>
ustiugov
ustiugov requested changes Jan 12, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sorry. The badges are still missing

@shyamjesal shyamjesal force-pushed the master branch 11 times, most recently from efaa9cb to 8dabdc3 Compare January 12, 2021 19:20
@shyamjesal
updated README badges
31f766b 
Signed-off-by: Shyam Jesalpura <s.jesalpura@gmail.com>
@ustiugov ustiugov merged commit 674f416 into vhive-serverless:master Jan 12, 2021
HermioneKT pushed a commit that referenced this pull request Jan 31, 2024
@KTCyber @HermioneKT
# This is a combination of 154 commits.
6674807 
# This is the 1st commit message:

refactor

# This is the commit message #2:

modify powerNodeSelector

# This is the commit message #3:

modify powerNodeSelector

# This is the commit message #4:

modify powerNodeSelector

# This is the commit message #5:

modify namespace

# This is the commit message #6:

modify namespace

# This is the commit message #7:

add namespace

# This is the commit message #8:

init power manager script

# This is the commit message #9:

add go code

# This is the commit message #10:

test

# This is the commit message #11:

test

# This is the commit message #12:

test

# This is the commit message #13:

test

# This is the commit message #14:

go.sum

# This is the commit message #15:

go sum

# This is the commit message #16:

go mod tidy

# This is the commit message #17:

test

# This is the commit message #18:

test

# This is the commit message #19:

test

# This is the commit message #20:

test

# This is the commit message #21:

test

# This is the commit message #22:

test

# This is the commit message #23:

test

# This is the commit message #24:

test

# This is the commit message #25:

test

# This is the commit message #26:

test

# This is the commit message #27:

test

# This is the commit message #28:

test

# This is the commit message #29:

print output

# This is the commit message #30:

test

# This is the commit message #31:

test

# This is the commit message #32:

test

# This is the commit message #33:

test

# This is the commit message #34:

test

# This is the commit message #35:

test

# This is the commit message #36:

test

# This is the commit message #37:

test

# This is the commit message #38:

test

# This is the commit message #39:

test

# This is the commit message #40:

refactor

# This is the commit message #41:

change val

# This is the commit message #42:

test

# This is the commit message #43:

test

# This is the commit message #44:

test

# This is the commit message #45:

exp1

# This is the commit message #46:

add url

# This is the commit message #47:

test

# This is the commit message #48:

test

# This is the commit message #49:

test auth

# This is the commit message #50:

test

# This is the commit message #51:

test

# This is the commit message #52:

test

# This is the commit message #53:

test

# This is the commit message #54:

test

# This is the commit message #55:

fix bug

# This is the commit message #56:

remove log

# This is the commit message #57:

test

# This is the commit message #58:

test

# This is the commit message #59:

test

# This is the commit message #60:

fix loop

# This is the commit message #61:

increase invocation

# This is the commit message #62:

test

# This is the commit message #63:

test

# This is the commit message #64:

test

# This is the commit message #65:

test

# This is the commit message #66:

test

# This is the commit message #67:

test

# This is the commit message #68:

test

# This is the commit message #69:

Test

# This is the commit message #70:

test

# This is the commit message #71:

test

# This is the commit message #72:

test

# This is the commit message #73:

test

# This is the commit message #74:

test

# This is the commit message #75:

test

# This is the commit message #76:

test

# This is the commit message #77:

test

# This is the commit message #78:

test

# This is the commit message #79:

test

# This is the commit message #80:

test

# This is the commit message #81:

test

# This is the commit message #82:

test

# This is the commit message #83:

test

# This is the commit message #84:

test

# This is the commit message #85:

test

# This is the commit message #86:

test

# This is the commit message #87:

test

# This is the commit message #88:

test

# This is the commit message #89:

test

# This is the commit message #90:

test1

# This is the commit message #91:

test

# This is the commit message #92:

test

# This is the commit message #93:

test

# This is the commit message #94:

test

# This is the commit message #95:

test

# This is the commit message #96:

test

# This is the commit message #97:

test

# This is the commit message #98:

test

# This is the commit message #99:

test

# This is the commit message #100:

test

# This is the commit message #101:

test

# This is the commit message #102:

test

# This is the commit message #103:

test

# This is the commit message #104:

test

# This is the commit message #105:

test

# This is the commit message #106:

test

# This is the commit message #107:

test

# This is the commit message #108:

test

# This is the commit message #109:

test1

# This is the commit message #110:

test

# This is the commit message #111:

test

# This is the commit message #112:

Test

# This is the commit message #113:

test

# This is the commit message #114:

test

# This is the commit message #115:

test

# This is the commit message #116:

test

# This is the commit message #117:

test

# This is the commit message #118:

test

# This is the commit message #119:

Test

# This is the commit message #120:

Test

# This is the commit message #121:

test

# This is the commit message #122:

test

# This is the commit message #123:

Test

# This is the commit message #124:

test

# This is the commit message #125:

test

# This is the commit message #126:

test

# This is the commit message #127:

test

# This is the commit message #128:

test

# This is the commit message #129:

test

# This is the commit message #130:

test

# This is the commit message #131:

test

# This is the commit message #132:

test

# This is the commit message #133:

test

# This is the commit message #134:

test

# This is the commit message #135:

test

# This is the commit message #136:

test

# This is the commit message #137:

test

# This is the commit message #138:

test

# This is the commit message #139:

test

# This is the commit message #140:

test

# This is the commit message #141:

test

# This is the commit message #142:

test

# This is the commit message #143:

Test

# This is the commit message #144:

Test

# This is the commit message #145:

Test

# This is the commit message #146:

Test

# This is the commit message #147:

test

# This is the commit message #148:

test

# This is the commit message #149:

test

# This is the commit message #150:

test

# This is the commit message #151:

test

# This is the commit message #152:

test

# This is the commit message #153:

test

# This is the commit message #154:

Test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov requested changes

Assignees

@shyamjesal shyamjesal

Labels
None yet
Projects
None yet
Milestone
vHive CI
Development

Successfully merging this pull request may close these issues.
2 participants
@shyamjesal @ustiugov