chore(release): update musl armv6l, armv7l platform name to musllinux #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
requested changes
Jul 10, 2024
.github/workflows/release.yml
Outdated
| @@ -138,11 +138,11 @@ jobs: | |||
| image: ghcr.io/cross-rs/arm-unknown-linux-gnueabihf:main | |||
| runs-on: buildjet-4vcpu-ubuntu-2204 | |||
| - target: arm-unknown-linux-musleabihf | |||
| platform: linux_armv6l | |||
| platform: muslinux_armv6l | |||
There was a problem hiding this comment.
Can we add the second l here? musllinux pls
There was a problem hiding this comment.
(Because python likes the double l: https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/#musllinux)
.github/workflows/release.yml
Outdated
| image: ghcr.io/cross-rs/arm-unknown-linux-musleabihf:main | ||
| runs-on: buildjet-4vcpu-ubuntu-2204 | ||
| - target: armv7-unknown-linux-musleabihf | ||
| platform: linux_armv7l | ||
| platform: muslinux_armv7l |
HipsterBrown
force-pushed
the
nhehr/armv6l-build
branch
from
da30af2 to
6d26c6d
Compare
HipsterBrown
changed the title
njooma
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122 (comment)