chore(release): add ARM musl build targets #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplenicole730
approved these changes
Jul 3, 2024
njooma
reviewed
Jul 10, 2024
Comment on lines
147
to
+154
| - target: arm-unknown-linux-gnueabihf | ||
| platform: linux_armv6l | ||
| image: ghcr.io/cross-rs/arm-unknown-linux-gnueabihf:main | ||
| runs-on: buildjet-4vcpu-ubuntu-2204 | ||
| - target: arm-unknown-linux-musleabihf | ||
| platform: linux_armv6l | ||
| image: ghcr.io/cross-rs/arm-unknown-linux-musleabihf:main | ||
| runs-on: buildjet-4vcpu-ubuntu-2204 |
There was a problem hiding this comment.
@HipsterBrown This will actually cause a collision and only a single linux_armv6l build will be produced. The platform name must be different, and should probably be musllinux_armv6l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to add
muslsupport for aarch64/arm build targets to support in-progress Home Assistant core integration, which requires the Python SDK to run on more platforms. See #112 for more information.