Rework SyslogLogger to be thread-safe and ensure that loggers don't yield execution #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
force-pushed
the
issue176_async_logger
branch
2 times, most recently
from
468ab42
to
1207a05
Compare
l-kramer
approved these changes
Jul 27, 2024
s-ludwig
force-pushed
the
issue176_async_logger
branch
from
1207a05
to
781c892
Compare
Uses an asynchronous writer thread to write the log output and avoids any yielding within the thread/task that performs the logging call. Note that this change breaks the API to create a SyslogLogger instance, but since the previous implementation was so fundamentally broken, we can assume that nobody was using it.
Doing so would break fundamental assumptions about not yielding within low level code that might very well perform logging.
s-ludwig
force-pushed
the
issue176_async_logger
branch
from
781c892
to
1c3f85d
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #176