Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework SyslogLogger to be thread-safe and ensure that loggers don't yield execution #406

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Rework SyslogLogger to be thread-safe and ensure that loggers don't yield execution #406

merged 2 commits into from
Jul 27, 2024

Commits on Jul 27, 2024

  1. Fix SyslogLogger to be generally thread and task safe. See #176. 

    Uses an asynchronous writer thread to write the log output and avoids any yielding within the thread/task that performs the logging call.

Note that this change breaks the API to create a SyslogLogger instance, but since the previous implementation was so fundamentally broken, we can assume that nobody was using it.
    @s-ludwig
    s-ludwig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    a16f68f View commit details
    Browse the repository at this point in the history

  2. Ensure that loggers never yield when processing log data. 

    Doing so would break fundamental assumptions about not yielding within low level code that might very well perform logging.
    @s-ludwig
    s-ludwig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    1c3f85d View commit details
    Browse the repository at this point in the history