try to fix grpc

[victimsnino]

Summary by CodeRabbit

• Bug Fixes
  • Improved clarity in test assertions for asynchronous server results, enhancing readability without altering functionality.
  • Streamlined condition checks in the sendOk function for better maintainability and readability.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve modifications to the handling of results from the Finish() method in test cases of the asynchronous server, enhancing readability by using an intermediate variable. Additionally, the condition in the sendOk function of the reporter<specialized> class was simplified to improve clarity by directly evaluating pointer validity.

Changes

Files	Change Summary
src/tests/rppgrpc/test_async_server.cpp	Modified handling of Finish() method results for improved readability in test cases.
src/tests/utils/rpp_trompeloil.hpp	Simplified condition in sendOk function to directly check pointer validity instead of comparing to zero.

Poem

🐇
In the code where bunnies hop,
Clarity blooms, we can't stop!
With pointers checked, and tests refined,
Our logic shines, so well-defined.
Hooray for changes, bright and clear,
A joyful leap, let's all cheer!
🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6fd2da6 and 5f0640a.

Files selected for processing (2)

• src/tests/rppgrpc/test_async_server.cpp (3 hunks)
• src/tests/utils/rpp_trompeloil.hpp (1 hunks)

Files skipped from review due to trivial changes (1)

• src/tests/rppgrpc/test_async_server.cpp

Additional comments not posted (1)

src/tests/utils/rpp_trompeloil.hpp (1)

33-33: LGTM!

The change simplifies the condition by directly evaluating the truthiness of trompeloeil_mock_calls_done_correctly, which aligns with common practices in C++ for checking pointer validity. This improves readability and maintainability of the code.

[github-actions]

BENCHMARK RESULTS (AUTOGENERATED)

ci-ubuntu-gcc

General

name	rxcpp	rpp	prev rpp	ratio
Subscribe empty callbacks to empty observable	300.45 ns	2.19 ns	2.18 ns	1.01
Subscribe empty callbacks to empty observable via pipe operator	302.22 ns	2.16 ns	2.16 ns	1.00

Sources

name	rxcpp	rpp	prev rpp	ratio
from array of 1 - create + subscribe + immediate	687.31 ns	0.31 ns	0.31 ns	1.00
from array of 1 - create + subscribe + current_thread	1045.10 ns	3.70 ns	3.70 ns	1.00
concat_as_source of just(1 immediate) create + subscribe	2254.60 ns	101.73 ns	100.56 ns	1.01
defer from array of 1 - defer + create + subscribe + immediate	754.16 ns	0.31 ns	0.31 ns	1.00
interval - interval + take(3) + subscribe + immediate	2154.56 ns	59.23 ns	59.23 ns	1.00
interval - interval + take(3) + subscribe + current_thread	3067.88 ns	32.44 ns	32.43 ns	1.00
from array of 1 - create + as_blocking + subscribe + new_thread	27466.85 ns	28262.79 ns	28222.53 ns	1.00
from array of 1000 - create + as_blocking + subscribe + new_thread	37735.93 ns	51443.45 ns	49211.27 ns	1.05
concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe	3476.57 ns	179.67 ns	121.00 ns	1.48

Filtering Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+take(1)+subscribe	1054.82 ns	0.31 ns	0.31 ns	1.00
immediate_just+filter(true)+subscribe	824.47 ns	0.31 ns	0.31 ns	1.00
immediate_just(1,2)+skip(1)+subscribe	985.35 ns	0.31 ns	0.31 ns	1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe	858.55 ns	0.31 ns	0.31 ns	1.00
immediate_just(1,2)+first()+subscribe	1214.62 ns	0.62 ns	0.62 ns	1.00
immediate_just(1,2)+last()+subscribe	899.17 ns	0.31 ns	0.31 ns	1.00
immediate_just+take_last(1)+subscribe	1104.58 ns	17.60 ns	17.91 ns	0.98
immediate_just(1,2,3)+element_at(1)+subscribe	824.59 ns	0.31 ns	0.31 ns	0.99

Schedulers

name	rxcpp	rpp	prev rpp	ratio
immediate scheduler create worker + schedule	264.61 ns	2.16 ns	2.16 ns	1.00
current_thread scheduler create worker + schedule	367.60 ns	5.56 ns	5.56 ns	1.00
current_thread scheduler create worker + schedule + recursive schedule	823.16 ns	56.40 ns	56.68 ns	1.00

Transforming Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+map(v*2)+subscribe	841.15 ns	0.31 ns	0.31 ns	1.00
immediate_just+scan(10, std::plus)+subscribe	881.80 ns	0.31 ns	0.31 ns	1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe	2324.43 ns	167.44 ns	167.56 ns	1.00
immediate_just+buffer(2)+subscribe	1497.58 ns	13.91 ns	13.58 ns	1.02
immediate_just+window(2)+subscribe + subscsribe inner	2405.89 ns	1112.06 ns	1102.05 ns	1.01

Conditional Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+take_while(false)+subscribe	815.60 ns	-	-	0.00
immediate_just+take_while(true)+subscribe	844.08 ns	0.31 ns	0.31 ns	1.00

Utility Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just(1)+subscribe_on(immediate)+subscribe	1954.20 ns	0.31 ns	0.31 ns	1.00

Combining Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe	3384.26 ns	183.55 ns	174.45 ns	1.05
immediate_just(1) + merge_with(immediate_just(2)) + subscribe	3652.80 ns	182.63 ns	175.66 ns	1.04
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe	-	131.05 ns	141.55 ns	0.93
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe	3550.15 ns	961.32 ns	944.83 ns	1.02
immediate_just(1) + zip(immediate_just(2)) + subscribe	2113.19 ns	199.32 ns	203.09 ns	0.98

Subjects

name	rxcpp	rpp	prev rpp	ratio
publish_subject with 1 observer - on_next	34.62 ns	14.60 ns	14.59 ns	1.00
subscribe 100 observers to publish_subject	199495.00 ns	15649.03 ns	15502.24 ns	1.01
100 on_next to 100 observers to publish_subject	26952.14 ns	20243.49 ns	20231.98 ns	1.00

Scenarios

name	rxcpp	rpp	prev rpp	ratio
basic sample	1419.52 ns	13.91 ns	13.89 ns	1.00
basic sample with immediate scheduler	1404.24 ns	5.55 ns	5.55 ns	1.00

Aggregating Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+reduce(10, std::plus)+subscribe	897.88 ns	0.31 ns	0.31 ns	1.00

Error Handling Operators

name	rxcpp	rpp	prev rpp	ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe	2043.01 ns	995.15 ns	993.00 ns	1.00
create(on_error())+retry(1)+subscribe	604.50 ns	105.89 ns	108.14 ns	0.98

ci-macos

General

name	rxcpp	rpp	prev rpp	ratio
Subscribe empty callbacks to empty observable	1169.85 ns	4.96 ns	6.49 ns	0.76
Subscribe empty callbacks to empty observable via pipe operator	1238.56 ns	5.16 ns	5.23 ns	0.99

Sources

name	rxcpp	rpp	prev rpp	ratio
from array of 1 - create + subscribe + immediate	3235.27 ns	0.29 ns	0.30 ns	0.99
from array of 1 - create + subscribe + current_thread	3487.03 ns	38.20 ns	40.86 ns	0.93
concat_as_source of just(1 immediate) create + subscribe	6816.52 ns	479.98 ns	424.07 ns	1.13
defer from array of 1 - defer + create + subscribe + immediate	3172.66 ns	0.28 ns	0.35 ns	0.79
interval - interval + take(3) + subscribe + immediate	6288.06 ns	134.27 ns	145.53 ns	0.92
interval - interval + take(3) + subscribe + current_thread	8757.88 ns	122.55 ns	135.92 ns	0.90
from array of 1 - create + as_blocking + subscribe + new_thread	99849.27 ns	95809.60 ns	121325.50 ns	0.79
from array of 1000 - create + as_blocking + subscribe + new_thread	135357.62 ns	128971.25 ns	120692.62 ns	1.07
concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe	13606.75 ns	608.44 ns	500.59 ns	1.22

Filtering Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+take(1)+subscribe	3245.11 ns	0.27 ns	0.36 ns	0.74
immediate_just+filter(true)+subscribe	2407.64 ns	0.27 ns	0.65 ns	0.41
immediate_just(1,2)+skip(1)+subscribe	3171.02 ns	0.27 ns	0.30 ns	0.90
immediate_just(1,1,2)+distinct_until_changed()+subscribe	2368.53 ns	0.53 ns	0.75 ns	0.70
immediate_just(1,2)+first()+subscribe	3646.82 ns	0.27 ns	0.32 ns	0.82
immediate_just(1,2)+last()+subscribe	2741.14 ns	0.27 ns	0.30 ns	0.90
immediate_just+take_last(1)+subscribe	3471.50 ns	0.27 ns	0.35 ns	0.77
immediate_just(1,2,3)+element_at(1)+subscribe	2435.68 ns	0.27 ns	0.37 ns	0.73

Schedulers

name	rxcpp	rpp	prev rpp	ratio
immediate scheduler create worker + schedule	1086.90 ns	6.04 ns	8.42 ns	0.72
current_thread scheduler create worker + schedule	1803.88 ns	51.31 ns	47.03 ns	1.09
current_thread scheduler create worker + schedule + recursive schedule	3784.89 ns	352.00 ns	262.47 ns	1.34

Transforming Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+map(v*2)+subscribe	2882.40 ns	5.00 ns	6.19 ns	0.81
immediate_just+scan(10, std::plus)+subscribe	2680.64 ns	0.56 ns	1.07 ns	0.52
immediate_just+flat_map(immediate_just(v*2))+subscribe	6115.78 ns	460.44 ns	532.14 ns	0.87
immediate_just+buffer(2)+subscribe	2869.42 ns	71.69 ns	86.57 ns	0.83
immediate_just+window(2)+subscribe + subscsribe inner	6156.12 ns	2727.68 ns	3116.47 ns	0.88

Conditional Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+take_while(false)+subscribe	3472.50 ns	-	-	0.00
immediate_just+take_while(true)+subscribe	2652.46 ns	0.39 ns	0.61 ns	0.64

Utility Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just(1)+subscribe_on(immediate)+subscribe	5644.78 ns	5.56 ns	7.29 ns	0.76

Combining Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe	13287.67 ns	777.07 ns	805.41 ns	0.96
immediate_just(1) + merge_with(immediate_just(2)) + subscribe	13850.63 ns	814.50 ns	568.97 ns	1.43
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe	-	791.61 ns	847.87 ns	0.93
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe	12319.10 ns	2874.32 ns	3418.18 ns	0.84
immediate_just(1) + zip(immediate_just(2)) + subscribe	8382.11 ns	1454.34 ns	1657.85 ns	0.88

Subjects

name	rxcpp	rpp	prev rpp	ratio
publish_subject with 1 observer - on_next	85.42 ns	56.66 ns	72.69 ns	0.78
subscribe 100 observers to publish_subject	397018.67 ns	47179.86 ns	58600.17 ns	0.81
100 on_next to 100 observers to publish_subject	57896.21 ns	19838.33 ns	22818.83 ns	0.87

Scenarios

name	rxcpp	rpp	prev rpp	ratio
basic sample	3179.36 ns	71.72 ns	111.35 ns	0.64
basic sample with immediate scheduler	3192.10 ns	21.84 ns	32.82 ns	0.67

Aggregating Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+reduce(10, std::plus)+subscribe	2724.28 ns	0.27 ns	0.62 ns	0.43

Error Handling Operators

name	rxcpp	rpp	prev rpp	ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe	7521.97 ns	4788.24 ns	9318.59 ns	0.51
create(on_error())+retry(1)+subscribe	2096.69 ns	326.50 ns	364.62 ns	0.90

ci-ubuntu-clang

General

name	rxcpp	rpp	prev rpp	ratio
Subscribe empty callbacks to empty observable	268.06 ns	1.57 ns	1.56 ns	1.01
Subscribe empty callbacks to empty observable via pipe operator	274.30 ns	1.56 ns	1.54 ns	1.01

Sources

name	rxcpp	rpp	prev rpp	ratio
from array of 1 - create + subscribe + immediate	566.39 ns	0.31 ns	0.31 ns	1.00
from array of 1 - create + subscribe + current_thread	787.28 ns	4.33 ns	4.36 ns	0.99
concat_as_source of just(1 immediate) create + subscribe	2359.63 ns	129.77 ns	130.25 ns	1.00
defer from array of 1 - defer + create + subscribe + immediate	777.73 ns	0.31 ns	0.31 ns	1.00
interval - interval + take(3) + subscribe + immediate	2216.79 ns	58.30 ns	58.30 ns	1.00
interval - interval + take(3) + subscribe + current_thread	3159.74 ns	30.88 ns	30.88 ns	1.00
from array of 1 - create + as_blocking + subscribe + new_thread	28350.25 ns	27547.58 ns	28176.45 ns	0.98
from array of 1000 - create + as_blocking + subscribe + new_thread	39384.42 ns	35717.24 ns	37333.68 ns	0.96
concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe	3652.40 ns	150.52 ns	149.48 ns	1.01

Filtering Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+take(1)+subscribe	1164.35 ns	0.31 ns	0.31 ns	1.00
immediate_just+filter(true)+subscribe	850.57 ns	0.31 ns	0.31 ns	1.00
immediate_just(1,2)+skip(1)+subscribe	1076.94 ns	0.31 ns	0.31 ns	1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe	886.30 ns	0.62 ns	0.62 ns	1.00
immediate_just(1,2)+first()+subscribe	1372.80 ns	0.31 ns	0.31 ns	1.00
immediate_just(1,2)+last()+subscribe	1003.10 ns	0.31 ns	0.31 ns	1.00
immediate_just+take_last(1)+subscribe	1190.77 ns	0.31 ns	0.31 ns	1.00
immediate_just(1,2,3)+element_at(1)+subscribe	865.67 ns	0.31 ns	0.31 ns	1.00

Schedulers

name	rxcpp	rpp	prev rpp	ratio
immediate scheduler create worker + schedule	284.52 ns	1.56 ns	1.54 ns	1.01
current_thread scheduler create worker + schedule	390.53 ns	4.63 ns	4.78 ns	0.97
current_thread scheduler create worker + schedule + recursive schedule	856.42 ns	58.80 ns	56.33 ns	1.04

Transforming Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+map(v*2)+subscribe	848.82 ns	0.31 ns	0.31 ns	1.00
immediate_just+scan(10, std::plus)+subscribe	967.26 ns	0.31 ns	0.31 ns	1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe	2253.82 ns	137.14 ns	137.64 ns	1.00
immediate_just+buffer(2)+subscribe	1527.64 ns	14.20 ns	13.58 ns	1.05
immediate_just+window(2)+subscribe + subscsribe inner	2498.09 ns	935.97 ns	968.03 ns	0.97

Conditional Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+take_while(false)+subscribe	853.82 ns	-	-	0.00
immediate_just+take_while(true)+subscribe	847.57 ns	0.31 ns	0.31 ns	1.00

Utility Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just(1)+subscribe_on(immediate)+subscribe	2034.50 ns	0.31 ns	0.31 ns	1.00

Combining Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe	3263.24 ns	158.44 ns	158.44 ns	1.00
immediate_just(1) + merge_with(immediate_just(2)) + subscribe	3813.33 ns	148.89 ns	146.42 ns	1.02
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe	-	144.20 ns	145.20 ns	0.99
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe	3378.22 ns	844.11 ns	865.50 ns	0.98
immediate_just(1) + zip(immediate_just(2)) + subscribe	2239.28 ns	202.68 ns	200.26 ns	1.01

Subjects

name	rxcpp	rpp	prev rpp	ratio
publish_subject with 1 observer - on_next	54.26 ns	17.83 ns	17.68 ns	1.01
subscribe 100 observers to publish_subject	211399.40 ns	16019.50 ns	16092.61 ns	1.00
100 on_next to 100 observers to publish_subject	42683.93 ns	17452.15 ns	20491.95 ns	0.85

Scenarios

name	rxcpp	rpp	prev rpp	ratio
basic sample	1318.51 ns	12.05 ns	12.04 ns	1.00
basic sample with immediate scheduler	1292.67 ns	5.86 ns	5.86 ns	1.00

Aggregating Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+reduce(10, std::plus)+subscribe	998.70 ns	0.31 ns	0.31 ns	1.00

Error Handling Operators

name	rxcpp	rpp	prev rpp	ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe	2189.86 ns	1259.36 ns	1242.86 ns	1.01
create(on_error())+retry(1)+subscribe	648.60 ns	138.26 ns	138.63 ns	1.00

ci-windows

General

name	rxcpp	rpp	prev rpp	ratio
Subscribe empty callbacks to empty observable	585.98 ns	4.32 ns	4.32 ns	1.00
Subscribe empty callbacks to empty observable via pipe operator	588.71 ns	4.32 ns	4.32 ns	1.00

Sources

name	rxcpp	rpp	prev rpp	ratio
from array of 1 - create + subscribe + immediate	1158.06 ns	9.63 ns	9.64 ns	1.00
from array of 1 - create + subscribe + current_thread	1445.95 ns	17.96 ns	17.90 ns	1.00
concat_as_source of just(1 immediate) create + subscribe	3759.12 ns	190.89 ns	188.89 ns	1.01
defer from array of 1 - defer + create + subscribe + immediate	1203.24 ns	9.41 ns	9.41 ns	1.00
interval - interval + take(3) + subscribe + immediate	3125.46 ns	145.26 ns	145.23 ns	1.00
interval - interval + take(3) + subscribe + current_thread	3439.35 ns	67.80 ns	64.77 ns	1.05
from array of 1 - create + as_blocking + subscribe + new_thread	120850.00 ns	113230.00 ns	114800.00 ns	0.99
from array of 1000 - create + as_blocking + subscribe + new_thread	128362.50 ns	132566.67 ns	130937.50 ns	1.01
concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe	5382.56 ns	227.55 ns	212.61 ns	1.07

Filtering Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+take(1)+subscribe	1819.68 ns	25.28 ns	25.29 ns	1.00
immediate_just+filter(true)+subscribe	1325.79 ns	24.35 ns	24.36 ns	1.00
immediate_just(1,2)+skip(1)+subscribe	2000.19 ns	24.06 ns	24.07 ns	1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe	1370.06 ns	28.99 ns	28.99 ns	1.00
immediate_just(1,2)+first()+subscribe	2381.44 ns	22.82 ns	22.82 ns	1.00
immediate_just(1,2)+last()+subscribe	1804.49 ns	24.06 ns	24.06 ns	1.00
immediate_just+take_last(1)+subscribe	2018.95 ns	70.00 ns	69.59 ns	1.01
immediate_just(1,2,3)+element_at(1)+subscribe	1360.97 ns	27.45 ns	27.44 ns	1.00

Schedulers

name	rxcpp	rpp	prev rpp	ratio
immediate scheduler create worker + schedule	475.08 ns	6.17 ns	6.17 ns	1.00
current_thread scheduler create worker + schedule	652.51 ns	14.10 ns	14.08 ns	1.00
current_thread scheduler create worker + schedule + recursive schedule	1349.47 ns	111.15 ns	105.75 ns	1.05

Transforming Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+map(v*2)+subscribe	1303.69 ns	24.35 ns	24.37 ns	1.00
immediate_just+scan(10, std::plus)+subscribe	1420.03 ns	26.82 ns	26.82 ns	1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe	3469.77 ns	209.26 ns	206.57 ns	1.01
immediate_just+buffer(2)+subscribe	2614.21 ns	68.47 ns	68.49 ns	1.00
immediate_just+window(2)+subscribe + subscsribe inner	4043.31 ns	1297.63 ns	1318.74 ns	0.98

Conditional Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+take_while(false)+subscribe	1312.80 ns	23.12 ns	23.12 ns	1.00
immediate_just+take_while(true)+subscribe	1322.24 ns	24.36 ns	24.36 ns	1.00

Utility Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just(1)+subscribe_on(immediate)+subscribe	3464.46 ns	11.10 ns	11.10 ns	1.00

Combining Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe	5114.06 ns	224.89 ns	222.77 ns	1.01
immediate_just(1) + merge_with(immediate_just(2)) + subscribe	5472.40 ns	213.19 ns	208.87 ns	1.02
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe	-	198.14 ns	193.87 ns	1.02
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe	5449.77 ns	945.58 ns	936.70 ns	1.01
immediate_just(1) + zip(immediate_just(2)) + subscribe	3595.88 ns	515.68 ns	506.33 ns	1.02

Subjects

name	rxcpp	rpp	prev rpp	ratio
publish_subject with 1 observer - on_next	37.26 ns	20.04 ns	20.35 ns	0.98
subscribe 100 observers to publish_subject	271575.00 ns	27410.53 ns	30703.03 ns	0.89
100 on_next to 100 observers to publish_subject	51755.00 ns	38746.43 ns	38783.33 ns	1.00

Scenarios

name	rxcpp	rpp	prev rpp	ratio
basic sample	1884.42 ns	102.59 ns	101.40 ns	1.01
basic sample with immediate scheduler	1888.05 ns	74.61 ns	74.57 ns	1.00

Aggregating Operators

name	rxcpp	rpp	prev rpp	ratio
immediate_just+reduce(10, std::plus)+subscribe	1464.11 ns	24.97 ns	24.97 ns	1.00

Error Handling Operators

name	rxcpp	rpp	prev rpp	ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe	2184.50 ns	362.56 ns	350.21 ns	1.04
create(on_error())+retry(1)+subscribe	1164.88 ns	141.32 ns	143.31 ns	0.99

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (f086bb9) to head (5f0640a).
Report is 2 commits behind head on v2.

Additional details and impacted files

@@           Coverage Diff           @@
##               v2     #637   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files          98       98           
  Lines        1897     1897           
=======================================
  Hits         1814     1814           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud