Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix grpc #637

Merged
merged 1 commit into from
Sep 4, 2024
Merged

try to fix grpc #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/tests/rppgrpc/test_async_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ TEST_CASE("Async server")
if constexpr (requires { reactor->get_observer(); })
reactor->get_observer().on_completed();

CHECK(writer->Finish().ok());
const auto res = writer->Finish().ok();
CHECK(res);
wait(last);
}

Expand Down Expand Up @@ -92,7 +93,8 @@ TEST_CASE("Async server")
if constexpr (requires { reactor->get_observer(); })
reactor->get_observer().on_completed();

REQUIRE(writer->Finish().ok());
const auto res = writer->Finish().ok();
REQUIRE(res);

wait(last);
}
Expand All @@ -119,7 +121,8 @@ TEST_CASE("Async server")
REQUIRE(response.value() == i);
}
REQUIRE(!writer->Read(&response));
REQUIRE(writer->Finish().ok());
const auto res = writer->Finish().ok();
REQUIRE(res);
wait(last);
}
};
Expand Down
2 changes: 1 addition & 1 deletion src/tests/utils/rpp_trompeloil.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ namespace trompeloeil
inline void reporter<specialized>::sendOk(
const char* trompeloeil_mock_calls_done_correctly)
{
REQUIRE(trompeloeil_mock_calls_done_correctly != 0);
REQUIRE(trompeloeil_mock_calls_done_correctly);
}
} // namespace trompeloeil

Expand Down
Loading