-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeking breaks stream with DISCONTINUITY #4905
Comments
Hi @periman2, Can you provide a screen capture with voice over or comments with timestamps that point to the issue you are seeing? I am able to play the stream in backwards seeking increments. The media is loaded and appended as expected. Your logs also indicate hls.js is behaving as expected. I do not see lag or breaking of the stream other than the time needed to retrieve and append segments from the HLS stream provided. |
Hello @robwalch . I'd like to first thank you for the fast response! I'm sorry about the logs, github asked me to lower the data of the issue's submition and I accidentaly cut the logs that displayed the problem. I also failed to mention that you need to be quite agressive with the seeking in order for the issue to be reproduced. This is however related to a feature I'm trying to create, in my app I'm not doing the seeking by hand of course but sadly it does break the whole stream afterwards. I'm sending you now the screen capture reproduction as you asked. I hope this helps to show the issue more clearly. |
Hello again. We re-encoded the streams and reset the pts in order to remove the DISCONTINUITY tag. This way the new streams we make work perfectly well. However, I believe this is a bug on hls.js side still so I think it's best to leave that issue open since it has technically not being resolved for streams with DISCONTINUITY and more people might have this issue. The stream in the issue will stay online for a very long time in order for the team here to debug and perhaps resolve the issue. |
Thanks @periman2, From the screen capture it looks like while we produce a seamless buffer, video is frozen while playing over one of the appends. This suggests that we appended over a keyframe, or did not aligns appends across discontinuities (when appending backwards) in such a way that preserved the decode timeline. |
We can look into flushing forward media when seeking back into a previously unparsed Discontinuity domain or sequence. |
This issue should be resolved in v1.6.0 with #6524. You can try it here https://bugfix-backward-seek-near-en.hls-js-4zn.pages.dev/demo/ |
What version of Hls.js are you using?
1.2.3
What browser (including version) are you using?
Chrome 105.0.5195.102 (Official Build) (64-bit)
What OS (including version) are you using?
Windows 10
Test stream
https://pz-73dff7e9-79c9-e911-bcd0-0003ff297dea.vitrinabox.com/vvpvideo-d26d4978-0834-ed11-ae83-281878660f2f/74dff7e9-79c9-e911-bcd0-0003ff297dea/r.m3u8?sv=2018-03-28&si=23e4f150-6d3c-4d30-95ad-b72a32715bed&sr=c&sig=G7HkpkIjWd%2F%2F%2BRfpBLDpmoUvqrcUZGBCJdsE8AgoLH4%3D
Configuration
Additional player setup steps
No response
Checklist
Steps to reproduce
Expected behaviour
Playback after seeking should move smoothly
What actually happened?
Playback lags significantly in the segments that it was seeked to.
Console output
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: