Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paused and backward seeking enhancement #6524

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jun 28, 2024

This PR will...

Use strict tolerance when picking fragments when paused and seeking backward.

Why is this Pull Request needed?

Support seeking back step-by-step without requiring additional configuration that sacrifices performance when seeking forward while playing.

Are there any points in the code the reviewer needs to double check?

This cannot address rendering of buffered media near an unbuffered playhead or rendering subsequently buffered media while paused. I consider these MSE flaws that HLS.js cannot or should not workaround (at least not with this change). For more detail see #6511 (comment).

Does anyone question whether this enhancement should only apply when media is paused (and not when seeking backwards)? When not paused the max frag lookup and buffer hole tolerances allow skipping loading of a whole segment that would only contribute to playback for a small fraction of time. In those cases this could cause more stalls when seeking back near a segment boundary. External pausing and unpausing while seeking could also impact performance in similar ways, so voice you concern if you'd like additional settings to fine-tune this behavior.

Resolves issues:

Resolves #6511 #6331 #4905
Closes #4884

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch merged commit 0839578 into master Jul 1, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/backward-seek-near-end-of-segment branch July 1, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants