Paused and backward seeking enhancement #6524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Use strict tolerance when picking fragments when paused and seeking backward.
Why is this Pull Request needed?
Support seeking back step-by-step without requiring additional configuration that sacrifices performance when seeking forward while playing.
Are there any points in the code the reviewer needs to double check?
This cannot address rendering of buffered media near an unbuffered playhead or rendering subsequently buffered media while paused. I consider these MSE flaws that HLS.js cannot or should not workaround (at least not with this change). For more detail see #6511 (comment).
Does anyone question whether this enhancement should only apply when media is paused (and not when seeking backwards)? When not paused the max frag lookup and buffer hole tolerances allow skipping loading of a whole segment that would only contribute to playback for a small fraction of time. In those cases this could cause more stalls when seeking back near a segment boundary. External pausing and unpausing while seeking could also impact performance in similar ways, so voice you concern if you'd like additional settings to fine-tune this behavior.
Resolves issues:
Resolves #6511 #6331 #4905
Closes #4884
Checklist