-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP4 Sample Description CODEC Parsing #5528
Conversation
Hi @jprjr @uvjustin @fogarasyroland, Thank you for your contributions in this area. Let me know if you have any feedback, as well as if these changes impact playback of content used in testing and development on your end. |
5aa0e04
to
b8d101f
Compare
…dec passthrough Update contributed mp4a, avc, and hevc mp4 "stsd" codec parsing Clean up mp4 init segment track parsed codec handling Clean up SourceBuffer `changeType` detection and appends
b8d101f
to
d8c6c7a
Compare
Shouldn't (Sorry for commenting on a merged PR. I don't have a test stream to justify opening an issue) |
Hi @zemlanin, You can choose to file a Feature Request or Question rather than commenting on closed PR/Issues: https://github.com/video-dev/hls.js/issues/new/choose The Related to this, #5847 has implemented an |
The code in this PR is for those init segments codec checks to be performed correctly, while |
The codec check kinda blocks Firefox-without-H.264 from using HLS.js. Either extending the check or removing it might help with that |
Please file a new issue. Suggesting what baseline mime-type to check for Firefox so that HLS.js requires at least one supported type or suggesting that we remove the AVC type check may be considered. |
This PR will...
changeType
detection and appendsWhy is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
These changes do not include parsing channel count for mp4a/AAC audio. Attempting to append multi-channel AAC with MSE fails in Chrome #5162 https://bugs.chromium.org/p/chromium/issues/detail?id=241171
Resolves issues:
Resolves #4744
Related issues:
Related to #5378
Related to #5162
Checklist