Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP4 Sample Description CODEC Parsing #5528

Merged
merged 1 commit into from
Jun 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/controller/audio-stream-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,12 @@ class AudioStreamController

if (initSegment?.tracks) {
const mapFragment = frag.initSegment || frag;
this._bufferInitSegment(initSegment.tracks, mapFragment, chunkMeta);
this._bufferInitSegment(
level,
initSegment.tracks,
mapFragment,
chunkMeta
);
hls.trigger(Events.FRAG_PARSING_INIT_SEGMENT, {
frag: mapFragment,
id,
Expand Down Expand Up @@ -830,6 +835,7 @@ class AudioStreamController
}

private _bufferInitSegment(
currentLevel: Level,
tracks: TrackSet,
frag: Fragment,
chunkMeta: ChunkMetadata
Expand All @@ -848,11 +854,16 @@ class AudioStreamController
return;
}

track.levelCodec = track.codec;
track.id = 'audio';

const variantAudioCodecs = currentLevel.audioCodec;
this.log(
`Init audio buffer, container:${track.container}, codecs[parsed]=[${track.codec}]`
`Init audio buffer, container:${track.container}, codecs[level/parsed]=[${variantAudioCodecs}/${track.codec}]`
);
// SourceBuffer will use track.levelCodec if defined
if (variantAudioCodecs && variantAudioCodecs.split(',').length === 1) {
track.levelCodec = variantAudioCodecs;
}
this.hls.trigger(Events.BUFFER_CODECS, tracks);
const initSegment = track.initSegment;
if (initSegment?.byteLength) {
Expand Down
7 changes: 4 additions & 3 deletions src/controller/buffer-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ import type Hls from '../hls';
import type { LevelDetails } from '../loader/level-details';

const MediaSource = getMediaSource();
const VIDEO_CODEC_PROFILE_REPACE = /([ha]vc.)(?:\.[^.,]+)+/;
const VIDEO_CODEC_PROFILE_REPLACE =
/(avc[1234]|hvc1|hev1|dvh[1e]|vp09|av01)(?:\.[^.,]+)+/;

export default class BufferController implements ComponentAPI {
// The level details used to determine duration, target-duration and live
Expand Down Expand Up @@ -261,11 +262,11 @@ export default class BufferController implements ComponentAPI {
const { id, codec, levelCodec, container, metadata } =
data[trackName];
const currentCodec = (track.levelCodec || track.codec).replace(
VIDEO_CODEC_PROFILE_REPACE,
VIDEO_CODEC_PROFILE_REPLACE,
'$1'
);
const nextCodec = (levelCodec || codec).replace(
VIDEO_CODEC_PROFILE_REPACE,
VIDEO_CODEC_PROFILE_REPLACE,
'$1'
);
if (currentCodec !== nextCodec) {
Expand Down
2 changes: 1 addition & 1 deletion src/controller/error-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ export default class ErrorController implements NetworkComponentAPI {
const { hls, penalizedRenditions } = this;
const levelIndex: number =
data.parent === PlaylistLevelType.MAIN
? (data.level as number)
? (data.level as number) || 0
: hls.loadLevel;
const level = hls.levels[levelIndex];
const redundantLevels = level.url.length;
Expand Down
29 changes: 19 additions & 10 deletions src/remux/passthrough-remuxer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ class PassThroughRemuxer implements Remuxer {
const initData = (this.initData = parseInitSegment(initSegment));

// Get codec from initSegment or fallback to default
if (!audioCodec) {
if (initData.audio) {
audioCodec = getParsedTrackCodec(
initData.audio,
ElementaryStreamTypes.AUDIO
);
}

if (!videoCodec) {
if (initData.video) {
videoCodec = getParsedTrackCodec(
initData.video,
ElementaryStreamTypes.VIDEO
Expand Down Expand Up @@ -263,27 +263,36 @@ function isInvalidInitPts(
}

function getParsedTrackCodec(
track: InitDataTrack | undefined,
track: InitDataTrack,
type: ElementaryStreamTypes.AUDIO | ElementaryStreamTypes.VIDEO
): string {
const parsedCodec = track?.codec;
if (parsedCodec && parsedCodec.length > 4) {
return parsedCodec;
}
if (type === ElementaryStreamTypes.AUDIO) {
if (
parsedCodec === 'ec-3' ||
parsedCodec === 'ac-3' ||
parsedCodec === 'alac'
) {
return parsedCodec;
}
if (parsedCodec === 'fLaC' || parsedCodec === 'Opus') {
return getCodecCompatibleName(parsedCodec);
}
logger.warn(`Unhandled audio codec "${parsedCodec}" or audio object type`);
return 'mp4a.40.5';
}
// Provide defaults based on codec type
// This allows for some playback of some fmp4 playlists without CODECS defined in manifest
logger.warn(`Unhandled video codec "${parsedCodec}"`);
if (parsedCodec === 'hvc1' || parsedCodec === 'hev1') {
return 'hvc1.1.6.L120.90';
}
if (parsedCodec === 'av01') {
return 'av01.0.04M.08';
}
if (parsedCodec === 'avc1' || type === ElementaryStreamTypes.VIDEO) {
return 'avc1.42e01e';
}
if (parsedCodec === 'fLaC' || parsedCodec === 'Opus') {
return getCodecCompatibleName(parsedCodec);
}
return 'mp4a.40.5';
return 'avc1.42e01e';
}
export default PassThroughRemuxer;
Loading