Deprecate options #2229
Closed
Deprecate options #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed issue with playbackRates option getter
| @@ -186,6 +186,8 @@ class Component { | |||
| * @return {Object} A NEW object of this.options_ and obj merged | |||
| */ | |||
| options(obj) { | |||
| log.warn('this.options() has been deprecated and will be moved to the constructor in 6.0'); | |||
There was a problem hiding this comment.
We might want to consider bringing in util-deprecate so warnings are only logged once. Not required for this PR.
| @@ -76,11 +77,15 @@ class PlaybackRateMenuButton extends MenuButton { | |||
| this.player().playbackRate(newRate); | |||
| } | |||
|
|
|||
| playbackRates() { | |||
| return (this.options_.playerOptions && this.options_.playerOptions['playbackRates']) || this.options_['playbackRates']; | |||
|
A few small notes but this looks good to me. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component#options()parentOptionsparentOptionsfromthis.options_throughout tests / code base