Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate options #2229

Closed
wants to merge 7 commits into from
Closed

Deprecate options #2229

wants to merge 7 commits into from

Commits on Jun 3, 2015

  1. added deprecation warning to component.options() and removed getter r… 

    …eferences
    @mmcc
    mmcc committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    625ac0a View commit details
    Browse the repository at this point in the history

  2. switched over to adding playerOptions to child options objects 

    fixed issue with playbackRates option getter
    @mmcc
    mmcc committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    c8a9a54 View commit details
    Browse the repository at this point in the history

  3. removed all options() calls from test suite

    @mmcc
    mmcc committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    ff6673d View commit details
    Browse the repository at this point in the history

  4. merge with an empty object for clarity

    @mmcc
    mmcc committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    cddcaf5 View commit details
    Browse the repository at this point in the history

  5. Fixed broken return statement

    @mmcc
    mmcc committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    cd3c6de View commit details
    Browse the repository at this point in the history

  6. check for undefined options.persistTextTrackSettings

    @mmcc
    mmcc committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    00e8d98 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2015

  1. Ensure component options get priority and pass playerOptionsCopy to p… 

    …lugins
    @mmcc
    mmcc committed Jun 4, 2015
    Configuration menu
    Copy the full SHA
    e2dbf44 View commit details
    Browse the repository at this point in the history