videojs-standard #3459

misteroneill · 2016-07-25T14:46:32Z

Description

As discussed in-person on Thursday, we are in a slight lull at the moment and this is a great opportunity to clean up the video.js source code (and tests) to pass videojs-standard linting and abandon jshint.

Specific Changes proposed

Removes jshint
Installs videojs-standard at 5.x
Adds linting scripts/tasks
Makes small code changes to address videojs-standard checks against src/js/*.js

Requirements Checklist

Feature implemented / Bug fixed
Reviewed by Two Core Contributors

misteroneill · 2016-07-25T14:47:20Z

build/grunt.js

@@ -114,14 +114,6 @@ module.exports = function(grunt) {
      build: ['build/temp/*'],
      dist: ['dist/*']
    },
-    jshint: {


This is a temporary step. The final PR in this series will restore automatic linting capabilities, but for now we want them off.

misteroneill · 2016-07-25T14:56:08Z

src/js/button.js

@@ -3,10 +3,7 @@
 */
 import ClickableComponent from './clickable-component.js';
 import Component from './component';
-import * as Events from './utils/events.js';


There are removals like this scattered around: they were unused modules.

Note: if we're only trying to import the module, we should be doing something like import './utils/events'.

doesn't import './utils/events.js' put the exports into local scope? This is an issue for a "bag of functions" module.
import * Events from './utils/events.js' is more explicit in what we want.

I tend to agree, but the linter doesn't like unused variable names.

if it isn't used then we shouldn't import it, sure.

On the topic of using the import 'foo'; style, I don't think it puts the exports into local scope. I think it simply runs the module code. MDN says:

Import an entire module for side effects only, without importing any bindings.

Same as require('foo.js');

Ah, interesting. I guess that's exactly what we want in player.js.

gkatsev · 2016-07-25T17:12:15Z

LGTM

gkatsev · 2016-07-26T18:28:19Z

src/js/media-error.js

@@ -8,13 +8,13 @@ import assign from 'object.assign';
 *
 * @param {Number} code The media error code
 */
-let MediaError = function(code){
+let MediaError = function(code) {


noting it here (but we shouldn't make this change as part of linting) but this potentially can cause a problem on IE8 since on line 22 we do MediaError.defaultMessages and IE8 is weird.

Good catch. Switching to function MediaError(code) { would solve that, right?

misteroneill · 2016-07-28T19:36:30Z

I merged all the disparate vjsstandard-* branches into this one.

misteroneill · 2016-08-01T16:03:22Z

We are treating this as the "master" branch for standardization efforts.

gkatsev · 2016-08-05T15:43:11Z

Landed!

misteroneill reviewed Jul 25, 2016
View reviewed changes

misteroneill force-pushed the vjsstandard-core branch from 88402d9 to 2da6634 Compare July 25, 2016 14:55

misteroneill reviewed Jul 25, 2016
View reviewed changes

gkatsev added confirmed patch This PR can be added to a patch release. labels Jul 25, 2016

gkatsev added this to the Linting milestone Jul 25, 2016

misteroneill mentioned this pull request Jul 25, 2016

src/js/utils passing videojs-standard #3460

Closed

2 tasks

gkatsev reviewed Jul 26, 2016
View reviewed changes

gkatsev added minor This PR can be added to a minor release. It should not be added to a patch release. and removed patch This PR can be added to a patch release. confirmed labels Jul 26, 2016

misteroneill changed the title ~~videojs-standard Core~~ videojs-standard Source Code Jul 28, 2016

misteroneill changed the title ~~videojs-standard Source Code~~ videojs-standard Aug 1, 2016

misteroneill force-pushed the vjsstandard-core branch from deddb6b to caf614e Compare August 3, 2016 19:20

misteroneill and others added 6 commits August 3, 2016 15:31

video.js source code passing videojs-standard v5

d9deaf1

vjsstandard - Tests - Bottom half of test/unit (videojs#3477)

0bea95a

vjsstandard - Tests - Other 1/2 of Tracks folder + Misc (videojs#3484)

6fcee09

vjsstandard - Tests - Utils folder (videojs#3482)

5a5ef4b

vjsstandard - Tests - Tech folder (videojs#3479)

ae2ab52

Linter v5 Compatibility (videojs#3478)

99724c6

misteroneill force-pushed the vjsstandard-core branch from 20867da to 99724c6 Compare August 3, 2016 19:31

Priti Agarwal and others added 3 commits August 4, 2016 11:49

Unit test linting (videojs#3490)

d71d8d1

Add ghooks to lint on push

a16d710

vjsstandard - Tests - one missed file (videojs#3497)

12a72f7

gkatsev closed this in 4f6cb03 Aug 5, 2016

misteroneill deleted the vjsstandard-core branch August 12, 2016 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

videojs-standard #3459

videojs-standard #3459

misteroneill commented Jul 25, 2016 •

edited

Loading

misteroneill Jul 25, 2016

misteroneill Jul 25, 2016

gkatsev Jul 25, 2016

misteroneill Jul 25, 2016

gkatsev Jul 25, 2016

misteroneill Jul 25, 2016

misteroneill Jul 25, 2016

gkatsev Jul 25, 2016

gkatsev commented Jul 25, 2016

gkatsev Jul 26, 2016

misteroneill Jul 26, 2016

gkatsev Jul 26, 2016

misteroneill commented Jul 28, 2016

misteroneill commented Aug 1, 2016

gkatsev commented Aug 5, 2016

videojs-standard #3459

videojs-standard #3459

Conversation

misteroneill commented Jul 25, 2016 • edited Loading

Description

Specific Changes proposed

Requirements Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gkatsev commented Jul 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

misteroneill commented Jul 28, 2016

misteroneill commented Aug 1, 2016

gkatsev commented Aug 5, 2016

misteroneill commented Jul 25, 2016 •

edited

Loading