feat: generalization around fetching data #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added value: 1. if the use wants to define something else than `title`, they don't need us to extend the `passToClient` list anymore. 2. return types for onBeforeRender() 3. comments
|
Blocker: #4. |
Fix released in Btw. I've been thinking a bit about this, and I think the best would be a new hook |
|
Most of this isn't needed anymore thanks to #4, closing. I might create another tiny PR containing the other minor useful bits that were in this PR. |
lourot
added a commit
that referenced
this pull request
Sep 21, 2023
Added useful types and comments. Spin-off of #10
lourot
added a commit
that referenced
this pull request
Oct 23, 2023
Added useful types and comments. Spin-off of #10
brillout
pushed a commit
that referenced
this pull request
Oct 23, 2023
Added useful types and comments. Spin-off of #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added value:
title, they don't need us to extend thepassToClientlist anymore.onBeforeRender()