Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qual: improvements around getTitle #20

Merged
merged 1 commit into from
Oct 23, 2023
Merged

qual: improvements around getTitle #20

merged 1 commit into from
Oct 23, 2023

Conversation

lourot
Copy link
Contributor

@lourot lourot commented Sep 21, 2023

Added useful types and comments.
Spin-off of #10

@lourot lourot marked this pull request as draft September 21, 2023 18:17
@lourot
Copy link
Contributor Author

lourot commented Sep 21, 2023 •
edited
Loading

To be reworked after vikejs/vike#1137 . Also as discussed with @brillout, I should make sure that comments in examples/ don't refer to internals of vike-react

@lourot
Copy link
Contributor Author

lourot commented Oct 13, 2023

vikejs/vike#1137 has landed, waiting for it to be released (as >= 0.4.144) before reviving this

@lourot
qual: improvements around getTitle
8548985 
Added useful types and comments.
Spin-off of #10
@lourot lourot force-pushed the quality/gettitle-improvements branch from 5149b78 to 8548985 Compare October 23, 2023 13:55
@lourot lourot marked this pull request as ready for review October 23, 2023 13:55
@lourot
Copy link
Contributor Author

lourot commented Oct 23, 2023

@brillout I'm happy with this now :)

@brillout
Copy link
Member

So cool we're circling back on this with our new shiny hook types.

@brillout brillout merged commit 246b6bb into main Oct 23, 2023
6 checks passed
@lourot lourot deleted the quality/gettitle-improvements branch October 24, 2023 08:32
@lourot lourot mentioned this pull request Oct 24, 2023
Merged
lourot added a commit to vikejs/vike-vue that referenced this pull request Oct 24, 2023
@lourot
qual: improvements around getTitle
1557fee 
Similar to:
* vikejs/vike-react#20
* vikejs/vike-solid#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lourot @brillout