Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit fa3911e changes how base16_gruvbox_dark_hard is loaded #250

Closed
happy-dude opened this issue Apr 15, 2021 · 3 comments
Closed

commit fa3911e changes how base16_gruvbox_dark_hard is loaded #250

happy-dude opened this issue Apr 15, 2021 · 3 comments

Comments

@happy-dude
Copy link
Contributor

happy-dude commented Apr 15, 2021

Hey team, just started up neo/vim and realized that the airline theme was loaded differently.
Checked to see what the cause may be and found that commit fa3911e was merged in.

Unfortunately I'm not too knowledgeable about vim-theming, but I hope the following info + screenshots can help.

environment

  • vim: vim 8.2.2756 (installed via Homebrew), neovim v0.5.0-dev+nightly-631-gd19348923 (installed via Homebrew, following HEAD)
  • vim-airline: commits fa808d7 (expected behavior), fa3911e (new behavior)
  • colorscheme: base16_gruvbox_dark_hard
  • OS: macOS Catalina 10.15.7
  • Have you reproduced with a minimal vimrc: No (please let me know if requested)
  • What is your airline configuration: from my dotfiles repo

if you are using terminal:

  • terminal: occurs in both Alacritty and iTerm
  • $TERM variable: tmux-256color (in Alacritty), xterm-256color (in iTerm)
  • color configuration (:set t_Co?): t_Co = 256 (in vim); neovim not set

if you are using Neovim:

  • does it happen in Vim: yes, occurs in both vim + neovim

actual behavior

Screen Shot 2021-04-15 at 10 34 20 AM

expected behavior

Screen Shot 2021-04-15 at 10 30 28 AM

screen shot (if possible)

Please see above

@happy-dude happy-dude changed the title commit fa3911ebbdf80a88dcab7c948de33865c8b161ed changes how base16_gruvbox_dark_hard is loaded commit fa3911e changes how base16_gruvbox_dark_hard is loaded Apr 15, 2021
@happy-dude
Copy link
Contributor Author

I don't think the it quite fixed yet; can we reopen and investigate further?

Screen Shot 2021-04-15 at 12 00 43 PM

@chrisbra
Copy link
Member

chrisbra commented Apr 15, 2021 via email

@happy-dude
Copy link
Contributor Author

I gave a shot at fixing it re: https://github.com/vim-airline/vim-airline-themes/pull/251/files

Feel free to make suggestions/edits!

chrisbra added a commit that referenced this issue Apr 16, 2021
Fix #250: Move color palette definitions in if-block for old base16_gruvbox_dark_hard
taigrr pushed a commit to taigrr/vim-airline-themes that referenced this issue Sep 23, 2021
Set
    let g:airline_base16_gruvbox_dark_hard_old = 1

to allow the old base16_gruvbox_dark_hard style again.

closes vim-airline#250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants