-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base16 themes are almost all the same #252
Comments
yeah, my gruvbox theme transformed into a black/white theme: |
There was a similar issue with #250 It's worth pinging @ShiromMakkad to see how the color schemes were changed and how they were validated as correct or still working in #244 If the code isn't easy to fix, then perhaps it's worth rolling the commit back and cherry-picking the ones that are still working as intended? |
okay, we just may need to revert that PR #244 |
Please, I am begging you to do so ^_^ |
@Felixoid What happens if you set the following: |
After update, the 'base16_gruvbox_dark_hard' theme is not working properly. Seeing that the 'red' color looks like the 'original red', it seems that the color values aren't being reflected properly. Sorry for not providing detailed information. : ( |
The same is happening with base16_monokai. |
@justinpage hello. I am not sure what do you mean by "colors I expect". I don't use the scheme. But it looks definitely different compared to working commit Can you, maybe, consider reverting #244 and make a proper update lately? The current state looks very wrong to me |
Also would support reverting. My themes have gone from left to right since recent updates: None of the base16 themes seem to change from this new washed out normal mode. Possibly not the best place to ask, but what I've never understood is why all the different base16 themes are needed. Can't you just set the base16 scheme in your terminal app, and then vim outputs the same ANSI escape codes for every base16 colour scheme? So all that would be required here is the different airline modes like Tmuxline's airline, airline_insert, airline_visual themes? |
Okay, if I haven't done anything wrong, it should be reverted now. I don't know how to revert in git very well, so I hope I did not brake too much :/ |
There is a bigger problem now. The theme colors are all off. |
Hm, are those now not like: fa808d7 ? |
This reverts commit fa3911e. fixes vim-airline#252
environment
if you are using terminal:
if you are using Neovim:
actual behavior
After fa3911e most of the randomly checked base16* themes looks the same (the left part on the screenshot)
expected behavior
The right part of the screenshot, the commit fa808d7
screen shot (if possible)
The text was updated successfully, but these errors were encountered: