Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete badcat theme #206

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Conversation

get-me-power
Copy link
Member

Hi, Christian.
Look at this link.

https://github.com/emanuelrosa/badcat/tree/master/autoload/airline/themes

I think badcat theme should remove this repo.
Could you check this Pull Request?

Related PR

#200

@get-me-power
Copy link
Member Author

@chrisbra
I want to merge this patch.
Is that okay?

@chrisbra
Copy link
Member

thanks.

@chrisbra chrisbra merged commit 7f2081e into vim-airline:master Jan 21, 2020
@get-me-power
Copy link
Member Author

Thanks for checking this Pull Request.

@get-me-power get-me-power deleted the delete_badcat_theme branch January 21, 2020 08:37
@r888800009
Copy link

I think this merge is destructive for this repo theme diversity and backward compatibility, you should add some information to prevent people waste time a lot of time to find this issue to fix the problem, maybe check the theme is removed from vim-airline-themes and show hint, or in document highlight how to find the upstream.

@r888800009
Copy link

For example, I used the vice theme, and the airline would show the error Could not resolve airline theme "vice". Themes have been migrated to github.com/vim-airline/vim-airline-themes., this is not helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants