Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash_pbkdf2 $options parameter #10110

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Aug 13, 2023

`$options` parameter actually appeared in 8.1 (in [1]) but wasn't documented until 8.1.22

* [1] php/php-src@110b4e9
@weirdan weirdan added internal stubs/callmap release:fix The PR will be included in 'Fixes' section of the release notes labels Aug 13, 2023
@weirdan
Copy link
Collaborator Author

weirdan commented Aug 13, 2023

This fixes unit test failures on Win/8.1.22 (it appears 8.1.22 is not yet available for Linux jobs).

@weirdan weirdan merged commit 9bc98ec into vimeo:5.x Aug 13, 2023
48 of 49 checks passed
@weirdan weirdan deleted the fix-hash_pbkdf2-options-parameter branch August 13, 2023 19:36
oguzhand95 referenced this pull request in cerbos/cerbos-sdk-php Aug 21, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [google/protobuf](https://developers.google.com/protocol-buffers/)
([source](https://github.com/protocolbuffers/protobuf-php)) | require
| minor | `3.23.4` -> `3.24.1` |
| [grpc/grpc](https://grpc.io)
([source](https://github.com/grpc/grpc-php)) | require | minor |
`1.52.0` -> `1.57.0` |
| [phpstan/phpstan](https://github.com/phpstan/phpstan) | require-dev
| patch | `1.10.27` -> `1.10.29` |
| [phpunit/phpunit](https://phpunit.de/)
([source](https://github.com/sebastianbergmann/phpunit)) | require-dev
| patch | `10.3.1` -> `10.3.2` |
| [vimeo/psalm](https://github.com/vimeo/psalm) | require-dev | minor
| `5.14.1` -> `5.15.0` |

---

### Release Notes

<details>
<summary>protocolbuffers/protobuf-php (google/protobuf)</summary>

###
[`v3.24.1`](https://github.com/protocolbuffers/protobuf-php/compare/v3.24.0...v3.24.1)

[Compare
Source](https://github.com/protocolbuffers/protobuf-php/compare/v3.24.0...v3.24.1)

###
[`v3.24.0`](https://github.com/protocolbuffers/protobuf-php/compare/v3.23.4...v3.24.0)

[Compare
Source](https://github.com/protocolbuffers/protobuf-php/compare/v3.23.4...v3.24.0)

</details>

<details>
<summary>grpc/grpc-php (grpc/grpc)</summary>

###
[`v1.57.0`](https://github.com/grpc/grpc-php/compare/v1.52.0...v1.57.0)

[Compare
Source](https://github.com/grpc/grpc-php/compare/v1.52.0...v1.57.0)

</details>

<details>
<summary>phpstan/phpstan (phpstan/phpstan)</summary>

###
[`v1.10.29`](https://github.com/phpstan/phpstan/releases/tag/1.10.29)

[Compare
Source](https://github.com/phpstan/phpstan/compare/1.10.28...1.10.29)

# Improvements 🔧

-   Update nikic/php-parser to v4.17.1
- PHP 8.3 features are no longer parse errors. Full-fledged PHP 8.3
support is coming later this year.
-   Update BetterReflection to 6.12.0

# Bugfixes 🐛

- PHPStan Pro - when launching, `PHP_BINARY` needs to be escaped
(phpstan/phpstan-src@2c7cfd8)

# Function signature fixes 🤖

- Fix FTP-related function signatures
([#&#8203;2551](https://github.com/phpstan/phpstan-src/pull/2551)),
thanks [@&#8203;thg2k](https://github.com/thg2k)!

###
[`v1.10.28`](https://github.com/phpstan/phpstan/releases/tag/1.10.28)

[Compare
Source](https://github.com/phpstan/phpstan/compare/1.10.27...1.10.28)

# Improvements 🔧

- Update BetterReflection to 6.12.0
(phpstan/phpstan-src@7c49c94)

# Bugfixes 🐛

- Nullsafe operator on `null` results in `null`
(phpstan/phpstan-src@5c40c85),
[#&#8203;9721](https://github.com/phpstan/phpstan/issues/9721)
- Properties set in the native constructor are initialized in additional
constructors
(phpstan/phpstan-src@1b0c6a0),
[#&#8203;9619](https://github.com/phpstan/phpstan/issues/9619)
- Fix performance problem with nested BooleanOr and BooleanAnd
(phpstan/phpstan-src@9adae6c),
[#&#8203;9690](https://github.com/phpstan/phpstan/issues/9690),
[#&#8203;9676](https://github.com/phpstan/phpstan/issues/9676)
- CallableTypeHelper - copy variadic parameters if the accepting closure
has more parameters
(phpstan/phpstan-src@31ed326),
[#&#8203;9699](https://github.com/phpstan/phpstan/issues/9699)

# Internals 🔍

- Simplify access to ClassReflection in ClassPropertyNode
([#&#8203;2565](https://github.com/phpstan/phpstan-src/pull/2565)),
thanks [@&#8203;mad-briller](https://github.com/mad-briller)!

</details>

<details>
<summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary>

###
[`v10.3.2`](https://github.com/sebastianbergmann/phpunit/compare/10.3.1...10.3.2)

[Compare
Source](https://github.com/sebastianbergmann/phpunit/compare/10.3.1...10.3.2)

</details>

<details>
<summary>vimeo/psalm (vimeo/psalm)</summary>

### [`v5.15.0`](https://github.com/vimeo/psalm/releases/tag/5.15.0)

[Compare
Source](https://github.com/vimeo/psalm/compare/5.14.1...5.15.0)

<!-- Release notes generated using configuration in .github/release.yml
at 5.x -->

#### What's Changed

##### Features

- Check if argument passed to isset() is not a variable by
[@&#8203;Nitamet](https://github.com/Nitamet) in
[https://github.com/vimeo/psalm/pull/10068](https://github.com/vimeo/psalm/pull/10068)
- Fix [#&#8203;9997](https://github.com/vimeo/psalm/issues/9997)
dynamic properties on SimpleXmlElement by
[@&#8203;ygottschalk](https://github.com/ygottschalk) in
[https://github.com/vimeo/psalm/pull/10049](https://github.com/vimeo/psalm/pull/10049)
- Nicer PHP version checking by
[@&#8203;Nitamet](https://github.com/Nitamet) in
[https://github.com/vimeo/psalm/pull/10129](https://github.com/vimeo/psalm/pull/10129)

##### Fixes

- Fixed `DOMDocument::load*` signatures by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10073](https://github.com/vimeo/psalm/pull/10073)
- make (s)printf error reporting more correct/literal by
[@&#8203;kkmuffme](https://github.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/10088](https://github.com/vimeo/psalm/pull/10088)
- Fix parameter having `object` type in PHPDoc and only `&` in the
method's definition, used with code having an object calling it's method
with itself as an argument for mentioned parameter by
[@&#8203;kubawerlos](https://github.com/kubawerlos) in
[https://github.com/vimeo/psalm/pull/10104](https://github.com/vimeo/psalm/pull/10104)
- mysqli_field_seek returns true by
[@&#8203;kamil-tekiela](https://github.com/kamil-tekiela) in
[https://github.com/vimeo/psalm/pull/10107](https://github.com/vimeo/psalm/pull/10107)
- Fix bcdiv nullable scale stub by
[@&#8203;TheDevick](https://github.com/TheDevick) in
[https://github.com/vimeo/psalm/pull/10106](https://github.com/vimeo/psalm/pull/10106)
- Cleanup `test` command and `fixAll` action by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10108](https://github.com/vimeo/psalm/pull/10108)
- Correct type for `$enum->name` by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10109](https://github.com/vimeo/psalm/pull/10109)
- argv and argc were inconsistent in Context with VariableFetchAnalyzer
by [@&#8203;kkmuffme](https://github.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/10093](https://github.com/vimeo/psalm/pull/10093)
- Fix `hash_pbkdf2` `$options` parameter by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10110](https://github.com/vimeo/psalm/pull/10110)
- Forbid faulty `nikic/php-parser` version by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10112](https://github.com/vimeo/psalm/pull/10112)
- `strip_tags()/$allowed_tags` can accept arrays since 7.4 by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10122](https://github.com/vimeo/psalm/pull/10122)
- Fix crash when assertion array is not a list by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10123](https://github.com/vimeo/psalm/pull/10123)
- Fix crash on array access to undefined class by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10134](https://github.com/vimeo/psalm/pull/10134)
- Correct exit code for invalid version format by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10135](https://github.com/vimeo/psalm/pull/10135)

#### New Contributors

- [@&#8203;Nitamet](https://github.com/Nitamet) made their first
contribution in
[https://github.com/vimeo/psalm/pull/10068](https://github.com/vimeo/psalm/pull/10068)
- [@&#8203;TheDevick](https://github.com/TheDevick) made their first
contribution in
[https://github.com/vimeo/psalm/pull/10106](https://github.com/vimeo/psalm/pull/10106)

**Full Changelog**:
vimeo/psalm@5.14.1...5.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos-sdk-php).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
tcarrio referenced this pull request in open-feature/php-sdk Sep 21, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [vimeo/psalm](https://github.com/vimeo/psalm) | require-dev | minor
| `~5.14.0` -> `~5.15.0` |

---

### Release Notes

<details>
<summary>vimeo/psalm (vimeo/psalm)</summary>

### [`v5.15.0`](https://github.com/vimeo/psalm/releases/tag/5.15.0)

[Compare
Source](https://github.com/vimeo/psalm/compare/5.14.1...5.15.0)

<!-- Release notes generated using configuration in .github/release.yml
at 5.x -->

#### What's Changed

##### Features

- Check if argument passed to isset() is not a variable by
[@&#8203;Nitamet](https://github.com/Nitamet) in
[https://github.com/vimeo/psalm/pull/10068](https://github.com/vimeo/psalm/pull/10068)
- Fix [#&#8203;9997](https://github.com/vimeo/psalm/issues/9997)
dynamic properties on SimpleXmlElement by
[@&#8203;ygottschalk](https://github.com/ygottschalk) in
[https://github.com/vimeo/psalm/pull/10049](https://github.com/vimeo/psalm/pull/10049)
- Nicer PHP version checking by
[@&#8203;Nitamet](https://github.com/Nitamet) in
[https://github.com/vimeo/psalm/pull/10129](https://github.com/vimeo/psalm/pull/10129)

##### Fixes

- Fixed `DOMDocument::load*` signatures by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10073](https://github.com/vimeo/psalm/pull/10073)
- make (s)printf error reporting more correct/literal by
[@&#8203;kkmuffme](https://github.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/10088](https://github.com/vimeo/psalm/pull/10088)
- Fix parameter having `object` type in PHPDoc and only `&` in the
method's definition, used with code having an object calling it's method
with itself as an argument for mentioned parameter by
[@&#8203;kubawerlos](https://github.com/kubawerlos) in
[https://github.com/vimeo/psalm/pull/10104](https://github.com/vimeo/psalm/pull/10104)
- mysqli_field_seek returns true by
[@&#8203;kamil-tekiela](https://github.com/kamil-tekiela) in
[https://github.com/vimeo/psalm/pull/10107](https://github.com/vimeo/psalm/pull/10107)
- Fix bcdiv nullable scale stub by
[@&#8203;TheDevick](https://github.com/TheDevick) in
[https://github.com/vimeo/psalm/pull/10106](https://github.com/vimeo/psalm/pull/10106)
- Cleanup `test` command and `fixAll` action by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10108](https://github.com/vimeo/psalm/pull/10108)
- Correct type for `$enum->name` by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10109](https://github.com/vimeo/psalm/pull/10109)
- argv and argc were inconsistent in Context with VariableFetchAnalyzer
by [@&#8203;kkmuffme](https://github.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/10093](https://github.com/vimeo/psalm/pull/10093)
- Fix `hash_pbkdf2` `$options` parameter by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10110](https://github.com/vimeo/psalm/pull/10110)
- Forbid faulty `nikic/php-parser` version by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10112](https://github.com/vimeo/psalm/pull/10112)
- `strip_tags()/$allowed_tags` can accept arrays since 7.4 by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10122](https://github.com/vimeo/psalm/pull/10122)
- Fix crash when assertion array is not a list by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10123](https://github.com/vimeo/psalm/pull/10123)
- Fix crash on array access to undefined class by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10134](https://github.com/vimeo/psalm/pull/10134)
- Correct exit code for invalid version format by
[@&#8203;weirdan](https://github.com/weirdan) in
[https://github.com/vimeo/psalm/pull/10135](https://github.com/vimeo/psalm/pull/10135)

#### New Contributors

- [@&#8203;Nitamet](https://github.com/Nitamet) made their first
contribution in
[https://github.com/vimeo/psalm/pull/10068](https://github.com/vimeo/psalm/pull/10068)
- [@&#8203;TheDevick](https://github.com/TheDevick) made their first
contribution in
[https://github.com/vimeo/psalm/pull/10106](https://github.com/vimeo/psalm/pull/10106)

**Full Changelog**:
vimeo/psalm@5.14.1...5.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-feature/php-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal stubs/callmap release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant