Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetAdaptiveVideoFileURL_Returns_Dash_By_Default Unit Test returns HLS on macOS #87

Closed
juniorxsound opened this issue May 3, 2019 · 1 comment
Closed

GetAdaptiveVideoFileURL_Returns_Dash_By_Default Unit Test returns HLS on macOS #87

juniorxsound opened this issue May 3, 2019 · 1 comment
Assignees
@juniorxsound
Labels
bug 🐛
Milestone
0.9.5

Comments

@juniorxsound
Copy link
Contributor

Describe the issue

The unit test GetAdaptiveVideoFileURL_Returns_Dash_By_Default returns HLS manifest on macOS by default because of isHlsPlatform check and failing.

Steps to reproduce the problem

Run GetAdaptiveVideoFileURL_Returns_Dash_By_Default

Unity version

2019/2018/2017

Operating system

macOS 10.14.4
@juniorxsound juniorxsound added this to the 0.9.5 milestone May 3, 2019
@juniorxsound juniorxsound self-assigned this May 3, 2019
@juniorxsound juniorxsound changed the title GetAdaptiveVideoFileURL_Returns_Dash_By_Default Unit Test returns HLS on macOS GetAdaptiveVideoFileURL_Returns_Dash_By_Default Unit Test returns HLS on macOS May 3, 2019
juniorxsound added a commit that referenced this issue May 3, 2019
@juniorxsound
Fixing adaptive URL unit testing so it takes the test platform into a…
d9964e2 
…ccount (#87)

If it is an Apple platform expect HLS manifest, else expect a DASH manifest
juniorxsound added a commit that referenced this issue May 3, 2019
@juniorxsound
Unity 2019 Fixes (#86)
1635589 
* Updating the Canvas Player example scene to fix Unity 2019 Audio Source on RectTransform bug 🐛

* Removing PS2 as a build target as it is no longer supported in Unity 2019 (#82)

* Making the CanvasPlayer menu item create an AudioSource on the camera to avoid making a 2D RectTransform AudioSource (#85)

* Fixing adaptive URL unit testing so it takes the test platform into account (#87)

If it is an Apple platform expect HLS manifest, else expect a DASH manifest
@juniorxsound
Copy link
Contributor Author

Fixed in #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juniorxsound juniorxsound

Labels
bug 🐛
Projects
None yet
Milestone
0.9.5
Development

No branches or pull requests
1 participant
@juniorxsound