Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replaced connect method in save-modal, stop-bot-modal and w… #8

Closed
wants to merge 1 commit into from
Closed

refactor: replaced connect method in save-modal, stop-bot-modal and w… #8

wants to merge 1 commit into from

Conversation

vinu-deriv
Copy link
Owner

…orkspace-control files

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vinu-deriv vinu-deriv force-pushed the replace-connect-method-dbot branch from 006e1c4 to f1e6d6c Compare May 31, 2023 05:31
@vinu-deriv vinu-deriv closed this May 31, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@likhith-deriv @yauheni-deriv @shahzaib-deriv
accounts package ts migration and refactor - sprint 8 (binary-com#9791)
c2e6360 
* fix: ⚡ refactored Address-details component

* fix: 🎨 failing testcases

* refactor: ♻️ incorporated review comments

* feat: 🔥 removed PlatformContext

* fix: testcase failure

* refactor: ♻️ incorporated review comments

* refactor: ♻️ refactor component to remove unwanted code (binary-com#44)

* refactor: ♻️ refactor component to remove unwanted code

* feat: removed commented code

* test: ✅ added testcase

* test: 🧪 added tests

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* refactor: ♻️ migrated code to TS (binary-com#45)

* refactor: ♻️ migrated code to TS

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* Update packages/account/src/Types/common-prop.type.ts

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>

* refactor: ⚡ refactored currency selector component (binary-com#43)

* refactor: ⚡ refactored currency selector component

* fix: 🚨 lint errors

* feat: incorporated store values

* fix: 🎨 split code into small components

* fix: 🎨 removed un-necessary array

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* resolved failing test cases

* chore: incorporated review comment

* fix: build issue

* fix: build issue

* ref: incorporated review comments

* refactor: Modified code to contain hooks

* refactor: Modified code to contain hooks

* replaced test component

* fix: eslint issues

* fix: failing testcases

* ref: Incorporated review somments

* Likhith/webrel 780/migrate Email and password section (#7)

* chore: migrated deriv-email and unlink component

* chore: migrate password-platform to tsx

* chore: migrate password-platform to tsx

* chore: added missing test cases

* ref: incorporated review comments

* refactor: incorporated review comments

* refactor: incorporated review comments

* refactor: incorporated review comments

* ref: Incorporated review somments

* chore: config files ts migration and refactor (#8)

* chore: config files ts migartion and refactor

* refactor: test case for config func

* fix: config typing

* refactor: remove custom accounts residence type

* refactor: review comment

* chore: added test cases

* fix: revert boolean in types

* refactor: default value fields

* refactor: files types, import react types

* refactor: react types

* fix: condition rule

* fix: failing testcase

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>

* fix: incorporated review comments

* fix: failing testcase

* refactor: migrate form-fields file (#10)

* refactor: migrate form-fields file

* refactor: migrate form-fields file

* ref: incorporated review comments

* fix: failing testcase

* fix: incorporated review comments

* fix: incorporated review comments

* fix: incorporated review comments

* fix: resolved Sonar lint errors

* fix: tslint issues

* fix: review comments

* fix: review comments

* refactor: 🎨 incorporated types for test cases

* fix: 🦺 incorporated review comments

* fix: 🎨 incorporated ui-store-fix

* fix: ⚰️ replaced deprecated hooks

* fix: 🔥 unused dependency

* Merge branch 'master' into KYC-accounts-package-TS-migration--test-coverage/sprint-8

* chore: added package-lock

* fix: added value for mock-store

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Co-authored-by: Shahzaib <shahzaib@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vinu-deriv