Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delegated identity support #244

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

fnuarnav
Copy link
Collaborator

@fnuarnav fnuarnav commented Aug 10, 2022

Delegated Identity support along with MI for image pull

Request sent to ACI for pod with delegated identity
image

@fnuarnav fnuarnav temporarily deployed to test August 10, 2022 18:42 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 10, 2022 18:42 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 10, 2022 19:02 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 10, 2022 19:02 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 11, 2022 00:41 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 11, 2022 00:41 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 19, 2022 02:02 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 19, 2022 02:02 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #244 (181050b) into master (3c7d589) will increase coverage by 0.37%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   42.92%   43.30%   +0.37%     
==========================================
  Files          35       35              
  Lines        3471     3621     +150     
==========================================
+ Hits         1490     1568      +78     
- Misses       1800     1866      +66     
- Partials      181      187       +6     
Impacted Files Coverage Δ
client/aci/client.go 70.00% <ø> (ø)
client/aci/list.go 27.27% <0.00%> (-33.60%) ⬇️
provider/aci.go 38.36% <81.08%> (+1.94%) ⬆️
provider/aciMock.go 68.46% <83.33%> (+4.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fnuarnav fnuarnav temporarily deployed to test August 19, 2022 02:30 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 26, 2022 17:26 Inactive
@fnuarnav fnuarnav temporarily deployed to test August 26, 2022 17:26 Inactive
@helayoty helayoty changed the title Fnuarnav/delegated identity support feat: delegated identity support Sep 14, 2022
@@ -69,3 +68,69 @@ func (c *Client) ListContainerGroups(ctx context.Context, resourceGroup string)

return &list, nil
}

func (c *Client) ListAKSClusters(ctx context.Context, resourceGroup string) (*AKSClusterListResult, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After migrating to use nodeUtils, you should find an easier way to get k8s configs using
k8sClient, err := nodeutil.ClientsetFromEnv(kubeConfigPath)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants