-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delegated identity support #244
Open
fnuarnav
wants to merge
55
commits into
virtual-kubelet:master
Choose a base branch
from
suselva:fnuarnav/delegated-identity-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
e979e99
ignore helm init and pod specs example
t-ysalazar bdf2cc1
Revert "ignore helm init and pod specs example"
t-ysalazar 1cc644e
MI for image pull and mock test endpoint
fnuarnav 6264659
add defualt image server when nothing is provided
fnuarnav a0530aa
added unit tests for MI
fnuarnav 7216493
fix error; remove print statements
fnuarnav 1a4ed8f
removed unused pod identity object
fnuarnav df701e1
use pointer variable for ContainerGroup.Identity
fnuarnav d846f64
added comments to describe types
fnuarnav ec26969
update comments
fnuarnav 14c2f04
only add image reigstry creds for acr servernames
fnuarnav 4f9b1e2
Merge branch 'virtual-kubelet:master' into master
t-ysalazar 3c9d25a
Merge branch 'virtual-kubelet:master' into master
t-ysalazar b29a7c8
Merge branch 'fnuarnav/feature/mi-for-image-pull' into t-ysalazar/mi-…
t-ysalazar 3b86b2f
rebase with master
t-ysalazar 8adcb62
e2e 1, create cluster
t-ysalazar c9cda56
E2E delete cluster after test
t-ysalazar cc98532
e2e get client secret
t-ysalazar 2039759
e2e add managed-identity
t-ysalazar 48fa251
e2e get masterURI
t-ysalazar 8189ffa
e2e helm
t-ysalazar e2aa4d1
e2e fix miURL
t-ysalazar e9eb315
e2e fix miURL
t-ysalazar e890b06
e2e mi pull pod
t-ysalazar 03ca373
TestImagePullUsingKubeletIdentityAndSecrets
t-ysalazar fc2226e
e2e test TestImagePullUsingKubeletIdentityAndSecrets assign role MI
t-ysalazar 4eabd8e
deployments_test const
t-ysalazar bfb5706
factorize TestImagePullUsingKubeletIdentity
t-ysalazar 5f441ec
fix delete cluster
t-ysalazar d69ed08
e2e TestImagePull_KubeletIdentityInAKSCLuster/virtual_node_with_manag…
t-ysalazar ec1c281
e2e TestAKSDeployment_attachACR
t-ysalazar 38e454f
TestImagePull_KubeletIdentityInAKSCLuster/virtual_node_with_no_secrets
t-ysalazar fe5cbd1
Merge branch 'virtual-kubelet:master' into master
t-ysalazar a823e5f
TestImagePull_KubeletIdentityInAKSCLuster
t-ysalazar 884c479
fix merge conflict
t-ysalazar 583d23d
Merge pull request #2 from t-ysalazar/t-ysalazar/mi-for-image-pull
suselva 186a6fb
remove comment
suselva 43df01a
Merge branch 'virtual-kubelet:master' into suselva/mi-image-pull
suselva d935e7c
update regex string escape
suselva 093ca98
fix compatibility
t-ysalazar 797c58e
parallelization
t-ysalazar a0ed92a
comments
t-ysalazar 80e7dee
Merge branch 'virtual-kubelet:master' into t-ysalazar/mi-for-image-pull
t-ysalazar d6693be
Merge pull request #3 from t-ysalazar/t-ysalazar/mi-for-image-pull
t-ysalazar f9bfbec
Merge branch 't-ysalazar/mi-for-image-pull' of https://github.com/t-y…
t-ysalazar 8545cad
e2e fix node assignation
t-ysalazar bed4401
Merge pull request #4 from t-ysalazar/t-ysalazar/mi-for-image-pull
t-ysalazar 1ad2fdc
Merge branch 'master' into suselva/mi-image-pull
ryanzhang-oss c2d3e42
dynamic values in mi-image-pull podspecs
t-ysalazar f10e459
Merge pull request #5 from t-ysalazar/t-ysalazar/mi-for-image-pull
t-ysalazar b93be3d
add RG and location to helm; add azure dns ip to aci request
fnuarnav 91812cf
supporting delegated identities passed as annotations
fnuarnav 807a43f
use correct name DelegatedResources
fnuarnav c5772c3
read entire delegated resouces from base64 encoded annotation
fnuarnav 181050b
acr names can have numbers
fnuarnav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After migrating to use nodeUtils, you should find an easier way to get k8s configs using
k8sClient, err := nodeutil.ClientsetFromEnv(kubeConfigPath)