Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update size recommendation endpoints #100

Merged

Conversation

DharmeshBasapatiBacancy
Copy link
Contributor

Description

  • Updated Size Recommendation API related URL, request model, response model.
  • Added environment related size recommendation base URLs.
  • Also did changes on test cases related to size recommendation API and verified it.
  • Unit tested both the scenarios for male and female and their sizes.

Demo

N/A

Ticket

https://app.clickup.com/t/3702259/NSDK-178

- Updated Size Recommendation API related URL, request model, response model.
- Added environment related size recommendation base URLs.
- Also did changes on test cases related to size recommendation API and verified it.
- Unit tested both the scenarios for male and female and their sizes.
- Updated code to remove ktlint errors.
- Updated code to remove ktlint errors. #2
- Updated code to remove ktlint errors. #3
- Updated code to remove ktlint errors. #4
- Updated code to remove ktlint errors. #5
- Updated code to remove ktlint errors. #6
- Updated unit test code where tests are failing.
Copy link
Contributor

@ourognao ourognao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Updated uriString with string template.
- Updated code to remove ktlint errors.
Copy link
Contributor

@ourognao ourognao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fat-face-cat

@DharmeshBasapatiBacancy DharmeshBasapatiBacancy merged commit 4316ab7 into develop Jan 24, 2024
3 checks passed
@ourognao ourognao deleted the feature/update_size_recommendation_endpoints branch January 24, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants