-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update size recommendation endpoints #100
Merged
DharmeshBasapatiBacancy
merged 10 commits into
develop
from
feature/update_size_recommendation_endpoints
Jan 24, 2024
Merged
Update size recommendation endpoints #100
DharmeshBasapatiBacancy
merged 10 commits into
develop
from
feature/update_size_recommendation_endpoints
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Size Recommendation API related URL, request model, response model. - Added environment related size recommendation base URLs. - Also did changes on test cases related to size recommendation API and verified it. - Unit tested both the scenarios for male and female and their sizes.
- Updated code to remove ktlint errors.
- Updated code to remove ktlint errors. #2
- Updated code to remove ktlint errors. #3
- Updated code to remove ktlint errors. #4
- Updated code to remove ktlint errors. #5
- Updated code to remove ktlint errors. #6
- Updated unit test code where tests are failing.
ourognao
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DharmeshBasapatiBacancy 1 comment
virtusize-core/src/main/java/com/virtusize/android/network/VirtusizeApi.kt
Outdated
Show resolved
Hide resolved
- Updated uriString with string template.
- Updated code to remove ktlint errors.
ourognao
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demo
N/A
Ticket
https://app.clickup.com/t/3702259/NSDK-178