Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NSDK-215] Update Virtusize WebView URL - General Use #115

Merged
merged 18 commits into from
Oct 7, 2024
Merged

[NSDK-215] Update Virtusize WebView URL - General Use #115

merged 18 commits into from
Oct 7, 2024

Conversation

akueisara
Copy link
Contributor

@akueisara akueisara commented Oct 5, 2024 •
edited
Loading

🔗 Related Links

➡️ To Be

  • Used https://static.api.virtusize.${env, e.g. com, jp, kr}/a/aoyama/${version}/sdk-webview.html for the web view
  • Changed the web view color to white from black because there's a loading time to load the web view version before loading the web page.
  • Refactored some unit tests

☑️ Checklist

  • Useless comments and/or Log.d etc are removed
  • Unit test are covered
  • Code has been deployed and tested on STG
  • ClickUp ticket status has been updated to production
  • Update CHANGELOG.md with the new changes

@akueisara akueisara requested a review from ourognao October 6, 2024 02:32
@akueisara akueisara self-assigned this Oct 6, 2024
@akueisara akueisara marked this pull request as ready for review October 6, 2024 02:32
ourognao
ourognao approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ourognao ourognao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat-flower

@akueisara akueisara changed the base branch from main to trunk October 7, 2024 13:51
@akueisara akueisara merged commit 45c4d02 into trunk Oct 7, 2024
3 checks passed
@akueisara akueisara deleted the feature/update-general-aoyama-URL branch October 7, 2024 14:35
akueisara added a commit that referenced this pull request Oct 13, 2024
@akueisara
[NSDK-215] Update Virtusize WebView URL - General Use (#115)
61cb36b 
* Change the web view URL

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fix unit tests

* Add and fix unit tests

* Make VirtusizeApiTest internal

* Fix unit tests

* Make tests internal

* Change the URL

* Add unit test for fetchLatestAoyamaVersion

* Change the web view background color

* Refactor the way to get the response of a/aoyama/latest.txt

* Use DEFAULT_AOYAMA_VERSION for the version string

* Add VirtusizeApiResponseFormat for the VirtusizeApiTask

* Update pre-push script

* Fix unit test

* Remove suspend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ourognao ourognao ourognao approved these changes

Assignees

@akueisara akueisara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akueisara @ourognao