Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NSDK-240][NSDK-241][NSDK-242] Fix InPage Issues #122

Merged
merged 30 commits into from
Nov 25, 2024
Merged

[NSDK-240][NSDK-241][NSDK-242] Fix InPage Issues #122

merged 30 commits into from
Nov 25, 2024

Conversation

akueisara
Copy link
Contributor

@akueisara akueisara commented Nov 21, 2024 •
edited
Loading

🔗 Related Links

⬅️ As Is

  • [NSDK-240] Inpage doesn’t recommend anything after coming back to PDP from Comparison screen
  • [NSDK-241] Inpage shows different size from that VS widget shows
  • [NSDK-242] Body data tuning is not saved once closing the widget

➡️ To Be

  • Fixed [NSDK-240] Inpage doesn’t recommend anything after coming back to PDP from Comparison screen
Screen.Recording.2024-11-24.at.20.03.30.mov
  • [NSDK-241] Fixed Inpage shows different size from that VS widget shows
  • [NSDK-242] Body data tuning is not saved once closing the widget
Screen.Recording.2024-11-24.at.20.18.37.mov

☑️ Checklist

  • Useless comments and/or Log.d etc are removed
  • Unit test are covered
  • Code has been deployed and tested on STG
  • ClickUp ticket status has been updated to production
  • Update CHANGELOG.md with the new changes

@akueisara
Refactor VirtusizeEvent
ca120b9
@akueisara
Apply ktlint
5aa56f5
@akueisara
Fix a unit test
636ea8a
@akueisara
Move the mapper function to the VirtusizeEventJsonParser file
951f96a
@akueisara
Apply ktlint
9683b9a
@akueisara
Modify a comment
c68e54d
@akueisara
Fix a unit test
50da263
@akueisara
Rename to BodyProfileRecommendedSize
ec9a3e7
@akueisara
Use camelCase
363eee1
@akueisara
Fix the renaming
6be0b18
@akueisara
Refactor BodyProfileRecommendedSizeJsonParser
6e35d9e
@akueisara
Fix a comment
3b21aec
@akueisara
Remove constructor
3cbdfe4
@akueisara
Remove @keep annotation
ef2e954
@akueisara
Fix unit tests
db11574
@akueisara
Set x-vs-external-user-id and x-vs-store-id headers
734b104
@akueisara
Apply ktlint
47ad485
@akueisara
Make variables immutable
b7b1e8e
@akueisara
Fix the test setup
d787123
@akueisara
Use VirtusizeApi to save caches
9afdb12
@akueisara
Fix the test setup
8a07ae8
@akueisara
Prioritise the body profile recommended size
7f3f775
@akueisara
Add new events
d9900c0
@akueisara
Apply ktlint
8616035
@akueisara
Remove setting the user ID to aoyama
d8764dd
@akueisara
Remove setting user ID
012c634
@akueisara
Rename ProductExternalId to ExternalProductId
3920a97
@akueisara akueisara self-assigned this Nov 24, 2024
@akueisara akueisara requested a review from ourognao November 24, 2024 11:22
@akueisara akueisara marked this pull request as ready for review November 24, 2024 11:22
@akueisara akueisara changed the title Fix/inpage issues [NSDK-240][NSDK-238][NSDK-241][NSDK-242] Fix InPage Issues Nov 24, 2024
ourognao
ourognao approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ourognao ourognao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

採用-cat

@akueisara akueisara merged commit 5bbed7c into trunk Nov 25, 2024
3 checks passed
@akueisara akueisara deleted the fix/inpage-issues branch November 25, 2024 13:04
@akueisara akueisara changed the title [NSDK-240][NSDK-238][NSDK-241][NSDK-242] Fix InPage Issues [NSDK-240][NSDK-241][NSDK-242] Fix InPage Issues Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ourognao ourognao ourognao approved these changes

Assignees

@akueisara akueisara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akueisara @ourognao