Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main): Add missing peerDependencies #8805

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

Pessimistress
Copy link
Collaborator

For #8802

Change List

  • Add missing sub module (arcgis)
  • Add missing peer dependencies for sub modules

"react-dom": ">=16.3.0"
},
"peerDependenciesMeta": {
"@arcgis/core": {"optional": true},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, interesting. This is the new optionalDependencies syntax? https://docs.npmjs.com/cli/v10/configuring-npm/package-json#optionaldependencies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know peerDependenciesMeta existed — that's so helpful! 🤯

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optionalDependencies still exist. peerDependenciesMeta is for peer dependencies instead of dependencies.

react-map-gl has been using it and nobody has complained.

@coveralls
Copy link

Coverage Status

coverage: 90.003% (+0.001%) from 90.002%
when pulling e9beec8 on x/main-package-fix
into fa029dd on master.

@Pessimistress Pessimistress merged commit 68a336d into master Apr 17, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/main-package-fix branch April 17, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants