Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main): Add missing peerDependencies #8805

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(main): Add missing peerDependencies #8805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions modules/main/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@
"prepublishOnly": "npm run build-bundle && npm run build-bundle -- --env=dev"
},
"dependencies": {
"@loaders.gl/core": "^4.2.0",
"@luma.gl/core": "^9.0.9",
"@luma.gl/engine": "^9.0.9",
"@deck.gl/aggregation-layers": "9.0.0-beta.10",
"@deck.gl/arcgis": "9.0.0-beta.10",
"@deck.gl/carto": "9.0.0-beta.10",
"@deck.gl/core": "9.0.0-beta.10",
"@deck.gl/extensions": "9.0.0-beta.10",
Expand All @@ -49,5 +53,15 @@
"@deck.gl/react": "9.0.0-beta.10",
"@deck.gl/widgets": "9.0.0-beta.10"
},
"peerDependencies": {
"@arcgis/core": "^4.0.0",
"react": ">=16.3.0",
"react-dom": ">=16.3.0"
},
"peerDependenciesMeta": {
"@arcgis/core": {"optional": true},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, interesting. This is the new optionalDependencies syntax? https://docs.npmjs.com/cli/v10/configuring-npm/package-json#optionaldependencies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know peerDependenciesMeta existed — that's so helpful! 🤯

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optionalDependencies still exist. peerDependenciesMeta is for peer dependencies instead of dependencies.

react-map-gl has been using it and nobody has complained.

"react": {"optional": true},
"react-dom": {"optional": true}
},
"gitHead": "13ace64fc2cee08c133afc882fc307253489a4e4"
}
Loading